Page MenuHomePhabricator
Differential D987

[backport] Multiwallet: simplest endpoint support
ClosedPublic
Actions

Authored by schancel on Jan 20 2018, 06:19.

Details

Reviewers
deadalnix
jasonbcox
matiu
Group Reviewers
Restricted Project
Maniphest Tasks
T173: Backport Core PR10849: Multiwallet: simplest endpoint support
T186: Backport Core PR10683: rpc: Move the `generate` RPC call to rpcwallet
Commits
rSTAGING91175ae4bbd2: [backport] Multiwallet: simplest endpoint support
rABC91175ae4bbd2: [backport] Multiwallet: simplest endpoint support
Summary

Backport of Core PR #10849: Multiwallet: simplest endpoint support

6b9faf7 [QA] add basic multiwallet test (Jonas Schnelli)
979d0b8 [tests] [wallet] Add wallet endpoint support to authproxy (John Newbery)
76603b1 Select wallet based on the given endpoint (Jonas Schnelli)
32c9710 Fix test_bitcoin circular dependency issue (Jonas Schnelli)
31e0720 Add wallet endpoint support to bitcoin-cli (-usewallet) (Jonas Schnelli)
dd2185c Register wallet endpoint (Jonas Schnelli)

Depends on D985, and D1003
Closes T173

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
depends-on-D985
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1690
Build 1690: arc lint + arc unit

Event Timeline

schancel created this revision.Jan 20 2018, 06:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2018, 06:19
Harbormaster completed remote builds in B1670: Diff 2601.Jan 20 2018, 06:19
teamcity added a subscriber: teamcity.Jan 20 2018, 06:21

Build https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=828 started.

schancel added a child revision: D988: [backport] Reject invalid wallets.Jan 20 2018, 06:27
schancel edited the summary of this revision. (Show Details)Jan 20 2018, 06:28
schancel added a parent revision: D985: [backport] [tests] fix wait_for_inv().
teamcity added a comment.Jan 20 2018, 06:41

Build https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=828 failed.

schancel mentioned this in T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.Jan 20 2018, 20:01
deadalnix requested changes to this revision.Jan 21 2018, 00:20
deadalnix added inline comments.
src/httpserver.cpp
664 ↗(On Diff #2601)

nullptr

test/functional/multiwallet.py
1 ↗(On Diff #2601)

Where does this file come from ? It is supposed to be created in that PR. Also, where is the change in the testrunner ?

This revision now requires changes to proceed.Jan 21 2018, 00:20
schancel updated this revision to Diff 2627.Jan 21 2018, 02:21

Rebase?

Harbormaster completed remote builds in B1689: Diff 2627.Jan 21 2018, 02:21
schancel updated this revision to Diff 2628.Jan 21 2018, 02:22

Rebase

teamcity added a comment.Jan 21 2018, 02:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1690: Diff 2628.Jan 21 2018, 02:22
teamcity added a comment.Jan 21 2018, 02:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 02:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2629.Jan 21 2018, 02:55

Fix nullptr

teamcity added a comment.Jan 21 2018, 02:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 03:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

teamcity added a comment.Jan 21 2018, 03:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2633.Jan 21 2018, 03:46

Rebase

teamcity added a comment.Jan 21 2018, 03:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 04:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2636.Jan 21 2018, 09:13

Rebase onto D1003

schancel edited the summary of this revision. (Show Details)Jan 21 2018, 09:15
schancel added a task: T186: Backport Core PR10683: rpc: Move the `generate` RPC call to rpcwallet.
schancel added a parent revision: D1003: [backport] rpc: Move the `generate` RPC call to rpcwallet.
teamcity added a comment.Jan 21 2018, 09:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 09:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2647.Jan 21 2018, 19:42

Rebase w/ memory header

teamcity added a comment.Jan 21 2018, 19:44

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 20:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel updated this revision to Diff 2658.Jan 21 2018, 23:07

Rebase

teamcity added a comment.Jan 21 2018, 23:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 23:28

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix accepted this revision.Jan 22 2018, 16:18
This revision is now accepted and ready to land.Jan 22 2018, 16:18
schancel edited the summary of this revision. (Show Details)Jan 22 2018, 18:42
schancel added a task: T173: Backport Core PR10849: Multiwallet: simplest endpoint support.
Closed by commit rABC91175ae4bbd2: [backport] Multiwallet: simplest endpoint support (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by schancel). · Explain WhyJan 22 2018, 23:43
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D3464: [rpc] Add logging RPC.Jun 29 2019, 00:47

Revision Contents
Changeset List

PathSize
src/
8 lines
30 lines
6 lines
2 lines
12 lines
wallet/
21 lines
test/
functional/
50 lines
test_framework/
3 lines
3 lines
1 line

Diff 2628

View Options

src/Makefile.test.include

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/httprpc.cpp

Loading...
View Options

src/httpserver.h

Loading...
View Options

src/httpserver.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/multiwallet.py

Loading...
View Options

test/functional/test_framework/authproxy.py

Loading...
View Options

test/functional/test_framework/coverage.py

Loading...
View Options

test/functional/test_runner.py

Loading...