Page MenuHomePhabricator
Differential D1064

[qa] Rewrite BIP65/BIP66 functional tests
ClosedPublic
Actions

Authored by deadalnix on Feb 3 2018, 13:43.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Maniphest Tasks
T669: Removing comparison test framework
Commits
rSTAGINGf31cd253f130: [qa] Rewrite BIP65/BIP66 functional tests
rABCf31cd253f130: [qa] Rewrite BIP65/BIP66 functional tests
Summary

Backport core's PR10695

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rewritebip
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1802
Build 1802: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 3 2018, 13:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2018, 13:43
Harbormaster completed remote builds in B1801: Diff 2808.Feb 3 2018, 13:43
teamcity added a subscriber: teamcity.Feb 3 2018, 13:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 3 2018, 14:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

deadalnix updated this revision to Diff 2810.Feb 3 2018, 16:40

Fix the tests. We always check for dersig on our side, so no dersig tx can get in the mempool, and we need to continue to check for FORKID sigs even when using promiscuous flag.

Harbormaster completed remote builds in B1802: Diff 2810.Feb 3 2018, 16:41
teamcity added a comment.Feb 3 2018, 16:43

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 3 2018, 17:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a child revision: D1065: qa: Move wait_until to util.Feb 3 2018, 17:51
schancel accepted this revision.Feb 3 2018, 22:25
This revision is now accepted and ready to land.Feb 3 2018, 22:25
Closed by commit rABCf31cd253f130: [qa] Rewrite BIP65/BIP66 functional tests (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyFeb 5 2018, 05:09
This revision was automatically updated to reflect the committed changes.
markblundeberg added a task: T669: Removing comparison test framework.Jul 1 2019, 20:59

Revision Contents
Changeset List

PathSize
src/
1 line
test/
functional/
268 lines
210 lines
6 lines

Diff 2810

View Options

src/validation.cpp

Loading...
View Options

test/functional/bip65-cltv-p2p.py

Loading...
View Options

test/functional/bip65-cltv.py

Loading...
View Options

test/functional/bipdersig-p2p.py

Loading...
View Options

test/functional/bipdersig.py

Loading...
View Options

test/functional/test_runner.py

Loading...