Page MenuHomePhabricator
Differential D1099

Adds OP_SPLIT functionality into interpreter.cpp
AbandonedPublic
Actions

Authored by schancel on Feb 15 2018, 01:13.

Details

Reviewers
movrcx
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Creates a new opcode OP_SPLIT that is used to bisect a bytestring.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1097
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2057
Build 2261: Bitcoin ABC Buildbot (legacy)
Build 2260: arc lint + arc unit

Event Timeline

movrcx created this revision.Feb 15 2018, 01:13
Harbormaster completed remote builds in B1853: Diff 2876.Feb 15 2018, 01:13
movrcx added a child revision: D1100: unit tests for OP_SPLIT.Feb 15 2018, 01:15
movrcx added parent revisions: D1097: Add support for CAT, and SPLIT opcodes, D1098: unit test for OP_CAT, D1093: Adds OP_DIV functionality into interpreter.cpp, D1092: unit test for bitwise operations (AND, OR, XOR), D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1090: Adds Bitwise functionality into interpreter.cpp, D1096: unit test for OP_MOD, D1095: Adds OP_MOD functionality into interpreter.cpp, D1094: unit test for OP_DIV.
movrcx added a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Feb 15 2018, 01:21
movrcx added a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Feb 15 2018, 01:26
movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:57
movrcx edited the summary of this revision. (Show Details)
shadders added a subscriber: shadders.Feb 15 2018, 03:23
movrcx updated this revision to Diff 2900.Feb 16 2018, 08:20

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

danconnolly added a subscriber: danconnolly.Feb 21 2018, 08:50
movrcx added a child revision: D1142: Added tests for disabled opcodes before/after the fork..Feb 28 2018, 01:58
schancel removed a child revision: D1142: Added tests for disabled opcodes before/after the fork..Mar 9 2018, 10:49
schancel removed a child revision: D1100: unit tests for OP_SPLIT.Mar 9 2018, 10:55
schancel removed parent revisions: D1094: unit test for OP_DIV, D1096: unit test for OP_MOD, D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1092: unit test for bitwise operations (AND, OR, XOR), D1098: unit test for OP_CAT.
schancel removed parent revisions: D1095: Adds OP_MOD functionality into interpreter.cpp, D1090: Adds Bitwise functionality into interpreter.cpp, D1093: Adds OP_DIV functionality into interpreter.cpp.Mar 9 2018, 11:02
schancel removed a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.
danconnolly edited the test plan for this revision. (Show Details)Mar 12 2018, 20:13
danconnolly updated this revision to Diff 3162.Mar 12 2018, 20:52

resubmit D1099 - OP_SPLIT

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 20:52
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 20:52
teamcity added a subscriber: teamcity.Mar 12 2018, 20:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

danconnolly added a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Mar 12 2018, 21:07
danconnolly removed a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
teamcity added a comment.Mar 12 2018, 21:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2057: Diff 3162.Mar 12 2018, 21:20
movrcx updated this revision to Diff 3226.Mar 16 2018, 02:49

Cleaning up due to D1202

teamcity added a comment.Mar 16 2018, 02:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 16 2018, 03:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2108: Diff 3226!Mar 16 2018, 03:08
movrcx updated this revision to Diff 3256.Mar 17 2018, 02:19

Rebase off of master

teamcity added a comment.Mar 17 2018, 02:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 17 2018, 03:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2135: Diff 3256!Mar 17 2018, 03:02
schancel commandeered this revision.Mar 18 2018, 02:16
schancel added a reviewer: movrcx.
schancel abandoned this revision.Mar 18 2018, 02:25
schancel removed a parent revision: D1097: Add support for CAT, and SPLIT opcodes.Mar 18 2018, 03:14

Revision Contents
Changeset List

PathSize
src/
script/
53 lines
1 line
2 lines
test/
100 lines

Diff 3162

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_error.cpp

Loading...
View Options

src/test/op_code.cpp

Loading...