Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCfeb2a01c3555: Block unsafe fs::path std::string conversion calls [7/7]

Summary

This concludes backport of core#22937 [2g/2g]
https://github.com/bitcoin/bitcoin/pull/22937/commits/6544ea5035268025207d2402db2f7d90fde947a6

This commit disallows passing a std::string to fs::path, building on previous commits which removed all such calls. This is because the behavior of this constructor on windows will be more complicated and can mangle path strings after the transition from boost::filesystem to std::filesystem in core#20744 .

Depends on D10800

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr22937

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17857
Build 35540: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35539: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 10 2022, 13:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2022, 13:06

PiRK requested review of this revision.Jan 10 2022, 13:06

teamcity edited the summary of this revision. (Show Details)Jan 10 2022, 13:06

PiRK retitled this revision from Block unsafe fs::path std::string conversion calls to Block unsafe fs::path std::string conversion calls [7/7].Jan 10 2022, 13:08

Harbormaster completed remote builds in B17857: Diff 31720.Jan 10 2022, 13:45

PiRK edited the summary of this revision. (Show Details)Jan 10 2022, 15:19

Fabien accepted this revision.Jan 11 2022, 10:04

This revision is now accepted and ready to land.Jan 11 2022, 10:04

Closed by commit rABCfeb2a01c3555: Block unsafe fs::path std::string conversion calls [7/7] (authored by PiRK). · Explain WhyJan 11 2022, 12:28

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfeb2a01c3555: Block unsafe fs::path std::string conversion calls [7/7].

PiRK mentioned this in D10815: Call unicode API on Windows.Jan 11 2022, 13:55

PiRK mentioned this in rABC891d5ad3c17f: Call unicode API on Windows.Jan 11 2022, 16:39