Page MenuHomePhabricator
Differential D1565

Move function checking encoding of public key and signature out of interpreter.{h/cpp}
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2018, 19:23.

Details

Reviewers
Mengerian
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING7525165654f6: Move function checking encoding of public key and signature out of interpreter.
rABC7525165654f6: Move function checking encoding of public key and signature out of interpreter.
Summary

This improves modularity and will allow for more targeted testing.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigencoding
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2879
Build 3862: Bitcoin ABC Buildbot (legacy)
Build 3861: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2018, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2018, 19:23
teamcity added a subscriber: teamcity.Jul 14 2018, 19:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 14 2018, 20:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2871: Diff 4304.Jul 14 2018, 20:03
deadalnix added a child revision: D1566: Add test for CheckPubKeyEncoding.Jul 15 2018, 01:00
Mengerian requested changes to this revision.Jul 15 2018, 20:04
Mengerian added a subscriber: Mengerian.
Mengerian added inline comments.
src/script/script_flags.h
1 ↗(On Diff #4304)

Minor nit: Probably good to carry over the "Satoshi Nakamoto" and "Bitcoin Core Developers" copyrights also.

src/script/sigencoding.cpp
1 ↗(On Diff #4304)

carry over Satoshi and Core copyright notices.

src/script/sigencoding.h
1 ↗(On Diff #4304)

Same here, carry over Satoshi and Core copyright notices.

This revision now requires changes to proceed.Jul 15 2018, 20:04
deadalnix updated this revision to Diff 4315.Jul 16 2018, 11:24

Add copyright bloat

teamcity added a comment.Jul 16 2018, 11:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2879: Diff 4315.Jul 16 2018, 11:58
teamcity added a comment.Jul 16 2018, 11:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mengerian accepted this revision.Jul 16 2018, 15:33

Macro lgtm:

This revision is now accepted and ready to land.Jul 16 2018, 15:33
jasonbcox accepted this revision.Jul 16 2018, 15:48
Closed by commit rABC7525165654f6: Move function checking encoding of public key and signature out of interpreter. (authored by deadalnix). · Explain WhyJul 16 2018, 18:11
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
3 lines
1 line
policy/
2 lines
1 line
script/
94 lines
205 lines
18 lines
script_flags.h
interpreter.h
92 lines
35 lines
184 lines
4 lines
test/
1 line

Diff 4315

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/core_write.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/script/interpreter.h

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_flags.h

Loading...
View Options

src/script/sigencoding.h

Loading...
View Options

src/script/sigencoding.cpp

Loading...
View Options

src/script/standard.h

Loading...
View Options

src/test/sigopcount_tests.cpp

Loading...