Differential D1565

Move function checking encoding of public key and signature out of interpreter.{h/cpp}
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2018, 19:23.

Tags

None

Subscribers

Details

Reviewers

Mengerian
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING7525165654f6: Move function checking encoding of public key and signature out of interpreter.
rABC7525165654f6: Move function checking encoding of public key and signature out of interpreter.

Summary

This improves modularity and will allow for more targeted testing.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sigencoding

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2871
Build 3846: Bitcoin ABC Buildbot (legacy)
Build 3845: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2018, 19:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2018, 19:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2871: Diff 4304.Jul 14 2018, 20:03

deadalnix added a child revision: D1566: Add test for CheckPubKeyEncoding.Jul 15 2018, 01:00

Mengerian requested changes to this revision.Jul 15 2018, 20:04

Mengerian added a subscriber: Mengerian.

Mengerian added inline comments.

src/script/script_flags.h
1	Minor nit: Probably good to carry over the "Satoshi Nakamoto" and "Bitcoin Core Developers" copyrights also.
src/script/sigencoding.cpp
1	carry over Satoshi and Core copyright notices.
src/script/sigencoding.h
1	Same here, carry over Satoshi and Core copyright notices.

This revision now requires changes to proceed.Jul 15 2018, 20:04

Add copyright bloat

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2879: Diff 4315.Jul 16 2018, 11:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Macro lgtm:

This revision is now accepted and ready to land.Jul 16 2018, 15:33

jasonbcox accepted this revision.Jul 16 2018, 15:48

Closed by commit rABC7525165654f6: Move function checking encoding of public key and signature out of interpreter. (authored by deadalnix). · Explain WhyJul 16 2018, 18:11

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

1 line

3 lines

1 line

policy/

2 lines

1 line

script/

94 lines

interpreter.cpp

205 lines

18 lines

	script_flags.h
	interpreter.h

94 lines

33 lines

sigencoding.cpp

182 lines

4 lines

test/

sigopcount_tests.cpp

1 line

Diff 4304

src/CMakeLists.txt

Loading...

src/Makefile.am

Loading...

src/core_write.cpp

Loading...

src/policy/policy.h

Loading...

src/policy/policy.cpp

Loading...

src/script/interpreter.h

Loading...

src/script/interpreter.cpp

Loading...

src/script/script_error.h

Loading...

src/script/script_flags.h

Loading...

src/script/sigencoding.h

Loading...

src/script/sigencoding.cpp

Loading...

src/script/standard.h

Loading...

src/test/sigopcount_tests.cpp

Loading...