Page MenuHomePhabricator
Differential D1655

Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies.
ClosedPublic
Actions

Authored by nakihito on Aug 14 2018, 20:27.

Details

Reviewers
jasonbcox
schancel
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .
rABC1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .
Summary

Contiues work on T380, dependent on D1654. The class CDiskBlockPos originally located in Chain.h has been seperated from Chain.h and placed into its own .h file (diskblockpos.h).

Test Plan

Executes make check and passes all tests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeperatingDiskBlockPosClass
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3083
Build 4253: Bitcoin ABC Buildbot (legacy)
Build 4252: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 14 2018, 20:27
Owners added a reviewer: Restricted Owners Package.Aug 14 2018, 20:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2018, 20:27
teamcity added a subscriber: teamcity.Aug 14 2018, 20:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito mentioned this in D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..Aug 14 2018, 20:50
teamcity added a comment.Aug 14 2018, 21:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3083: Diff 4590.Aug 14 2018, 21:09
jasonbcox accepted this revision as: jasonbcox.Aug 14 2018, 21:18
deadalnix requested changes to this revision.Aug 15 2018, 19:00

This will break gitian build unless the new header is specified in Makefile.am .

This revision now requires changes to proceed.Aug 15 2018, 19:00
nakihito updated this revision to Diff 4598.Aug 19 2018, 22:29

Added diskblockpos.h to src/Makefile.am.

teamcity added a comment.Aug 19 2018, 22:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 19 2018, 23:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3089: Diff 4598.Aug 19 2018, 23:08
deadalnix requested changes to this revision.Aug 21 2018, 13:11
deadalnix added inline comments.
src/validation.h
19 ↗(On Diff #4598)

CDiskBlockPos is only used by pointer or ref, please use a forward declaration instead of an include.

This revision now requires changes to proceed.Aug 21 2018, 13:11
nakihito updated this revision to Diff 4711.Aug 28 2018, 01:52

Removed unnecessary include statement in src/validation.h for CDiskBlockPos and replaced it with forward declaration.

teamcity added a comment.Aug 28 2018, 01:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 28 2018, 02:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3166: Diff 4711.Aug 28 2018, 02:30
nakihito added inline comments.Aug 28 2018, 03:00
src/validation.h
19 ↗(On Diff #4598)

Ah, you are correct. Consider it fixed.

deadalnix accepted this revision.Sep 3 2018, 11:52
This revision is now accepted and ready to land.Sep 3 2018, 11:52
Closed by commit rABC1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and . (authored by nakihito). · Explain WhySep 4 2018, 05:34
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in rABCb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and….Sep 4 2018, 05:43
nakihito mentioned this in rSTAGINGb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and….Sep 27 2018, 19:00
markblundeberg mentioned this in D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..Jul 7 2019, 22:31
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCc2a03e1e9547: [3 of 5] Move CDiskBlockPos from chain to flatfile..Jul 19 2019, 15:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGc2a03e1e9547: [3 of 5] Move CDiskBlockPos from chain to flatfile..Sep 19 2019, 01:20

Revision Contents
Changeset List

PathSize
src/
39 lines
51 lines
1 line
test/
1 line
3 lines
3 lines

Diff 4590

View Options

src/chain.h

Loading...
View Options

src/diskblockpos.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/test/blockindex_tests.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/validation.h

Loading...