Paths

Table of Contentst

Differential D1667

Make function manipulating DisconnectedBlockTransactions member functions
ClosedPublic
Actions

Authored by deadalnix on Aug 23 2018, 21:46.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6227fb8fcd31: Make function manipulating DisconnectedBlockTransactions member functions
rABC6227fb8fcd31: Make function manipulating DisconnectedBlockTransactions member functions

Summary

This ensures that the innards can be kept private.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 23 2018, 21:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 23 2018, 21:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3105: Diff 4622.Aug 23 2018, 22:24

jasonbcox requested changes to this revision.Aug 23 2018, 23:19

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/txmempool.cpp
1269 ↗	(On Diff #4622)	Seems like this belongs in the header?
src/txmempool.h
840 ↗	(On Diff #4622)	Should make `private:` explicit above this line
874 ↗	(On Diff #4622)	whil -> while
src/validation.cpp
597 ↗	(On Diff #4622)	This keeps getting linted for everyone touching this file. I say leave it in at this point.

This revision now requires changes to proceed.Aug 23 2018, 23:19

deadalnix added inline comments.Aug 23 2018, 23:22

src/txmempool.cpp
1269 ↗	(On Diff #4622)	Why ?

Fix typo, make private explicit.

deadalnix mentioned this in D1668: Make sure we do not drop transactions during reorg when the don't come in topological order..Aug 23 2018, 23:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Aug 23 2018, 23:34

jasonbcox added inline comments.

src/txmempool.cpp
1269 ↗	(On Diff #4622)	I guess that's just a standard practice to have constants in headers. It makes them easier to find. It's technically correct either way.

This revision is now accepted and ready to land.Aug 23 2018, 23:34

deadalnix added inline comments.Aug 23 2018, 23:36

src/txmempool.cpp
1269 ↗	(On Diff #4622)	Except that if I change the value of the contant, I don't have to recompile half of the world.

Closed by commit rABC6227fb8fcd31: Make function manipulating DisconnectedBlockTransactions member functions (authored by deadalnix). · Explain WhyAug 23 2018, 23:36

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3108: Diff 4625.Aug 24 2018, 00:02

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30

nakihito mentioned this in D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.Sep 10 2019, 01:14

majcosta mentioned this in D6539: [backport#14193] validation: Add missing mempool locks.Jul 7 2020, 00:34

PiRK mentioned this in D8977: [validation] Move validation-only consts to validation.cpp.Jan 20 2021, 10:15

PiRK mentioned this in rABC6b3bb60ac35c: [validation] Move validation-only consts to validation.cpp.Jan 20 2021, 14:48

PiRK mentioned this in D9780: Pass mempool reference to chainstate constructor.Jul 13 2021, 20:44

PiRK mentioned this in rABC0158b5aeebf6: Pass mempool reference to chainstate constructor.Jul 15 2021, 09:47

Fabien mentioned this in D12231: refactor: move UpdateTip into CChainState.Oct 12 2022, 19:32

Fabien mentioned this in rABC5478daeb41c9: refactor: move UpdateTip into CChainState.Oct 13 2022, 08:27

PiRK mentioned this in D12235: [validation] Add CChainStateManager::ProcessTransaction() and use it outside validation.Oct 13 2022, 08:50

PiRK mentioned this in rABC924ee9eb564a: [validation] Add CChainStateManager::ProcessTransaction() and use it outside….Oct 13 2022, 16:22

PiRK mentioned this in D12448: move check_final_and_mature lambda from CTxMemPool::removeForReorg to DisconnectedBlockTransactions::updateMempoolForReorg.Nov 9 2022, 16:58

PiRK mentioned this in rABCd470c5fe0590: move check_final_and_mature lambda from CTxMemPool::removeForReorg to….Nov 10 2022, 15:06

Revision Contents
Changeset List

Path

Size

src/

54 lines

76 lines

3 lines

109 lines

Diff 4627

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...