Page MenuHomePhabricator
Differential D16706

[electrum] hard fail if libsecp256k1 is not found/usable
AbandonedPublic
Actions

Authored by PiRK on Sep 3 2024, 10:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

This is a partial backport of electrum#5947
https://github.com/spesmilo/electrum/pull/5947/commits/1d72585b7d660e35502fabf4853ab307b7e75a5b

Depends on D16705

Test Plan

python test_runner.py

Delete ther shared lib file and check that it fails

Diff Detail

Event Timeline

PiRK created this revision.Sep 3 2024, 10:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2024, 10:40
teamcity edited the summary of this revision. (Show Details)Sep 3 2024, 10:40
Harbormaster completed remote builds in B30160: Diff 49457.Sep 3 2024, 10:42
PiRK added a child revision: D16707: [electrum] remove ecdsa as a direct dependency.Sep 3 2024, 10:44
PiRK published this revision for review.Sep 3 2024, 10:47
Fabien requested changes to this revision.Sep 4 2024, 08:42
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/secp256k1.py
75

See comment from the other diff and improve the message to point the user to the right doc for installing the correct version

This revision now requires changes to proceed.Sep 4 2024, 08:42
PiRK mentioned this in D16707: [electrum] remove ecdsa as a direct dependency.Sep 4 2024, 10:04
PiRK abandoned this revision.Sep 4 2024, 10:05
PiRK removed a child revision: D16707: [electrum] remove ecdsa as a direct dependency.Sep 4 2024, 10:09

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
24 lines

Diff 49457

View Options

electrum/electrumabc/secp256k1.py

Loading...