Page MenuHomePhabricator
Differential D2086

[qa] fix abc-p2p-fullblock test to support magnetic anomaly
ClosedPublic
Actions

Authored by jasonbcox on Nov 18 2018, 09:26.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf0afbcc15f09: [qa] fix abc-p2p-fullblock test to support magnetic anomaly
rABCf0afbcc15f09: [qa] fix abc-p2p-fullblock test to support magnetic anomaly
Summary

Fix failures due to >100 byte tx size requirement, and CTOR.

Test Plan
./test/functional/test_runner.py abc-p2p-fullblocktest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abc-full
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3958
Build 5988: Bitcoin ABC Buildbot (legacy)
Build 5987: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 18 2018, 09:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2018, 09:26
teamcity added a subscriber: teamcity.Nov 18 2018, 09:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 18 2018, 09:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3952: Diff 5881!Nov 18 2018, 09:33
Fabien edited the summary of this revision. (Show Details)Nov 18 2018, 10:16
Fabien added a parent revision: D2085: [qa] fix p2p-fullblocktest.py to support magnetic anomaly.
Fabien requested changes to this revision.Nov 18 2018, 10:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc-p2p-fullblocktest.py
254 ↗(On Diff #5881)

Please remove

This revision now requires changes to proceed.Nov 18 2018, 10:26
schancel added a child revision: D2079: [qa] fix transaction ordering and padding in abc-p2p-compactblocks.py.Nov 18 2018, 10:38
deadalnix added a subscriber: deadalnix.Nov 18 2018, 15:49
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest.py
164 ↗(On Diff #5881)

If you need a comment, it means that the function name is not very clear.

make_conform_to_ctor(block)
jasonbcox commandeered this revision.Nov 18 2018, 17:20
jasonbcox added a reviewer: schancel.
jasonbcox updated this revision to Diff 5888.Nov 18 2018, 17:20

According to feedback

teamcity added a comment.Nov 18 2018, 17:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Nov 18 2018, 17:27
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest.py
164

Put it just before the merkle root hash computation.

teamcity added a comment.Nov 18 2018, 17:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3958: Diff 5888!Nov 18 2018, 17:28
jasonbcox updated this revision to Diff 5889.Nov 18 2018, 17:35

Feedback + make_conform_to_ctor from D2085

jasonbcox edited the summary of this revision. (Show Details)Nov 18 2018, 17:35
jasonbcox marked 2 inline comments as done.
jasonbcox removed a reviewer: Fabien.
This revision is now accepted and ready to land.Nov 18 2018, 17:36
deadalnix accepted this revision.Nov 18 2018, 17:37
teamcity added a comment.Nov 18 2018, 17:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox removed a parent revision: D2085: [qa] fix p2p-fullblocktest.py to support magnetic anomaly.Nov 18 2018, 17:39
Closed by commit rABCf0afbcc15f09: [qa] fix abc-p2p-fullblock test to support magnetic anomaly (authored by jasonbcox). · Explain WhyNov 18 2018, 17:40
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Nov 18 2018, 17:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3959: Diff 5889!Nov 18 2018, 17:44
markblundeberg mentioned this in D3094: [qa] don't pad transactions during make_conform_to_ctor.May 22 2019, 23:02
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCa335fc174906: [qa] don't pad transactions during make_conform_to_ctor.May 24 2019, 16:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGa335fc174906: [qa] don't pad transactions during make_conform_to_ctor.Sep 18 2019, 23:44

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines

Diff 5888

View Options

test/functional/abc-p2p-fullblocktest.py

Loading...