Replace boost::adapter::reversed with custom reverse_iterator
ClosedPublic
Actions

Authored by Fabien on Dec 21 2018, 11:35.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING70d7755570d6: Replace boost::adapter::reversed with custom reverse_iterator
rABC70d7755570d6: Replace boost::adapter::reversed with custom reverse_iterator

Summary

This removes the dependency to boost.
Based on core PR10193

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10193

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4339
Build 6743: Bitcoin ABC Buildbot (legacy)
Build 6742: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2018, 11:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 11:35

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4337: Diff 6382.Dec 21 2018, 11:46

deadalnix requested changes to this revision.Dec 21 2018, 11:47

deadalnix added inline comments.

src/rwcollection.h
41 ↗	(On Diff #6382)	Use ->

This revision now requires changes to proceed.Dec 21 2018, 11:47

Fabien mentioned this in D2207: Declare single-argument (non-converting) constructors "explicit".Dec 21 2018, 11:49

Fabien added a child revision: D2207: Declare single-argument (non-converting) constructors "explicit".Dec 21 2018, 11:49

Replace (*a).b with a->b

deadalnix accepted this revision.Dec 21 2018, 11:57

This revision is now accepted and ready to land.Dec 21 2018, 11:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4339: Diff 6384.Dec 21 2018, 12:06

Closed by commit rABC70d7755570d6: Replace boost::adapter::reversed with custom reverse_iterator (authored by Jorge Timón <jtimon@jtimon.cc>, committed by Fabien). · Explain WhyDec 21 2018, 12:08

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

1 line

1 line

5 lines

6 lines

8 lines

29 lines

8 lines

test/

prevector_tests.cpp

8 lines

rwcollection_tests.cpp

6 lines

transaction_tests.cpp

1 line

txmempool.cpp

17 lines

validation.cpp

5 lines

Diff 6384

View Options

src/.clang-format

View Options

src/Makefile.am

View Options

src/avalanche.cpp

View Options

src/checkpoints.cpp

View Options

src/net_processing.cpp

View Options

src/reverse_iterator.h

View Options

src/rwcollection.h

View Options

src/test/prevector_tests.cpp

View Options

src/test/rwcollection_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/txmempool.cpp

View Options

Replace boost::adapter::reversed with custom reverse_iteratorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6384

src/.clang-format

src/Makefile.am

src/avalanche.cpp

src/checkpoints.cpp

src/net_processing.cpp

src/reverse_iterator.h

src/rwcollection.h

src/test/prevector_tests.cpp

src/test/rwcollection_tests.cpp

src/test/transaction_tests.cpp

src/txmempool.cpp

src/validation.cpp

Replace boost::adapter::reversed with custom reverse_iterator
ClosedPublic
Actions

Revision Contents
Changeset List