Page MenuHomePhabricator
Differential D2226

[net] Ignore getheaders requests for very old side blocks
ClosedPublic
Actions

Authored by Fabien on Dec 27 2018, 21:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING50c212c17581: [net] Ignore getheaders requests for very old side blocks
rABC50c212c17581: [net] Ignore getheaders requests for very old side blocks
Summary

Sending a getheaders message with an empty locator and a stop hash
is a request for a single header by hash. The node will respond with
headers for blocks not in the main chain as well as those in the main
chain. To avoid fingerprinting, the node should, however, ignore
requests for headers on side branches that are too old.

Backport of core PR11113

Test Plan
./test/functional/test_runner.py p2p-fingerprint

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11113
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4366
Build 6797: Bitcoin ABC Buildbot (legacy)
Build 6796: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 27 2018, 21:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 27 2018, 21:56
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 27 2018, 21:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 27 2018, 22:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4366: Diff 6426.Dec 27 2018, 22:07
Fabien added a child revision: D2227: Do not send (potentially) invalid headers in response to getheaders.Dec 27 2018, 22:27
deadalnix accepted this revision.Dec 30 2018, 12:30
This revision is now accepted and ready to land.Dec 30 2018, 12:30
Fabien planned changes to this revision.Dec 30 2018, 13:56

Needs an entry in the timings.json file

Fabien updated this revision to Diff 6505.Jan 4 2019, 18:46

Update timings.json

This revision is now accepted and ready to land.Jan 4 2019, 18:46
Fabien requested review of this revision.Jan 4 2019, 18:47
teamcity added a comment.Jan 4 2019, 18:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 4 2019, 18:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4412: Diff 6505.Jan 4 2019, 18:57
deadalnix accepted this revision.Jan 6 2019, 02:27

This is still good.

This revision is now accepted and ready to land.Jan 6 2019, 02:27
Closed by commit rABC50c212c17581: [net] Ignore getheaders requests for very old side blocks (authored by jimpo, committed by Fabien). · Explain WhyJan 6 2019, 10:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
54 lines
test/
functional/
166 lines
test_framework/
4 lines

Diff 6426

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/p2p-fingerprint.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...