Paths

Table of Contentst

[tests] Add network_thread_ functions and use them in tests
ClosedPublic
Actions

Authored by Fabien on Jan 22 2019, 14:36.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING7207f37655b0: [tests] Add network_thread_ functions and use them in tests
rABC7207f37655b0: [tests] Add network_thread_ functions and use them in tests

Summary

Add network thread_start(), network_thread_running() and
network_thread_join() utility functions in mininode.py

Update the tests to use them.

Partial backport of core PR11849
commits 5fc6e71 and 74e64f2

Depends on D2370

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11849_part1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4637
Build 7337: Bitcoin ABC Buildbot (legacy)
Build 7336: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 22 2019, 14:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2019, 14:36

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2384: [tests] Fix network threading in functional tests.Jan 22 2019, 14:42

Harbormaster failed remote builds in B4637: Diff 6813!Jan 22 2019, 14:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4637: Diff 6813.Jan 22 2019, 15:01

jasonbcox accepted this revision.Jan 22 2019, 18:16

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/abc-checkdatasig-activation.py
64	Why does this work without the `from test_framework.mininode import network_thread_start`? Is it implicitly imported via script or blocktools or something?

This revision is now accepted and ready to land.Jan 22 2019, 18:16

Fabien added inline comments.Jan 22 2019, 18:39

test/functional/abc-checkdatasig-activation.py
64	It is imported via comptool which imports mininode *

Closed by commit rABC7207f37655b0: [tests] Add network_thread_ functions and use them in tests (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 18:41

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D2479: Add activation code for SEGWIT_RECOVERY.Feb 1 2019, 23:34

Fabien added a commit: rSTAGING7207f37655b0: [tests] Add network_thread_ functions and use them in tests.Sep 18 2019, 22:01

Revision Contents
Changeset List

Path

Size

doc/

functional-tests.md

2 lines

test/

functional/

abc-checkdatasig-activation.py

3 lines

abc-magnetic-anomaly-activation.py

3 lines

abc-mempool-accept-txn.py

3 lines

abc-p2p-compactblocks.py

3 lines

abc-p2p-fullblocktest.py

3 lines

abc-replay-protection.py

3 lines

abc-sync-chain.py

4 lines

abc-transaction-ordering.py

3 lines

6 lines

3 lines

5 lines

3 lines

4 lines

invalidblockrequest.py

3 lines

invalidtxrequest.py

2 lines

maxuploadtarget.py

6 lines

node_network_limited.py

4 lines

4 lines

5 lines

3 lines

2 lines

4 lines

4 lines

2 lines

2 lines

2 lines

3 lines

test_framework/

mininode.py

30 lines

Diff 6813

View Options

doc/functional-tests.md

View Options

test/functional/abc-checkdatasig-activation.py

View Options

test/functional/abc-magnetic-anomaly-activation.py

View Options

test/functional/abc-mempool-accept-txn.py

View Options

test/functional/abc-p2p-compactblocks.py

View Options

test/functional/abc-p2p-fullblocktest.py

View Options

test/functional/abc-replay-protection.py

View Options

test/functional/abc-sync-chain.py

View Options

test/functional/abc-transaction-ordering.py

View Options

test/functional/assumevalid.py

View Options

test/functional/bip65-cltv-p2p.py

View Options

test/functional/bip68-112-113-p2p.py

View Options

test/functional/bipdersig-p2p.py

View Options

test/functional/example_test.py

View Options

test/functional/invalidblockrequest.py

View Options

test/functional/invalidtxrequest.py

View Options

test/functional/maxuploadtarget.py

View Options

test/functional/node_network_limited.py

View Options

test/functional/nulldummy.py

View Options

test/functional/p2p-acceptblock.py

View Options

test/functional/p2p-compactblocks.py

View Options

test/functional/p2p-feefilter.py

View Options

test/functional/p2p-fingerprint.py

View Options

test/functional/p2p-fullblocktest.py

View Options

test/functional/p2p-leaktests.py

View Options

test/functional/p2p-mempool.py

View Options

test/functional/p2p-timeouts.py

View Options

test/functional/sendheaders.py

View Options

test/functional/test_framework/mininode.py

[tests] Add network_thread_ functions and use them in testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6813

doc/functional-tests.md

test/functional/abc-checkdatasig-activation.py

test/functional/abc-magnetic-anomaly-activation.py

test/functional/abc-mempool-accept-txn.py

test/functional/abc-p2p-compactblocks.py

test/functional/abc-p2p-fullblocktest.py

test/functional/abc-replay-protection.py

test/functional/abc-sync-chain.py

test/functional/abc-transaction-ordering.py

test/functional/assumevalid.py

test/functional/bip65-cltv-p2p.py

test/functional/bip68-112-113-p2p.py

test/functional/bipdersig-p2p.py

test/functional/example_test.py

test/functional/invalidblockrequest.py

test/functional/invalidtxrequest.py

test/functional/maxuploadtarget.py

test/functional/node_network_limited.py

test/functional/nulldummy.py

test/functional/p2p-acceptblock.py

test/functional/p2p-compactblocks.py

test/functional/p2p-feefilter.py

test/functional/p2p-fingerprint.py

test/functional/p2p-fullblocktest.py

test/functional/p2p-leaktests.py

test/functional/p2p-mempool.py

test/functional/p2p-timeouts.py

test/functional/sendheaders.py

test/functional/test_framework/mininode.py

[tests] Add network_thread_ functions and use them in tests
ClosedPublic
Actions

Revision Contents
Changeset List