Page MenuHomePhabricator
Differential D2384

[tests] Fix network threading in functional tests
ClosedPublic
Actions

Authored by Fabien on Jan 22 2019, 14:42.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc983a34d24cf: [tests] Fix network threading in functional tests
rABCc983a34d24cf: [tests] Fix network threading in functional tests
Summary

assumevalid.py, example_test.py, p2p-acceptblocks.py and
abc-p2p-compactblocks add p2p_connections after the
NetworkThread has been started. This isn't permitted.
Fix test to restart the network thread when adding new connections.

Add assertions to ensure new tests won't fail into this issue.

p2p-leaktest.py had a potential race condition if the NetworkThread
hadn't terminated by the time we tried to restart it.

Partial backport of core PR11849
commits 5c8ff26 and 34e08b3

Depends on D2383

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11849_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4638
Build 7339: Bitcoin ABC Buildbot (legacy)
Build 7338: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 22 2019, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2019, 14:42
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 22 2019, 14:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D2364: [tests] Rename feature_* functional tests..Jan 22 2019, 14:47
Fabien added a child revision: D2364: [tests] Rename feature_* functional tests..Jan 22 2019, 14:47
Harbormaster completed remote builds in B4638: Diff 6814.Jan 22 2019, 14:51
teamcity added a comment.Jan 22 2019, 14:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jan 22 2019, 18:25
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/test_framework/mininode.py
480

Pretty sure this change is already in the previous diff. That shouldn't affect your merging, so this should be ok.

This revision is now accepted and ready to land.Jan 22 2019, 18:25
Closed by commit rABCc983a34d24cf: [tests] Fix network threading in functional tests (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 18:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGc983a34d24cf: [tests] Fix network threading in functional tests.Sep 18 2019, 22:01

Revision Contents
Changeset List

PathSize
test/
functional/
31 lines
20 lines
10 lines
6 lines
3 lines
test_framework/
13 lines

Diff 6814

View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/assumevalid.py

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/p2p-acceptblock.py

Loading...
View Options

test/functional/p2p-leaktests.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...