Page MenuHomePhabricator

Make sure we have one txdata object per tx we validate. That's required for parallel signature checking.
ClosedPublic

Authored by deadalnix on Jun 28 2017, 16:14.

Details

Summary

In case of parallel validation, we need to make sure we have one txdata object per transaction being validated, or they may end up stepping on each other's toes.

Test Plan
make check

Enable parallel validation. invalidate block 000000000002f96388721eefe2f3246577636902a7d2c9034ffc9731b1a154cf and then reconsider it. it is accepted. Run the manipulation several times to make sure.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parval
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 438
Build 438: arc lint + arc unit

Event Timeline

Remove debugging leftovers

Accepted - this is a revert of 05fdbe78b and back to existing Core code .

src/validation.cpp
2404 ↗(On Diff #707)

Suggest to remove once validated, or if want to retain this LogPrint, give it a more descriptive message, e.g. "invalid state: "

This revision is now accepted and ready to land.Jun 28 2017, 17:04
This revision was automatically updated to reflect the committed changes.