Page MenuHomePhabricator
Differential D2618

[wallet] Construct CWalletTx objects in CommitTransaction
ClosedPublic
Actions

Authored by Fabien on Feb 27 2019, 11:45.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING80cfe7eac199: [wallet] Construct CWalletTx objects in CommitTransaction
rABC80cfe7eac199: [wallet] Construct CWalletTx objects in CommitTransaction
Summary

Construct CWalletTx objects in CWallet::CommitTransaction, instead of
having callers do it. This ensures CWalletTx objects are constructed in
a uniform way and all fields are set.

This also makes it possible to avoid confusing and wasteful CWalletTx
copies in https://github.com/bitcoin/bitcoin/pull/9381

There is no change in behavior.

Partial backport of core PR9680 (commit a128bdc)
Depends on D2611

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9680_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5092
Build 8247: Bitcoin ABC Buildbot (legacy)
Build 8246: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 27 2019, 11:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2019, 11:45
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 27 2019, 11:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2619: [wallet] Get rid of CWalletTx default constructor.Feb 27 2019, 11:47
teamcity added a comment.Feb 27 2019, 12:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5092: Diff 7506.Feb 27 2019, 12:00
jasonbcox accepted this revision.Feb 27 2019, 16:22
This revision is now accepted and ready to land.Feb 27 2019, 16:22
Closed by commit rABC80cfe7eac199: [wallet] Construct CWalletTx objects in CommitTransaction (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyMar 11 2019, 18:14
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D2794: Merge #10368: [wallet] Remove helper conversion operator from wallet.Apr 10 2019, 19:18
jasonbcox mentioned this in rABC7646a2c69b99: Merge #10368: [wallet] Remove helper conversion operator from wallet.Apr 10 2019, 22:48
Fabien added a commit: rSTAGING80cfe7eac199: [wallet] Construct CWalletTx objects in CommitTransaction.Sep 18 2019, 22:41
jasonbcox mentioned this in rSTAGING7646a2c69b99: Merge #10368: [wallet] Remove helper conversion operator from wallet.Sep 18 2019, 22:57

Revision Contents
Changeset List

PathSize
src/
qt/
20 lines
5 lines
14 lines
wallet/
56 lines
test/
11 lines
9 lines
43 lines

Diff 7506

View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/qt/walletmodeltransaction.h

Loading...
View Options

src/qt/walletmodeltransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...