Page MenuHomePhabricator
Differential D2814

Remove direct bitcoin calls from qt/optionsmodel.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 17 2019, 16:23.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp
rABCabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/c0f2756be517feddacd7c6b89b9faa888b3fef8e
Progress towards T417
Depends on D2813

Test Plan
make check
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10244-c2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5484
Build 9030: Bitcoin ABC Buildbot (legacy)
Build 9029: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 16:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 16:23
teamcity added a comment.Apr 17 2019, 16:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Apr 17 2019, 16:25
jasonbcox added a parent revision: D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.
teamcity added a comment.Apr 17 2019, 16:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5482: Diff 8097.Apr 17 2019, 16:38
jasonbcox updated this revision to Diff 8099.Apr 17 2019, 16:49
jasonbcox added a child revision: D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.

Fixed forward declaration order

teamcity added a comment.Apr 17 2019, 16:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Apr 17 2019, 16:53
deadalnix added inline comments.
src/interface/node.cpp
12 ↗(On Diff #8097)

This seems to be redundant because it was added in the .h already.

This revision is now accepted and ready to land.Apr 17 2019, 16:53
teamcity added a comment.Apr 17 2019, 17:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5484: Diff 8099.Apr 17 2019, 17:05
Closed by commit rABCabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 17 2019, 19:00
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp.Sep 18 2019, 23:00

Revision Contents
Changeset List

PathSize
src/
interface/
16 lines
21 lines
qt/
2 lines
8 lines
37 lines
test/
4 lines
4 lines

Diff 8099

View Options

src/interface/node.h

Loading...
View Options

src/interface/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/optionsmodel.h

Loading...
View Options

src/qt/optionsmodel.cpp

Loading...
View Options

src/qt/test/paymentservertests.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...