Paths

Table of Contentst

Differential D2826

Move interface -> interfaces
ClosedPublic
Actions

Authored by jasonbcox on Apr 18 2019, 16:48.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGfb9cfdfcfbf3: Move interface -> interfaces
rABCfb9cfdfcfbf3: Move interface -> interfaces

Summary

Core PR 12906 ( https://github.com/bitcoin/bitcoin/pull/12906/files ) renames these files.
Rather than applying this large refactor patch after the completion of T417, I'm applying part of it now
and will be applying the rest of it in-place for the remaining T417 diffs.

Test Plan

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

interfaces

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5503
Build 9068: Bitcoin ABC Buildbot (legacy)
Build 9067: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 18 2019, 16:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2019, 16:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5502: Diff 8121.Apr 18 2019, 17:03

jasonbcox planned changes to this revision.Apr 18 2019, 17:48

Renaming the namespaces which should have been included the first time around

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.Apr 18 2019, 18:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5503: Diff 8122.Apr 18 2019, 18:28

Fabien requested changes to this revision.Apr 19 2019, 08:05

Fabien added inline comments.

src/interfaces/handler.h
5	`BITCOIN_INTERFACE_HANDLER_H` => `BITCOIN_INTERFACES_HANDLER_H`
6	dito
34	dito

This revision now requires changes to proceed.Apr 19 2019, 08:05

deadalnix accepted this revision.Apr 19 2019, 12:08

Rebase + update header guards

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5525: Diff 8151.Apr 19 2019, 16:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Apr 19 2019, 18:19

This revision is now accepted and ready to land.Apr 19 2019, 18:19

Closed by commit rABCfb9cfdfcfbf3: Move interface -> interfaces (authored by jasonbcox). · Explain WhyApr 19 2019, 19:44

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGfb9cfdfcfbf3: Move interface -> interfaces.Sep 18 2019, 23:02

Revision Contents
Changeset List

Path

Size

src/

4 lines

8 lines

interface/

	interfaces/
	interface/

4 lines

6 lines

4 lines

8 lines

qt/

20 lines

10 lines

6 lines

6 lines

optionsmodel.cpp

4 lines

test/

paymentservertests.cpp

4 lines

wallettests.cpp

4 lines

Diff 8122

src/CMakeLists.txt

Loading...

src/Makefile.am

Loading...

src/interface/handler.h

Loading...

src/interface/handler.cpp

Loading...

src/interface/node.h

Loading...

src/interface/node.cpp

Loading...

src/interfaces/handler.h

Loading...

src/interfaces/handler.cpp

Loading...

src/interfaces/node.h

Loading...

src/interfaces/node.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/bitcoingui.h

Loading...

src/qt/bitcoingui.cpp

Loading...

src/qt/optionsmodel.h

Loading...

src/qt/optionsmodel.cpp

Loading...

src/qt/test/paymentservertests.cpp

Loading...

src/qt/test/wallettests.cpp

Loading...