Page MenuHomePhabricator
Differential D2819

Remove direct bitcoin calls from qt/intro.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 17 2019, 18:54.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp
rABC23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/d7c2c9594897c39df6739b92610dfb5a7a1cb3ec
Progress towards T417
Depends on D2818

Test Plan

make check
ninja
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c7b
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5534
Build 9130: Bitcoin ABC Buildbot (legacy)
Build 9129: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 18:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 18:54
teamcity added a comment.Apr 17 2019, 18:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 17 2019, 19:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5490: Diff 8105.Apr 17 2019, 19:09
jasonbcox added a child revision: D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.Apr 17 2019, 23:10
deadalnix accepted this revision.Apr 17 2019, 23:14
This revision is now accepted and ready to land.Apr 17 2019, 23:14
jasonbcox updated this revision to Diff 8175.Apr 19 2019, 22:27

Rebase

teamcity added a comment.Apr 19 2019, 22:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 19 2019, 22:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5534: Diff 8175.Apr 19 2019, 22:41
Closed by commit rABC23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 23 2019, 22:01
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp.Sep 18 2019, 23:07

Revision Contents
Changeset List

PathSize
src/
interfaces/
6 lines
qt/
2 lines
6 lines
7 lines

Diff 8175

View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/intro.h

Loading...
View Options

src/qt/intro.cpp

Loading...