Page MenuHomePhabricator
Differential D3243

Calculate and store the number of bytes required to spend an input
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2019, 23:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc9cc9f22f14d: Calculate and store the number of bytes required to spend an input
rABCc9cc9f22f14d: Calculate and store the number of bytes required to spend an input
Summary

This is extracted from Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/12ec29d3bb0d46c61712210fe9bb96a0d543204a

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
computebyteinput
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6284
Build 10615: Bitcoin ABC Buildbot (legacy)
Build 10614: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 6 2019, 23:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 23:34
teamcity added a comment.Jun 6 2019, 23:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 6 2019, 23:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6197: Diff 9224.Jun 6 2019, 23:48
Fabien requested changes to this revision.Jun 7 2019, 09:46
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
1632 ↗(On Diff #9224)

Nit: the else is useless

src/wallet/wallet.h
1073 ↗(On Diff #9224)

Remove

This revision now requires changes to proceed.Jun 7 2019, 09:46
deadalnix added a child revision: D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.Jun 12 2019, 12:50
deadalnix updated this revision to Diff 9355.Jun 12 2019, 14:07

Address comments

teamcity added a comment.Jun 12 2019, 14:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 9356.Jun 12 2019, 14:10

rebase

teamcity added a comment.Jun 12 2019, 14:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 12 2019, 14:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6284: Diff 9355.Jun 12 2019, 14:14
Harbormaster completed remote builds in B6285: Diff 9356.Jun 12 2019, 14:19
teamcity added a comment.Jun 12 2019, 14:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Jun 13 2019, 07:59
This revision is now accepted and ready to land.Jun 13 2019, 07:59
Closed by commit rABCc9cc9f22f14d: Calculate and store the number of bytes required to spend an input (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 13 2019, 12:54
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc9cc9f22f14d: Calculate and store the number of bytes required to spend an input.
nakihito mentioned this in D3893: Merge #12747: Fix typos.Aug 23 2019, 20:28
deadalnix added a commit: rSTAGINGc9cc9f22f14d: Calculate and store the number of bytes required to spend an input.Sep 19 2019, 00:16
markblundeberg mentioned this in D4895: fix inappropriate uses of virtual size.Jan 11 2020, 09:20
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC1196ec83ae81: fix inappropriate uses of virtual size.Jan 12 2020, 02:43
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING1196ec83ae81: fix inappropriate uses of virtual size.Apr 7 2020, 22:22

Revision Contents
Changeset List

PathSize
src/
policy/
7 lines
7 lines
script/
1 line
6 lines
wallet/
67 lines
85 lines

Diff 9355

View Options

src/policy/policy.h

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...