Details

Reviewers

jasonbcox
Fabien
Mengerian
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGe11bd161cee6: De-witnessing some comments
rABCe11bd161cee6: De-witnessing some comments

Summary

Catches some comments that referenced segwit.

Test Plan

read

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D3114

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6406
Build 10859: Bitcoin ABC Buildbot (legacy)
Build 10858: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 25 2019, 18:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2019, 18:39

Herald added a reviewer: deadalnix. · View Herald Transcript

markblundeberg retitled this revision from Some de-witnessing to De-witnessing some comments and RPC helptext.May 25 2019, 18:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5986: Diff 8878.May 25 2019, 18:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

(Obviously if we ever introduce new tx format with scriptsig data redacted from txid calc, then we may have txid != hash. But that's a long long way off)

deadalnix requested changes to this revision.May 26 2019, 18:19

deadalnix added inline comments.

src/rpc/mining.cpp
389 ↗	(On Diff #8878)	We kept the distinction between txid and hash to make sure we can fix malleability. The fact it happen to be the same right now doesn't convey the semantic.
src/rpc/rawtransaction.cpp
108 ↗	(On Diff #8878)	dito
573 ↗	(On Diff #8878)	dito

This revision now requires changes to proceed.May 26 2019, 18:19

markblundeberg added inline comments.May 26 2019, 18:36

src/rpc/mining.cpp
389 ↗	(On Diff #8878)	Hmm what would you put then? The current text is no good as it mentions witness data.

rebase to check build

markblundeberg planned changes to this revision.Jun 4 2019, 15:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6136: Diff 9118.Jun 4 2019, 15:58

reduce scope (remove RPC changes, restore a comment)

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6406: Diff 9538.Jun 19 2019, 16:12

deadalnix accepted this revision.Jun 20 2019, 23:55

deadalnix added inline comments.

src/validation.cpp
1216	Just tx hash. When that's not the case, we refers it as txid. Even though both are effectively the same value at the moment, they don't have to be going forward.

This revision is now accepted and ready to land.Jun 20 2019, 23:55

tweak per comment

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6426: Diff 9564.Jun 21 2019, 15:34

Closed by commit rABCe11bd161cee6: De-witnessing some comments (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 21 2019, 15:36

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCe11bd161cee6: De-witnessing some comments.

markblundeberg mentioned this in D3402: fix linting bug in script.py.Jun 24 2019, 17:22

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC9d1601fa6210: fix linting bug in script.py.Jun 24 2019, 17:30

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe11bd161cee6: De-witnessing some comments.Sep 19 2019, 00:25

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING9d1601fa6210: fix linting bug in script.py.Sep 19 2019, 00:28