Page MenuHomePhabricator
Differential D3511

Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework
ClosedPublic
Actions

Authored by markblundeberg on Jul 2 2019, 01:15.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T669: Removing comparison test framework
Commits
rSTAGING6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework
rABC6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework
Summary

PR11772 backport https://github.com/bitcoin/bitcoin/pull/11772/files
e97b113b04 [tests] Change invalidblockrequest to use BitcoinTestFramework (John Newbery)
2b7064eda7 [tests] Fix flake8 warnings in invalidblockrequest (John Newbery)
54b8c580b7 [test] Fix nits leftover from 11771 (Conor Scott)

Pull request description:

Builds on #11771. Please review that PR first

Next step in #10603.

- first commit tidies up invalidblockrequest.py
- second commit removes usage of ComparisonTestFramework
Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6614
Build 11275: Bitcoin ABC Buildbot (legacy)
Build 11274: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 2 2019, 01:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 01:15
teamcity added a comment.Jul 2 2019, 01:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg planned changes to this revision.Jul 2 2019, 01:16

This is not complete, I am seeing some weird behaviour.

teamcity added a comment.Jul 2 2019, 01:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6612: Diff 9895.Jul 2 2019, 01:22
markblundeberg updated this revision to Diff 9898.Jul 2 2019, 03:58

fix

teamcity added a comment.Jul 2 2019, 03:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added inline comments.Jul 2 2019, 04:00
test/functional/p2p_invalid_block.py
116

Note this additional yield has been removed (where the correct block is sent)... Core doesn't have this and it's not needed.

markblundeberg added a task: T669: Removing comparison test framework.Jul 2 2019, 04:01
Harbormaster completed remote builds in B6614: Diff 9898.Jul 2 2019, 04:05
teamcity added a comment.Jul 2 2019, 04:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jul 3 2019, 13:46
This revision is now accepted and ready to land.Jul 3 2019, 13:46
markblundeberg updated this revision to Diff 9958.EditedJul 3 2019, 14:55

rebase (I rebase-conflicted myself with D3527, which (in the original PR) removes the "Verify valid transaction" test case added here... :facepalm:)

teamcity added a comment.Jul 3 2019, 14:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2019, 15:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6652: Diff 9958.Jul 3 2019, 15:01
markblundeberg mentioned this in D3527: Merge #13003: qa: Add test for orphan handling.Jul 3 2019, 15:03
Closed by commit rABC6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 3 2019, 15:15
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.Sep 19 2019, 00:54

Revision Contents
Changeset List

PathSize
test/
functional/
119 lines
6 lines

Diff 9898

View Options

test/functional/p2p_invalid_block.py

Loading...
View Options

test/functional/p2p_invalid_tx.py

Loading...