Fix multiwallet test to look for proper jsonrpc text. rebased to 8a4cecc
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 26 2018
Jan 26 2018
I will rebase it to current master.
Herald added a reviewer for D1038: fix multiwallet test to look for proper jsonrpc text: Restricted Project.
Remove replaced_by_txid from wallet code
matiu closed T112: Remove replaced_by_txid from wallet code as Resolved by committing rABCb2c0b89f6cf2: Remove replaced_by_txid from wallet code.
Jan 25 2018
Jan 25 2018
matiu resigned from D1035: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test..
I think this is already done at https://reviews.bitcoinabc.org/D1033 :(
matiu requested changes to D1033: [backport] [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
Added to minor comments.
ACK, I should have modified this. thanks.
Jan 24 2018
Jan 24 2018
matiu committed rABCd972add4a2d9: Remove CChainParams parameter from BlockAssembler (authored by matiu).
Remove CChainParams parameter from BlockAssembler
matiu closed T169: Remove CChainParams parameter from BlockAssembler as Resolved by committing rABCd972add4a2d9: Remove CChainParams parameter from BlockAssembler.
Herald added a reviewer for D1031: Remove CChainParams parameter from BlockAssembler: Restricted Project.
At D1028
matiu committed rABCe4f59d0d5393: Fix misleading "Method not found" multiwallet errors (authored by Russell Yanofsky <russ@yanofsky.org>).
Fix misleading "Method not found" multiwallet errors
matiu closed T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors, a subtask of T125: Backport Core PR10711: [tests] Introduce TestNode, as Resolved.
Jan 23 2018
Jan 23 2018
thanks, sorry about it.
fix commit
keep braces
update clang version
matiu committed rABC93410ea50399: optim: mark a few classes final (authored by Cory Fields <cory-nospam-@coryfields.com>).
optim: mark a few classes final
matiu closed T171: Backport core PR 10809: optim: mark a few classes final as Resolved by committing rABC93410ea50399: optim: mark a few classes final.
matiu closed T171: Backport core PR 10809: optim: mark a few classes final, a subtask of T126: Backports from Bitcoin Core, as Resolved.
matiu committed rABC6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock (authored by matiu).
Remove Consensus::Params parameter from ContextualCheckBlock
Herald added a reviewer for D1028: Remove Consensus::Params parameter from ContextualCheckBlock: Restricted Project.
ok, on it.
Herald added a reviewer for D1024: Fix misleading "Method not found" multiwallet errors: Restricted Project.
Checking ContextualCheckBlock at https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/validation.cpp;2c81a03ad212b73ca7002ef9f9f891a025c1f6bd$3523
It's taking me a little more than expected to install clang-format-4.0 on macos... will update this as soon as I finish.
Jan 22 2018
Jan 22 2018
This one seems applied to:
matiu closed T147: Backport Core PR 10169: [tests] remove func test code duplication, a subtask of T126: Backports from Bitcoin Core, as Resolved.
This is already present in master:
matiu closed T150: Backport Core PR10352: test: Add elapsed time to RPC tracing, a subtask of T126: Backports from Bitcoin Core, as Resolved.
matiu closed T141: Backport Core PR10017: combine_logs.py - aggregates log files from multiple bitcoinds during functional tests. as Resolved.
Fixed at D1013
matiu closed T146: Port over `disconnect_ban.py` test, a subtask of T126: Backports from Bitcoin Core, as Resolved.
This was done already :/ https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/disconnect_ban.py
matiu retitled D1014: WIP [Backport) adds disconnect_ban from [Backport) adds disconnect_ban to WIP [Backport) adds disconnect_ban.
matiu committed rABC0961aae47220: Introduce combine_logs.py to combine log files from multiple bitcoinds. (authored by John Newbery <john@johnnewbery.com>).
Introduce combine_logs.py to combine log files from multiple bitcoinds.
matiu updated the summary of D1013: Introduce combine_logs.py to combine log files from multiple bitcoinds..
Herald added a reviewer for D1013: Introduce combine_logs.py to combine log files from multiple bitcoinds.: Restricted Project.
Right now, a lot of developers understand how to use Github. For a variety of reasons, we have chosen to use Phabricator, and will remain on Phabricator for the time being.
add MacOs pidof compatibility
Add a line about reviewing a Diff
Jan 21 2018
Jan 21 2018
Tested ok.
matiu requested changes to D992: [tests] Update start/stop node functions to be private module functions.
matiu added a comment to D992: [tests] Update start/stop node functions to be private module functions.
OK, I see that some changes from
https://github.com/bitcoin/bitcoin/pull/10359/files
are already applied current master 9e9e088: like abandonconflict.py
https://github.com/bitcoin/bitcoin/pull/10359/files#diff-401ca62066f6793c4c39811aea5fdcc8R76
Jan 19 2018
Jan 19 2018
matiu committed rABCf42bb363128c: Make forknotify.py more robust (authored by John Newbery <john@johnnewbery.com>).
Make forknotify.py more robust