Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Mar 1 2018

matiu committed rSTAGINGe4f59d0d5393: Fix misleading "Method not found" multiwallet errors (authored by Russell Yanofsky <russ@yanofsky.org>).
Fix misleading "Method not found" multiwallet errors
Mar 1 2018, 23:45
matiu committed rSTAGINGff7c62fb6140: update clang version (authored by matiu).
update clang version
Mar 1 2018, 23:45
matiu committed rSTAGING93410ea50399: optim: mark a few classes final (authored by Cory Fields <cory-nospam-@coryfields.com>).
optim: mark a few classes final
Mar 1 2018, 23:44
matiu committed rSTAGING6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock (authored by matiu).
Remove Consensus::Params parameter from ContextualCheckBlock
Mar 1 2018, 23:44
matiu committed rSTAGING0961aae47220: Introduce combine_logs.py to combine log files from multiple bitcoinds. (authored by John Newbery <john@johnnewbery.com>).
Introduce combine_logs.py to combine log files from multiple bitcoinds.
Mar 1 2018, 23:44
matiu committed rSTAGING8f53e13ce900: add MacOs pidof compatibility (authored by matiu).
add MacOs pidof compatibility
Mar 1 2018, 23:43
matiu committed rSTAGING38002eccbfeb: Add a line about reviewing a Diff (authored by matiu).
Add a line about reviewing a Diff
Mar 1 2018, 23:43
matiu committed rSTAGINGf42bb363128c: Make forknotify.py more robust (authored by John Newbery <john@johnnewbery.com>).
Make forknotify.py more robust
Mar 1 2018, 23:42
matiu committed rSTAGING480e057fe351: Wait for connection to open in bip9-softforks.py (authored by John Newbery <john@johnnewbery.com>).
Wait for connection to open in bip9-softforks.py
Mar 1 2018, 23:42

Feb 27 2018

matiu accepted D1125: Fix bip68-sequence rpc test.
Feb 27 2018, 01:09
matiu accepted D1124: Reformat bip68-112-113-p2p.py and apply various nits.
Feb 27 2018, 00:49

Feb 23 2018

matiu added inline comments to D1074: Add Utxo Commitment wrapper around libsecp256k1.
Feb 23 2018, 19:46

Feb 21 2018

matiu added a comment to D1072: Add ECMH multiset module to libsecp256k1.

ACK: Code review, testing, and a lot of playing...

Feb 21 2018, 16:14

Feb 19 2018

matiu accepted D1114: Fix signed/unsigned warning.
Feb 19 2018, 18:56

Feb 16 2018

matiu added a comment to D1072: Add ECMH multiset module to libsecp256k1.

Here is the relevant discussion on Bitcoin Core, just for reference.
https://github.com/bitcoin-core/secp256k1/pull/477

Feb 16 2018, 14:31

Feb 15 2018

matiu added a comment to D1093: Adds OP_DIV functionality into interpreter.cpp.

Code ACK

Feb 15 2018, 18:49

Feb 8 2018

matiu closed T213: Build Bitcoin-ABC :: Master :: Bitcoin-ABC Master is broken. as Resolved.
Feb 8 2018, 03:22
matiu committed rABC349dd3488ac8: TestNode tidyups (authored by John Newbery <john@johnnewbery.com>).
TestNode tidyups
Feb 8 2018, 03:18
matiu closed D1066: TestNode tidyups.
Feb 8 2018, 03:17
matiu commandeered D1066: TestNode tidyups.
Feb 8 2018, 03:09
matiu committed rABC17d4ca0d2a31: qa: Move wait_until to util (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Move wait_until to util
Feb 8 2018, 03:08
matiu closed D1065: qa: Move wait_until to util.
Feb 8 2018, 03:08

Feb 7 2018

matiu commandeered D1065: qa: Move wait_until to util.
Feb 7 2018, 17:57

Feb 3 2018

matiu accepted D1056: Add safe flag to listunspent result.
Feb 3 2018, 00:25

Feb 2 2018

matiu closed T210: Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass as Resolved.
Feb 2 2018, 18:55
matiu closed T210: Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass, a subtask of T182: Backport Core PR11121: TestNode tidyups, as Resolved.
Feb 2 2018, 18:55
matiu added a subtask for T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls: T182: Backport Core PR11121: TestNode tidyups.
Feb 2 2018, 18:53
matiu added a parent task for T182: Backport Core PR11121: TestNode tidyups: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 2 2018, 18:53
matiu removed parent tasks for T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls: T177: Backport Core PR11743: qa: Add multiwallet prefix test, T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously, T180: Backport Core PR10798: [tests] [utils] test bitcoin-cli.
Feb 2 2018, 18:52
matiu removed a subtask for T180: Backport Core PR10798: [tests] [utils] test bitcoin-cli: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 2 2018, 18:52
matiu removed a subtask for T177: Backport Core PR11743: qa: Add multiwallet prefix test: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 2 2018, 18:52
matiu removed a subtask for T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 2 2018, 18:52
matiu placed T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls up for grabs.
Feb 2 2018, 18:42
matiu accepted D1060: test: Add resendwallettransactions functional tests.
Feb 2 2018, 17:35
matiu accepted D1058: [wallet] [refactor] Simplify getbalance implementation.
Feb 2 2018, 17:34
matiu accepted D1059: Fix resendwallettransactions assert failure if -walletbroadcast=0.
Feb 2 2018, 17:31
matiu accepted D1057: Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number..

ACK, walletencryption tests are failing, but does not seem related to this.

Feb 2 2018, 15:18
matiu added inline comments to D1056: Add safe flag to listunspent result.
Feb 2 2018, 14:39
matiu committed rABCbdb7e995560d: Add bitcoin-cli -stdin and -stdinrpcpass + tests (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
Add bitcoin-cli -stdin and -stdinrpcpass + tests
Feb 2 2018, 14:32
matiu closed D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Feb 2 2018, 14:31
matiu committed rABC23870542d3b4: qa: Add multiwallet prefix test (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Add multiwallet prefix test
Feb 2 2018, 12:03
matiu closed T177: Backport Core PR11743: qa: Add multiwallet prefix test, a subtask of T178: Backport Core PR12166: [docs] Clarify -walletdir usage, as Resolved.
Feb 2 2018, 12:03
matiu closed T177: Backport Core PR11743: qa: Add multiwallet prefix test as Resolved by committing rABC23870542d3b4: qa: Add multiwallet prefix test.
Feb 2 2018, 12:03
matiu closed D1055: qa: Add multiwallet prefix test.
Feb 2 2018, 12:03

Feb 1 2018

matiu added a comment to D1055: qa: Add multiwallet prefix test.

The failing test does seem to have anything to do with this PR.

Feb 1 2018, 21:00
matiu added a subtask for T220: Backport Core PR 11492: Fix leak in CDB constructor: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 1 2018, 20:12
matiu added a parent task for T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls: T220: Backport Core PR 11492: Fix leak in CDB constructor.
Feb 1 2018, 20:12
matiu created T220: Backport Core PR 11492: Fix leak in CDB constructor.
Feb 1 2018, 20:12
Herald added a reviewer for D1055: qa: Add multiwallet prefix test: Restricted Project.
Feb 1 2018, 19:51
matiu added a revision to T177: Backport Core PR11743: qa: Add multiwallet prefix test: D1055: qa: Add multiwallet prefix test.
Feb 1 2018, 19:51
matiu added a parent task for T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls: T177: Backport Core PR11743: qa: Add multiwallet prefix test.
Feb 1 2018, 19:46
matiu added a subtask for T177: Backport Core PR11743: qa: Add multiwallet prefix test: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 1 2018, 19:46
matiu renamed T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously from Avoid opening copied wallet databases simultaneously to Backport Core PR 11476: Avoid opening copied wallet databases simultaneously.
Feb 1 2018, 19:45
matiu closed T219: qa: Add multiwallet prefix test as Invalid.
Feb 1 2018, 19:44
matiu created T219: qa: Add multiwallet prefix test.
Feb 1 2018, 19:42
matiu added a subtask for T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously: T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Feb 1 2018, 19:39
matiu added a parent task for T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls: T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously.
Feb 1 2018, 19:39
matiu created T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously.
Feb 1 2018, 19:39
matiu requested review of D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Feb 1 2018, 01:44
matiu planned changes to D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Feb 1 2018, 01:44
matiu updated the diff for D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.

rebased

Feb 1 2018, 01:38

Jan 31 2018

matiu added a comment to D1054: Summary: make check will generate wallet.backup file on OSX, ignore it..

Hi @andychen , JIC, you need to land this changes. See https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/CONTRIBUTING.md#working-with-the-bitcoin-abc-repository

Jan 31 2018, 21:37
matiu accepted D1049: [wallet] Basic keypool topup.

ACK. Tested locally.

Jan 31 2018, 21:35
matiu accepted D1047: No longer ever reuse keypool indexes.
Jan 31 2018, 14:01
matiu accepted D1045: Batch flushing operations to the walletdb during top up and increase keypool size..

ACK, checked manually + against the original PR + run test locally.

Jan 31 2018, 13:49
matiu accepted D1054: Summary: make check will generate wallet.backup file on OSX, ignore it..
Jan 31 2018, 13:27
matiu updated the summary of D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Jan 31 2018, 00:44
matiu updated the diff for D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.

add PR10997 changes

Jan 31 2018, 00:42
matiu accepted D1053: [backport] qa: Make tmpdir option an absolute path, misc cleanup.
Jan 31 2018, 00:13

Jan 30 2018

matiu accepted D1048: [wallet] Remove redundant initialization.
Jan 30 2018, 23:20
matiu updated the diff for D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.

formatting bitcoin-cli

Jan 30 2018, 23:14
matiu updated the diff for D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
  • rm code from bitcoin-cli.cpp from other PR.
Jan 30 2018, 23:11
matiu committed rABCeab58826a7ed: Summary: stop using the gArgs wrappers (authored by Marko Bencun <marko.bencun@monetas.net>).
Summary: stop using the gArgs wrappers
Jan 30 2018, 23:08
matiu closed T212: scripted-diff: stop using the gArgs wrappers as Resolved by committing rABCeab58826a7ed: Summary: stop using the gArgs wrappers.
Jan 30 2018, 23:08
matiu closed D1044: Summary: stop using the gArgs wrappers.
Jan 30 2018, 23:08
matiu updated the diff for D1044: Summary: stop using the gArgs wrappers.

Revert change to trigger tests

Jan 30 2018, 22:49
matiu updated the diff for D1044: Summary: stop using the gArgs wrappers.

rebased

Jan 30 2018, 22:44
matiu committed rABCb9120934cd6c: fix multiwallet / symlink check (authored by matiu).
fix multiwallet / symlink check
Jan 30 2018, 22:36
matiu closed D1052: fix multiwallet / symlink check.
Jan 30 2018, 22:36
matiu retitled D1052: fix multiwallet / symlink check from WIP: fix multiwallet / symlink check to fix multiwallet / symlink check.
Jan 30 2018, 22:15
matiu updated the diff for D1052: fix multiwallet / symlink check.

use abs dirs when creating the symlink

Jan 30 2018, 22:15
matiu retitled D1052: fix multiwallet / symlink check from fix multiwallet / symlink check to WIP: fix multiwallet / symlink check.
Jan 30 2018, 21:55
Herald added a reviewer for D1052: fix multiwallet / symlink check: Restricted Project.
Jan 30 2018, 21:55
matiu updated the diff for D1044: Summary: stop using the gArgs wrappers.

Trying to rerun tests

Jan 30 2018, 18:03
matiu claimed T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.
Jan 30 2018, 16:47
matiu updated the summary of D1044: Summary: stop using the gArgs wrappers.
Jan 30 2018, 16:44
Herald added a reviewer for D1044: Summary: stop using the gArgs wrappers: Restricted Project.
Jan 30 2018, 16:32
matiu added a revision to T212: scripted-diff: stop using the gArgs wrappers: D1044: Summary: stop using the gArgs wrappers.
Jan 30 2018, 16:32
matiu claimed T212: scripted-diff: stop using the gArgs wrappers.
Jan 30 2018, 15:46
matiu created T212: scripted-diff: stop using the gArgs wrappers.
Jan 30 2018, 14:37
matiu closed T203: Build Bitcoin-ABC :: Master :: Bitcoin-ABC Master is broken. as Resolved.
Jan 30 2018, 14:35
matiu updated the summary of D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Jan 30 2018, 14:34
matiu retitled D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests from Add bitcoin-cli -stdin and -stdinrpcpass functional tests to [WIP] Add bitcoin-cli -stdin and -stdinrpcpass functional tests.
Jan 30 2018, 14:21
matiu updated the summary of D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Jan 30 2018, 14:19
Herald added a reviewer for D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests: Restricted Project.
Jan 30 2018, 14:18
matiu added a revision to T210: Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass: D1042: Add bitcoin-cli -stdin and -stdinrpcpass + tests.
Jan 30 2018, 14:18
matiu claimed T210: Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass.
Jan 30 2018, 13:10

Jan 27 2018

matiu added a comment to D1041: Make functions in validation.cpp static and pass chainparams.

I see some parts of PR10201 were already done on D348, D689

Jan 27 2018, 14:17

Jan 26 2018

matiu committed rABC68e8305a5983: Fix multiwallet test to look for proper jsonrpc text (authored by schancel).
Fix multiwallet test to look for proper jsonrpc text
Jan 26 2018, 18:05
matiu closed D1032: Fix multiwallet test to look for proper jsonrpc text.
Jan 26 2018, 18:05
First
Prev
Next