Page MenuHomePhabricator
Feed Advanced Search

May 2 2019

markblundeberg added a revision to T617: Backport PR 13033 "Build txindex in parallel with validation": D2903: [db] Migration for txindex data to new, separate database..
May 2 2019, 17:18
Herald added a reviewer for D2903: [db] Migration for txindex data to new, separate database.: deadalnix.
May 2 2019, 17:18
markblundeberg added a revision to T617: Backport PR 13033 "Build txindex in parallel with validation": D2901: [db] Create separate database for txindex..
May 2 2019, 17:13
markblundeberg added a task to D2901: [db] Create separate database for txindex.: T617: Backport PR 13033 "Build txindex in parallel with validation".
May 2 2019, 17:12
Herald added a reviewer for D2901: [db] Create separate database for txindex.: deadalnix.
May 2 2019, 17:12
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
May 2 2019, 02:45
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
May 2 2019, 02:44
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
May 2 2019, 01:00
markblundeberg updated the task description for T617: Backport PR 13033 "Build txindex in parallel with validation".
May 2 2019, 01:00

May 1 2019

markblundeberg added a comment to D2895: streamline utility tests to not depend on main headers.

(This is just an example -- I can expand this Diff to affect numerous other tests)

May 1 2019, 14:16
markblundeberg updated the summary of D2896: nits in lcg_tests.
May 1 2019, 14:08
Herald added a reviewer for D2896: nits in lcg_tests: deadalnix.
May 1 2019, 14:08
Herald added a reviewer for D2895: streamline utility tests to not depend on main headers: deadalnix.
May 1 2019, 14:00

Apr 30 2019

markblundeberg triaged T617: Backport PR 13033 "Build txindex in parallel with validation" as Normal priority.
Apr 30 2019, 01:33
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Apr 30 2019, 01:24
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Apr 30 2019, 01:19

Apr 26 2019

markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter.
Apr 26 2019, 05:16
markblundeberg added a task to D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter: T589: BIP157 & BIP158 backports.
Apr 26 2019, 05:16
Herald added a reviewer for D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter: deadalnix.
Apr 26 2019, 05:16
markblundeberg added inline comments to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Apr 26 2019, 05:05
markblundeberg updated the diff for D2872: blockfilter: Refactor and add tests for BlockFilter construction.

address Fabien comments

Apr 26 2019, 05:04
markblundeberg added inline comments to D2867: blockfilter: add block filters.
Apr 26 2019, 04:56
markblundeberg updated the diff for D2867: blockfilter: add block filters.

address Fabien comments

Apr 26 2019, 04:56

Apr 25 2019

markblundeberg added a comment to D2873: serialize: Serialization support for big-endian 32-bit ints..

Although this backport looks ok, I do think we should investigate test coverage in the future

Apr 25 2019, 19:47
markblundeberg requested review of D2873: serialize: Serialization support for big-endian 32-bit ints..

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

Apr 25 2019, 00:19

Apr 24 2019

markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2873: serialize: Serialization support for big-endian 32-bit ints..
Apr 24 2019, 15:22
markblundeberg added a task to D2873: serialize: Serialization support for big-endian 32-bit ints.: T589: BIP157 & BIP158 backports.
Apr 24 2019, 15:22
Herald added a reviewer for D2873: serialize: Serialization support for big-endian 32-bit ints.: deadalnix.
Apr 24 2019, 15:20
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Apr 24 2019, 05:19
markblundeberg added a task to D2872: blockfilter: Refactor and add tests for BlockFilter construction: T589: BIP157 & BIP158 backports.
Apr 24 2019, 05:19
Herald added a reviewer for D2872: blockfilter: Refactor and add tests for BlockFilter construction: deadalnix.
Apr 24 2019, 05:18
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Apr 24 2019, 01:16
markblundeberg added a comment to T589: BIP157 & BIP158 backports.

getting commit fef5adcc3 looks like it should be done after T590, though it looks like the rest of backports can proceed independently of that.

Apr 24 2019, 01:05
markblundeberg added a parent task for T590: Backport Core 14555: Move util files to new directory: T589: BIP157 & BIP158 backports.
Apr 24 2019, 01:05 ยท Backport, Restricted Project
markblundeberg added a subtask for T589: BIP157 & BIP158 backports: T590: Backport Core 14555: Move util files to new directory.
Apr 24 2019, 01:05

Apr 23 2019

markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2867: blockfilter: add block filters.
Apr 23 2019, 03:22
markblundeberg added a task to D2867: blockfilter: add block filters: T589: BIP157 & BIP158 backports.
Apr 23 2019, 03:22
Herald added a reviewer for D2867: blockfilter: add block filters: deadalnix.
Apr 23 2019, 03:18

Apr 19 2019

markblundeberg accepted D2457: [schnorr] Refactor the signature process in reusable component.
Apr 19 2019, 20:20

Apr 17 2019

markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..

rebase

Apr 17 2019, 00:44

Apr 16 2019

markblundeberg added a comment to D2811: Refactor: separate gui from wallet and node.

Macro sobig:

Apr 16 2019, 23:12
markblundeberg created Image Macro "sobig".
Apr 16 2019, 23:12
markblundeberg updated the diff for D2803: blockfilter: add GCSFilter class.

forgot cmakelists for test

Apr 16 2019, 20:39

Apr 14 2019

markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..

cstdint

Apr 14 2019, 23:36
markblundeberg updated the diff for D2803: blockfilter: add GCSFilter class.

char eradication and header normalization

Apr 14 2019, 23:30
markblundeberg added a task to D2803: blockfilter: add GCSFilter class: T589: BIP157 & BIP158 backports.
Apr 14 2019, 05:31
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2803: blockfilter: add GCSFilter class.
Apr 14 2019, 05:31
Herald added a reviewer for D2803: blockfilter: add GCSFilter class: deadalnix.
Apr 14 2019, 05:31

Apr 13 2019

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Apr 13 2019, 18:51
markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..
  • added cmakelists entry
  • created siphash.* files from ABC code instead of Core code
Apr 13 2019, 16:39
markblundeberg added inline comments to D2800: Extract CSipHasher to it's own file in crypto/ directory..
Apr 13 2019, 16:16
markblundeberg requested changes to D2457: [schnorr] Refactor the signature process in reusable component.

getting this rolling again ...

Apr 13 2019, 14:47
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2800: Extract CSipHasher to it's own file in crypto/ directory..
Apr 13 2019, 00:33
markblundeberg added a task to D2800: Extract CSipHasher to it's own file in crypto/ directory.: T589: BIP157 & BIP158 backports.
Apr 13 2019, 00:33
Herald added a reviewer for D2800: Extract CSipHasher to it's own file in crypto/ directory.: deadalnix.
Apr 13 2019, 00:31

Apr 12 2019

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Apr 12 2019, 22:49
markblundeberg updated the diff for D2799: streams: Implement BitStreamReader/Writer classes..

fix comments & typo

Apr 12 2019, 20:14
markblundeberg updated the diff for D2797: streams: Create VectorReader stream interface for vectors..
  • remove seek method per later backport
  • adjust comments style per comments
  • use cstdint types
Apr 12 2019, 19:37
markblundeberg added inline comments to D2799: streams: Implement BitStreamReader/Writer classes..
Apr 12 2019, 17:44
markblundeberg planned changes to D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 15:45
markblundeberg added a task to D2799: streams: Implement BitStreamReader/Writer classes.: T589: BIP157 & BIP158 backports.
Apr 12 2019, 03:17
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2799: streams: Implement BitStreamReader/Writer classes..
Apr 12 2019, 03:17
Herald added a reviewer for D2799: streams: Implement BitStreamReader/Writer classes.: deadalnix.
Apr 12 2019, 03:16
markblundeberg updated the summary of D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 02:52
markblundeberg abandoned D2798: streams: Unit test for VectorReader class..
Apr 12 2019, 02:37
markblundeberg updated the diff for D2797: streams: Create VectorReader stream interface for vectors..

squashed in child commit

Apr 12 2019, 02:36
markblundeberg planned changes to D2798: streams: Unit test for VectorReader class..
Apr 12 2019, 02:15
markblundeberg planned changes to D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 02:14
markblundeberg updated the test plan for D2798: streams: Unit test for VectorReader class..
Apr 12 2019, 02:12
markblundeberg updated the test plan for D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 02:11
markblundeberg updated the summary of D2798: streams: Unit test for VectorReader class..
Apr 12 2019, 02:04
markblundeberg updated the summary of D2798: streams: Unit test for VectorReader class..
Apr 12 2019, 02:04
markblundeberg updated the summary of D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 02:03
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2798: streams: Unit test for VectorReader class..
Apr 12 2019, 02:03
markblundeberg added a task to D2798: streams: Unit test for VectorReader class.: T589: BIP157 & BIP158 backports.
Apr 12 2019, 02:03
markblundeberg added a task to D2797: streams: Create VectorReader stream interface for vectors.: T589: BIP157 & BIP158 backports.
Apr 12 2019, 02:03
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 02:03
Herald added a reviewer for D2798: streams: Unit test for VectorReader class.: deadalnix.
Apr 12 2019, 02:02
Herald added a reviewer for D2797: streams: Create VectorReader stream interface for vectors.: deadalnix.
Apr 12 2019, 02:00

Apr 11 2019

markblundeberg triaged T589: BIP157 & BIP158 backports as Normal priority.
Apr 11 2019, 01:21

Feb 22 2019

markblundeberg abandoned D2516: Add address_cashaddr/address_legacy to validateaddress output.

It's been a couple of weeks. @Mondas if you want to reactivate this Diff, let me know.

Feb 22 2019, 16:31

Feb 18 2019

markblundeberg accepted D2563: Added missing release notes for 0.19.
Feb 18 2019, 19:25
Herald added a reviewer for D2562: un-mention segwit in addnode help text: deadalnix.
Feb 18 2019, 15:45

Feb 17 2019

markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Feb 17 2019, 01:16

Feb 16 2019

markblundeberg updated the diff for D2559: fix Qt crash.

s/Qt/bitcoin-qt

Feb 16 2019, 03:40
markblundeberg updated the diff for D2559: fix Qt crash.

add release note

Feb 16 2019, 03:35
Herald added a reviewer for D2559: fix Qt crash: deadalnix.
Feb 16 2019, 03:02
markblundeberg added a comment to D2322: remove minimum total fee option.

Need fix: https://github.com/bitcoin/bitcoin/pull/11332

Feb 16 2019, 02:41
markblundeberg added inline comments to D2322: remove minimum total fee option.
Feb 16 2019, 02:22

Feb 15 2019

markblundeberg removed a task from D2349: fix confusingly named function parameter 'scriptSig': T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.
Feb 15 2019, 17:08
markblundeberg removed a revision from T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG: D2349: fix confusingly named function parameter 'scriptSig'.
Feb 15 2019, 17:08
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG, a subtask of T526: Schnorr-ifying, as Resolved.
Feb 15 2019, 03:48
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG as Resolved.
Feb 15 2019, 03:48
markblundeberg updated the diff for D2483: Schnorr signature activation.
  • add extra node for doing actual ban-checking (whitelist was stopping this)
  • include positive ban tests (for schnorr multisig)
  • get rid of update_block
Feb 15 2019, 03:01

Feb 14 2019

markblundeberg accepted D2542: Format BIP32 test cases manually.

Yeah that was hideous before ... linters aren't always right. :-D

Feb 14 2019, 17:34
markblundeberg added a comment to D2554: CONTRIBUTING.md : recommend ccache.

Not 100% sure about the placement of this, but I think it does deserve to go *somewhere*.

Feb 14 2019, 17:31
Herald added a reviewer for D2554: CONTRIBUTING.md : recommend ccache: deadalnix.
Feb 14 2019, 17:30
markblundeberg accepted D2547: Merge #12366: http: Join worker threads before deleting work queue.

A nice simplification and improvement. Presumably there is no chance that StopHTTPServer will be called during StartHTTPServer execution, as they are only ever called from a particular thread?

Feb 14 2019, 06:08
markblundeberg accepted D2545: qt: Poll ShutdownTimer after init is done.
Feb 14 2019, 05:30
markblundeberg updated the diff for D2548: fix abc-parkedchain timeouts.

use wait_for_tip instead of sync_blocks

Feb 14 2019, 05:21