incorporate fixes from D2925
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 5 2019
May 5 2019
markblundeberg updated the diff for D2924: [txindex] Activate new transaction index code that runs in background.
In D2925#69387, @deadalnix wrote:Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.
Herald added a reviewer for D2935: index: Extract logic from TxIndex into reusable base class.: deadalnix.
Cool! I've been seeing these scripted-diffs in backports and was wondering how much pain it would be to get them running for us ...
markblundeberg added a comment to T630: Backport PR 13243 "Make reusable base class for auxiliary indices".
Last couple commits not happy here as they need T633 Need satisfied.
Herald added a reviewer for D2932: Support serialization as another type without casting: deadalnix.
markblundeberg added a comment to D2926: blockfilter: Use unordered_set instead of set in blockfilter..
Note -- Previously I thought this should be done after T590 (which creates the util/ directory) but it appears to be just fine like this - it sits in the same directory but is entirely independent.
markblundeberg updated the summary of D2927: scripted-diff: Rename SetBestChain callback ChainStateFlushed.
In D2904#69264, @deadalnix wrote:You also need to bring test/txindex_tests.cpp with it.
markblundeberg updated the summary of D2926: blockfilter: Use unordered_set instead of set in blockfilter..
markblundeberg updated the summary of D2924: [txindex] Activate new transaction index code that runs in background.
fix comment placement
In D2904#69247, @deadalnix wrote:No space in PR12345. please fix description.
markblundeberg triaged T635: Backport PR 12658 "Sanitize some wallet serialization" as Normal priority.
markblundeberg triaged T634: Backport PR 12683 "Fix more constness violations in serialization code" as Normal priority.
markblundeberg triaged T633: Backport PR 12731 "Support serialization as another type without casting" as Normal priority.
Herald added a reviewer for D2927: scripted-diff: Rename SetBestChain callback ChainStateFlushed: deadalnix.
markblundeberg removed a parent task for T617: Backport PR 13033 "Build txindex in parallel with validation": T589: BIP157 & BIP158 backports.
markblundeberg updated the task description for T617: Backport PR 13033 "Build txindex in parallel with validation".
markblundeberg renamed T632: Backport PR 13106 "Simplify semantics of ChainStateFlushed callback" from Backport PR 13106 to Backport PR 13106 "Simplify semantics of ChainStateFlushed callback".
markblundeberg renamed T632: Backport PR 13106 "Simplify semantics of ChainStateFlushed callback" from Backport PR PR 13106 to Backport PR 13106 .
markblundeberg triaged T632: Backport PR 13106 "Simplify semantics of ChainStateFlushed callback" as Normal priority.
markblundeberg updated the task description for T617: Backport PR 13033 "Build txindex in parallel with validation".
markblundeberg updated the diff for D2926: blockfilter: Use unordered_set instead of set in blockfilter..
de-charring
markblundeberg planned changes to D2926: blockfilter: Use unordered_set instead of set in blockfilter..
Herald added a reviewer for D2926: blockfilter: Use unordered_set instead of set in blockfilter.: deadalnix.
markblundeberg removed a parent task for T590: Backport Core 14555: Move util files to new directory: T589: BIP157 & BIP158 backports.
markblundeberg removed a subtask for T589: BIP157 & BIP158 backports: T590: Backport Core 14555: Move util files to new directory.
markblundeberg updated the task description for T617: Backport PR 13033 "Build txindex in parallel with validation".
markblundeberg updated the task description for T630: Backport PR 13243 "Make reusable base class for auxiliary indices".
markblundeberg triaged T630: Backport PR 13243 "Make reusable base class for auxiliary indices" as Normal priority.
markblundeberg added a comment to D2924: [txindex] Activate new transaction index code that runs in background.
Some testnet tests:
markblundeberg added inline comments to D2924: [txindex] Activate new transaction index code that runs in background.
markblundeberg added a comment to D2924: [txindex] Activate new transaction index code that runs in background.
RFC: I know the release-notes-pr13033.md doesn't make sense as a file name, but leaving it as-is for now until I find a better place for this text.
Herald added a reviewer for D2924: [txindex] Activate new transaction index code that runs in background: deadalnix.
May 4 2019
May 4 2019
Bug was that even when rlen < 32, it always tries to write 32 bytes into ret, but offset such that it would write past the end of ret.
May 2 2019
May 2 2019
fix linting (had an exception imported from the future)
markblundeberg updated the summary of D2903: [db] Migration for txindex data to new, separate database..