Page MenuHomePhabricator
Feed Advanced Search

Dec 7 2022

sdulfari accepted D12796: test: Print stderr when subprocess fails.
Dec 7 2022, 19:12
sdulfari accepted D12801: [website] Add eCash explorer.
Dec 7 2022, 19:11
sdulfari accepted D12790: Rename the remaining sigOps to sigChecks.
Dec 7 2022, 19:10

Dec 5 2022

sdulfari accepted D12768: Move CBlockFileInfo::ToString method where class is declared.
Dec 5 2022, 20:47
sdulfari accepted D12767: MOVEONLY: CWallet transaction code out of wallet.cpp/.h.
Dec 5 2022, 20:43

Dec 2 2022

sdulfari accepted D12734: test: use MiniWallet for rpc_scantxoutset.py.
Dec 2 2022, 17:35
sdulfari accepted D12730: test: MiniWallet: skip mempool check if `mempool_valid=False`.
Dec 2 2022, 17:11
sdulfari accepted D12733: test: Remove MiniWallet mempool_valid option.
Dec 2 2022, 17:10
sdulfari accepted D12732: test: Return the largest utxo in MiniWallet.get_utxo.
Dec 2 2022, 17:07
sdulfari accepted D12731: test: MiniWallet: more deterministic coin selection for coinbase UTXOs (oldest first).
Dec 2 2022, 17:02
sdulfari requested changes to D12730: test: MiniWallet: skip mempool check if `mempool_valid=False`.
Dec 2 2022, 16:59
sdulfari accepted D12729: test: use MiniWallet for p2p_filter.py.
Dec 2 2022, 16:56
sdulfari accepted D12726: [Linter] Fix MyPy linter with version 0.991.
Dec 2 2022, 16:45

Dec 1 2022

sdulfari accepted D12728: [Linter] Fix all the lint warnings.
Dec 1 2022, 17:28
sdulfari requested changes to D12726: [Linter] Fix MyPy linter with version 0.991.
Dec 1 2022, 17:04

Nov 30 2022

sdulfari closed D12711: tests: Add fuzzing harness for CConnman.
Nov 30 2022, 19:14
sdulfari committed rABC0a54d7ebf386: tests: Add fuzzing harness for CConnman (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Add fuzzing harness for CConnman
Nov 30 2022, 19:14
sdulfari requested review of D12711: tests: Add fuzzing harness for CConnman.
Nov 30 2022, 18:03
sdulfari accepted D12710: scripted-diff: rename MarkBlockAs functions.
Nov 30 2022, 17:50
sdulfari accepted D12709: [net processing] Tidy up MarkBlockAsReceived().
Nov 30 2022, 17:49
sdulfari accepted D12708: [net processing] Add IsBlockRequested() function.
Nov 30 2022, 17:46
sdulfari accepted D12707: [net processing] Remove QueuedBlock.hash.
Nov 30 2022, 17:40
sdulfari accepted D12706: scripted-diff: rename nPeersWithValidatedDownloads.
Nov 30 2022, 17:16
sdulfari accepted D12704: [net processing] Remove CNodeState.nBlocksInFlightValidHeaders.
Nov 30 2022, 17:16
sdulfari accepted D12703: [net processing] Remove QueuedBlock.fValidatedHeaders.
Nov 30 2022, 17:13
sdulfari accepted D12702: [net processing] Remove unnecessary hash arg from MarkBlockAsInFlight().
Nov 30 2022, 17:11
sdulfari accepted D12705: ConnectBlock: don't serialize block hash twice.
Nov 30 2022, 17:09
sdulfari accepted D12674: tracing: drop block_connected hash.toString() arg.
Nov 30 2022, 17:08
sdulfari closed D12693: [doc] Bump fuzzer child process memory limit.
Nov 30 2022, 16:50
sdulfari committed rABC337285c4c127: [doc] Bump fuzzer child process memory limit (authored by sdulfari).
[doc] Bump fuzzer child process memory limit
Nov 30 2022, 16:50

Nov 29 2022

sdulfari requested review of D12693: [doc] Bump fuzzer child process memory limit.
Nov 29 2022, 22:21

Nov 23 2022

sdulfari accepted D12598: test: add stress tests for initialization.
Nov 23 2022, 16:57

Nov 22 2022

sdulfari accepted D12582: node/chainstate: Add options for in-memory DBs.
Nov 22 2022, 17:26
sdulfari accepted D12581: node/caches: Remove intermediate variables.
Nov 22 2022, 17:24
sdulfari accepted D12580: node/caches: Extract cache calculation logic.
Nov 22 2022, 17:21
sdulfari accepted D12579: validation: LoadChainstate only needs Consensus::Params.
Nov 22 2022, 17:14
sdulfari accepted D12578: node/chainstate: Decouple from ShutdownRequested.
Nov 22 2022, 17:09
sdulfari accepted D12577: node/chainstate: Decouple from GetTime.
Nov 22 2022, 17:07
sdulfari accepted D12576: init: Delay RPC block notif until warmup finished.
Nov 22 2022, 17:05
sdulfari closed D12538: log: improve some validation log messages to include hashPrevBlock.
Nov 22 2022, 17:03
sdulfari committed rABC5c1a099852e6: log: improve some validation log messages to include hashPrevBlock (authored by sdulfari).
log: improve some validation log messages to include hashPrevBlock
Nov 22 2022, 17:03

Nov 18 2022

sdulfari requested review of D12538: log: improve some validation log messages to include hashPrevBlock.
Nov 18 2022, 21:20
sdulfari planned changes to D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block.
Nov 18 2022, 21:03
sdulfari updated the diff for D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block.

Tabling this patch for now considering recent improvements in UX on multiple exchanges. The risk now outbalances the benefits.

Nov 18 2022, 21:02
sdulfari added inline comments to D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block.
Nov 18 2022, 20:57

Nov 17 2022

sdulfari updated the summary of D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block.
Nov 17 2022, 19:15
sdulfari updated the summary of D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block.
Nov 17 2022, 19:14
sdulfari updated the summary of D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block.
Nov 17 2022, 19:08
sdulfari published D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block for review.
Nov 17 2022, 19:07
sdulfari accepted D12514: doc: Clarify nPruneAfterHeight.
Nov 17 2022, 00:47
sdulfari accepted D12513: test: Load genesis block to allow flush.
Nov 17 2022, 00:46
sdulfari accepted D12512: Move blockstorage-related unload to BlockManager::Unload.
Nov 17 2022, 00:06

Nov 16 2022

sdulfari accepted D12511: move-only: Create WriteBlockIndexDB helper.
Nov 16 2022, 19:56
sdulfari accepted D12510: Move functions to BlockManager.
Nov 16 2022, 19:54

Nov 10 2022

sdulfari closed D12472: [avalanche] Give peer discovery functional test class a unique name.
Nov 10 2022, 21:52
sdulfari committed rABCeb59cc4c20f7: [avalanche] Give peer discovery functional test class a unique name (authored by sdulfari).
[avalanche] Give peer discovery functional test class a unique name
Nov 10 2022, 21:52
sdulfari closed D12471: [avalanche] Fix typo in test comments.
Nov 10 2022, 21:52
sdulfari committed rABC9d6db5b202e8: [avalanche] Fix typo in test comments (authored by sdulfari).
[avalanche] Fix typo in test comments
Nov 10 2022, 21:52
sdulfari requested review of D12472: [avalanche] Give peer discovery functional test class a unique name.
Nov 10 2022, 17:19
sdulfari requested review of D12471: [avalanche] Fix typo in test comments.
Nov 10 2022, 17:13

Nov 9 2022

sdulfari accepted D12449: p2p: Rename fBlocksOnly, Add test.
Nov 9 2022, 21:32
sdulfari accepted D12435: test: run mempool_reorg.py even with wallet disabled.
Nov 9 2022, 21:26

Nov 8 2022

sdulfari accepted D12437: test: use MiniWallet for p2p_blocksonly.py.
Nov 8 2022, 18:25
sdulfari accepted D12436: test: Run feature_cltv with MiniWallet.
Nov 8 2022, 18:23
sdulfari requested changes to D12435: test: run mempool_reorg.py even with wallet disabled.
Nov 8 2022, 18:09
sdulfari accepted D12434: test: Speed up mempool_spend_coinbase.py.
Nov 8 2022, 17:54
sdulfari accepted D12432: test: Speed up rpc_blockchain.py by removing miniwallet.generate().
Nov 8 2022, 17:48

Nov 7 2022

sdulfari accepted D12425: Bump version to 0.26.6.
Nov 7 2022, 18:57
sdulfari accepted D12427: rpc: calculate fees in getblock using BlockUndo data.
Nov 7 2022, 18:56
sdulfari accepted D12424: test: run mempool_resurrect.py even with wallet disabled.
Nov 7 2022, 18:31
sdulfari accepted D12423: test: run mempool_expiry.py even with wallet disabled.
Nov 7 2022, 18:26
sdulfari accepted D12429: Make TxToUniv take a BlockHash instead of a raw uint256.
Nov 7 2022, 18:15

Nov 4 2022

teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Like token.
Nov 4 2022, 13:06
teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Love token.
Nov 4 2022, 12:15

Nov 3 2022

teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Like token.
Nov 3 2022, 15:59
teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Love token.
Nov 3 2022, 12:12

Nov 2 2022

teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Like token.
Nov 2 2022, 19:41
teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Mountain of Wealth token.
Nov 2 2022, 16:09
teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Doubloon token.
Nov 2 2022, 16:08
teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Piece of Eight token.
Nov 2 2022, 16:02
teamcity awarded D12370: [avalanche] Add experimental difficulty penalty for blocks that arrive sooner than 2 minutes from the previous block a Haypence token.
Nov 2 2022, 15:43

Nov 1 2022

sdulfari requested changes to D12405: avalanche: add 'finalized' field to getblockstats.

What is the use case for adding this field in addition to isfinalblock RPC?

Nov 1 2022, 23:42

Oct 31 2022

sdulfari closed D12373: [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions.
Oct 31 2022, 16:21
sdulfari committed rABC1cfb3559c159: [avalanche] Add compile and runtime assertions that cs_main is not held for… (authored by sdulfari).
[avalanche] Add compile and runtime assertions that cs_main is not held for…
Oct 31 2022, 16:21

Oct 28 2022

sdulfari updated the diff for D12373: [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions.

Revert moving quorum check in net code. I'm not able to reproduce this for some reason.

Oct 28 2022, 15:52

Oct 27 2022

sdulfari added inline comments to D12373: [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions.
Oct 27 2022, 20:25
sdulfari updated the diff for D12373: [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions.

Use LOCKS_EXCLUDED instead of EXCLUSIVE_LOCKS_REQUIRED because cs_main locks are taken in too many places to exclude cs_main from everywhere it should not be taken. For more info see https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#negative

Oct 27 2022, 16:30
sdulfari closed D12375: Upgrade bitcoin-abc-dev to debian bullseye.
Oct 27 2022, 16:00
sdulfari committed rABC9a0ac4438eae: Upgrade bitcoin-abc-dev to debian bullseye (authored by sdulfari).
Upgrade bitcoin-abc-dev to debian bullseye
Oct 27 2022, 16:00

Oct 26 2022

sdulfari requested review of D12375: Upgrade bitcoin-abc-dev to debian bullseye.
Oct 26 2022, 22:44
sdulfari planned changes to D12373: [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions.
Oct 26 2022, 17:27
sdulfari requested review of D12373: [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions.
Oct 26 2022, 16:54

Oct 25 2022

sdulfari closed D12355: [avalanche] Fix a data race where updating availability scores can coincide with initialization of state.
Oct 25 2022, 17:27
sdulfari committed rABC37b15058a6fb: [avalanche] Fix a data race where updating availability scores can coincide… (authored by sdulfari).
[avalanche] Fix a data race where updating availability scores can coincide…
Oct 25 2022, 17:27
sdulfari accepted D12365: test: a test to check descendant limits.

Nit to fix comment

Oct 25 2022, 16:24
sdulfari added inline comments to D12355: [avalanche] Fix a data race where updating availability scores can coincide with initialization of state.
Oct 25 2022, 16:02
sdulfari updated the diff for D12355: [avalanche] Fix a data race where updating availability scores can coincide with initialization of state.

Revert returning score of 0 for avalanche-disabled nodes

Oct 25 2022, 16:01

Oct 24 2022

sdulfari updated the diff for D12355: [avalanche] Fix a data race where updating availability scores can coincide with initialization of state.

Fix missing unit test changes

Oct 24 2022, 16:28
sdulfari closed D12325: [avalanche] Record peers that have avalanche enabled.
Oct 24 2022, 15:57
sdulfari committed rABC2ace692109ea: [avalanche] Record peers that have avalanche enabled (authored by sdulfari).
[avalanche] Record peers that have avalanche enabled
Oct 24 2022, 15:57