Page MenuHomePhabricator
Feed Advanced Search

Jul 14 2023

emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.

updated README

Jul 14 2023, 12:52
emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.
  • updated utxos API to return the single entry utxo object directly
  • updated utxo response in xecUtxos and slpUtxos
Jul 14 2023, 12:50
emack added a comment to D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.

Although having said that, changing prices after launch is meant to be extremely rare.

Jul 14 2023, 09:27
emack added inline comments to D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.
Jul 14 2023, 09:24
emack added inline comments to D14257: [Chronik-client] Implement new UTXO APIs.
Jul 14 2023, 09:22
emack updated the summary of D14257: [Chronik-client] Implement new UTXO APIs.
Jul 14 2023, 03:22
emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.
  • deprecated the legacy utxos() function
  • the utxosSeparated() function is now refactored as the new utxos() function which interacts with chronik
  • the xecUtxos() and slpUtxos() functions now calls upon the refactored utxos() function for chronik interaction
  • bumped version to 1.0.0 to reflect breaking change
  • updated README
Jul 14 2023, 03:13
emack updated the diff for D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.
  • added isValidAliasPricing in validation.js that checks alias pricing response for keys and value types
  • updated error handling for alias price retrieval logic
Jul 14 2023, 02:44
emack updated the diff for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
  • aligned error handling in registerAlias
Jul 14 2023, 00:51
emack updated the diff for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
  • updated error handling to lock UI with UI notification
  • removed redoondant exception check for server unavailability
Jul 14 2023, 00:40

Jul 13 2023

emack abandoned D13683: [WIP] [Cashtab] [Jest refactor] alias.js unit tests.
Jul 13 2023, 14:08
emack updated the summary of D14257: [Chronik-client] Implement new UTXO APIs.
Jul 13 2023, 13:25
emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.

Removed redundant array size checks

Jul 13 2023, 13:23
emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.

Good point,

  • utxosByType now split into separate xecUtxos and slpUtxos functions that leverage the existing utxos API for chronik interaction and specifically returns XEC or SLP utxos.
  • Updated utxosSeparated to leverage the existing utxos API as well, returning an object containing XEC and SLP utxo sets.
Jul 13 2023, 13:20
emack updated the summary of D14257: [Chronik-client] Implement new UTXO APIs.
Jul 13 2023, 05:27
emack retitled D14257: [Chronik-client] Implement new UTXO APIs from [Chronik-client] Update the .script().utxos() API to return separated UTXOs to [Chronik-client] Implement new UTXO APIs.
Jul 13 2023, 05:17
emack added a comment to D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.

And further discussion / alignment with Pierre on coin selection algos

Jul 13 2023, 05:15
emack planned changes to D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.

Subject to D14257 landing

Jul 13 2023, 05:14
emack updated the summary of D14257: [Chronik-client] Implement new UTXO APIs.
Jul 13 2023, 05:05
emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.
  • Reverted the existing .script().utxos() function to maintain backwards compatibility
  • Added a new .script().utxosByType(type) function to only return XEC or SLP UTXOs based on supplied type. Wallets which don't support eTokens can use this to easily retrieve UTXOs to spend without worrying about accidentally burning SLP UTXOs.
  • Added a new .script().utxosSeparated() function to return all UTXOs however neatly separated into two separate XEC and SLP UTXO arrays. Cashtab and other eToken compatible wallets can use this to refresh its XEC and SLP utxo sets without additional parsing logic.
  • updated README and bumped package.json
Jul 13 2023, 05:03
emack updated the diff for D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.
  • similar to D14247, removed unreachable exception checks
  • corrected error handling flow
Jul 13 2023, 03:36
emack added inline comments to D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.
Jul 13 2023, 03:05
emack updated the test plan for D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.
Jul 13 2023, 03:03
emack updated the diff for D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.
  • updated to retrieve registration prices once on page load and saved in state
  • error notification on price retrieval errors on page load, this can be tested by changing const priceResponse = await queryAliasServer('prices', ''); to const priceResponse = await queryAliasServer('prices', 'aaa'); in Alias.js to trigger an exception. Verify the UI error notification and the permanent disabling of the Register button
  • removed redundant getAliasRegistrationFee
Jul 13 2023, 03:02
emack updated the diff for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.

Updated conditional statements

Jul 13 2023, 00:19

Jul 12 2023

emack updated the summary of D14257: [Chronik-client] Implement new UTXO APIs.
Jul 12 2023, 10:03
emack updated the diff for D14257: [Chronik-client] Implement new UTXO APIs.

Removed the duplicated utxo set in the existing utxos array.

Jul 12 2023, 10:02
emack updated the diff for D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.

Responding to feedback

Jul 12 2023, 03:39
emack updated the diff for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.

Updated pre-registration to check for aliasDetails.error

Jul 12 2023, 03:25
emack planned changes to D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
Jul 12 2023, 03:20
emack updated the diff for D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.

Added aliasDetails.error check

Jul 12 2023, 03:15
emack updated the diff for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.

Rebased to D14246

Jul 12 2023, 03:05
emack updated the summary of D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
Jul 12 2023, 00:45
emack updated the summary of D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
Jul 12 2023, 00:44
emack closed D14246: [Cashtab][Alias] Deprecate isAliasServerOnline.
Jul 12 2023, 00:23
emack committed rABCb9969d7c99e2: [Cashtab][Alias] Deprecate isAliasServerOnline (authored by emack).
[Cashtab][Alias] Deprecate isAliasServerOnline
Jul 12 2023, 00:23
emack requested review of D14257: [Chronik-client] Implement new UTXO APIs.
Jul 12 2023, 00:16

Jul 11 2023

emack requested review of D14247: [Cashtab][Alias] Switch alias registration fee lookup to api.
Jul 11 2023, 09:15
emack updated the diff for D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.

Updated if statement and registration status check

Jul 11 2023, 08:04
emack added inline comments to D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.
Jul 11 2023, 08:04
emack added inline comments to D14246: [Cashtab][Alias] Deprecate isAliasServerOnline.
Jul 11 2023, 07:53
emack closed D14239: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.
Jul 11 2023, 07:11
emack committed rABC0451ed1fb8a7: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils (authored by emack).
[Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils
Jul 11 2023, 07:11
emack added a comment to D14239: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.

OK with the function move, but the registration fees should not be hardcoded in cashtab. A much better strategy is to gather them from the alias server via some endpoint so maintenance happens at a single place and the price is publicly accessible to anybody without having to dig into the spec. It also can be changed much more easily if somebody else decides to build another registration app.

Jul 11 2023, 07:10
emack updated the diff for D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.

Removed change to aliasPaymentAddress

Jul 11 2023, 07:06
emack added inline comments to D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.
Jul 11 2023, 07:05
emack added a comment to D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.

To be rebased once D14246 lands

Jul 11 2023, 06:53
emack requested review of D14246: [Cashtab][Alias] Deprecate isAliasServerOnline.
Jul 11 2023, 06:50

Jul 10 2023

emack requested review of D14239: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.
Jul 10 2023, 05:54
emack abandoned D14238: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.
Jul 10 2023, 05:37
emack updated the diff for D14238: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.

rebase

Jul 10 2023, 05:35
emack updated the summary of D14238: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.
Jul 10 2023, 05:34
emack requested review of D14238: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.
Jul 10 2023, 05:27
emack updated the diff for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
  • rebased to use the new queryAliasServer wrapper
  • added try/catch blocks for alias-server queries
Jul 10 2023, 04:31
emack updated the test plan for D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
Jul 10 2023, 04:15
emack closed D14237: [Cashtab][Alias] Deprecate reserved aliases.
Jul 10 2023, 03:20
emack committed rABC67e4ce225413: [Cashtab][Alias] Deprecate reserved aliases (authored by emack).
[Cashtab][Alias] Deprecate reserved aliases
Jul 10 2023, 03:20
emack closed D14236: [Cashtab][Alias] Deprecate appendWithPendingAliases.
Jul 10 2023, 03:11
emack committed rABC9424f65a7559: [Cashtab][Alias] Deprecate appendWithPendingAliases (authored by emack).
[Cashtab][Alias] Deprecate appendWithPendingAliases
Jul 10 2023, 03:11

Jul 9 2023

emack requested review of D14237: [Cashtab][Alias] Deprecate reserved aliases.
Jul 9 2023, 13:48
emack updated the diff for D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.
  • rebased to use the new queryAliasServer wrapper
Jul 9 2023, 10:36
emack requested review of D14236: [Cashtab][Alias] Deprecate appendWithPendingAliases.
Jul 9 2023, 10:15

Jul 8 2023

emack updated the summary of D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.
Jul 8 2023, 14:11
emack updated the summary of D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.
Jul 8 2023, 14:10
emack updated the diff for D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.

Refactored p2pkh byte count calculation breakdowns and brought it back to fundamentals

Jul 8 2023, 13:56
emack planned changes to D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.
  • bytecount formula is under review
Jul 8 2023, 10:42
emack updated the diff for D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.
  • updated utxo collection approach to assumes 2 outputs initially and then if change output is not required update the bytecount/txFee using 1 output count
  • updated getInputUtxos to return inputs, outputCount and txFee
  • updated terminology and naming throughout module
  • updated .gitignore
  • implemented eslint module to standardize headers
Jul 8 2023, 10:42
emack closed D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.
Jul 8 2023, 06:53
emack committed rABC5695d76dcf90: [Cashtab][Alias] Update alias-server wrappers to return JSON (authored by emack).
[Cashtab][Alias] Update alias-server wrappers to return JSON
Jul 8 2023, 06:53

Jul 7 2023

emack updated the diff for D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.

Updated catch block to log the endpoint output on error

Jul 7 2023, 13:31
emack updated the diff for D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.

rebase/lint

Jul 7 2023, 09:22
emack requested review of D14227: [eCash library][ecash-coinselect] Initial npm module for basic utxo selection.
Jul 7 2023, 09:17
emack accepted D14223: [chronik-client] Add example for chronik.token call.

yup, monorepo version has the token api

Jul 7 2023, 04:49
emack updated the summary of D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.
Jul 7 2023, 00:50
emack updated the diff for D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.

Consolidated getAliasDetails and getAliasesForAddress into a single alias-server wrapper, passing in the endpoint and query param as inputs. Unit tests updated accordingly.

Jul 7 2023, 00:50
emack added a comment to D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.

image.png (367×489 px, 186 KB)

Jul 7 2023, 00:49

Jul 6 2023

emack updated the diff for D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.

improved error handling for when alias-server is non-responsive, improved code efficient per feedback

Jul 6 2023, 16:06
emack planned changes to D14198: [Apps][Examples] Sending XECs.
Jul 6 2023, 12:11
emack added inline comments to D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.
Jul 6 2023, 07:33
emack requested review of D14219: [Cashtab][Alias] Update alias-server wrappers to return JSON.
Jul 6 2023, 07:28

Jul 5 2023

emack requested review of D14212: [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias.
Jul 5 2023, 08:38
emack updated the diff for D14198: [Apps][Examples] Sending XECs.

Updated comments and variables as per feedback, added two unit tests for greater than circulating supply and with decimal points

Jul 5 2023, 06:35
emack planned changes to D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.

on hold from review until alias-server's avalanche finalization checks in handleBlockConnected() are updated. This is needed to verify that a confirmed alias registration alias is reflected in the Alias.js page

Jul 5 2023, 01:46
emack requested review of D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.
Jul 5 2023, 01:44
emack closed D14205: [Cashtab][Alias] Deprecate getAliasServerHistory.
Jul 5 2023, 01:31
emack committed rABC4d7604c58f8a: [Cashtab][Alias] Deprecate getAliasServerHistory (authored by emack).
[Cashtab][Alias] Deprecate getAliasServerHistory
Jul 5 2023, 01:31
emack updated the diff for D14198: [Apps][Examples] Sending XECs.

updated per various feedback, added unit test for an XEC amount equal to current circulating supply and updated example to use 1 sat / byte for tx fee calculation

Jul 5 2023, 01:28

Jul 4 2023

emack updated the diff for D14198: [Apps][Examples] Sending XECs.
  • removed bignumber.js dependency
  • XEC to sats conversion moved into separate convertXecToSatoshis() function
  • updated contextual comments throughout example
Jul 4 2023, 13:13
emack abandoned D14206: [Cashtab][Alias] Refactor getAliasServerState.
Jul 4 2023, 07:41
emack planned changes to D14206: [Cashtab][Alias] Refactor getAliasServerState.
Jul 4 2023, 07:32
emack requested review of D14206: [Cashtab][Alias] Refactor getAliasServerState.
Jul 4 2023, 06:52
emack requested review of D14205: [Cashtab][Alias] Deprecate getAliasServerHistory.
Jul 4 2023, 06:14

Jul 3 2023

emack closed D14199: [Cashtab][Alias] Deprecate getLatestAliases.
Jul 3 2023, 15:28
emack committed rABC7bc02bf55caa: [Cashtab][Alias] Deprecate getLatestAliases (authored by emack).
[Cashtab][Alias] Deprecate getLatestAliases
Jul 3 2023, 15:28
emack added inline comments to D14199: [Cashtab][Alias] Deprecate getLatestAliases.
Jul 3 2023, 15:28
emack updated the summary of D14199: [Cashtab][Alias] Deprecate getLatestAliases.
Jul 3 2023, 14:59
emack requested review of D14199: [Cashtab][Alias] Deprecate getLatestAliases.
Jul 3 2023, 14:59
emack closed D14189: [Cashtab][Alias] Implement getAliasesForAddress.
Jul 3 2023, 14:44
emack committed rABC6720c88e2e55: [Cashtab][Alias] Implement getAliasesForAddress (authored by emack).
[Cashtab][Alias] Implement getAliasesForAddress
Jul 3 2023, 14:44
emack closed D14191: [Cashtab][Alias] Implement getAliasDetails.
Jul 3 2023, 14:35