@bot preview-e.cash
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 21 2023
Sep 21 2023
teamcity awarded D14523: [e.cash] Add Guarda wallet a Haypence token.
PiRK committed rABC0365ac9bdb97: [electrum] minor cleanup of Transaction.fetch_input_data (authored by PiRK).
[electrum] minor cleanup of Transaction.fetch_input_data
[electrum] fix OutPoint.__str__
simplify the code by removing a debbuging log, fix the comment
rebase onto D14521
lint and reuse self.outpoint_bytes in test
investigating a bug, not sure if related
bytesofman committed rABC1ed302b86f1e: [apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific… (authored by bytesofman).
[apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific…
Fabien accepted D14518: [apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific implementations.
I'm not sure it needs to live in chronik-client. Delivering a mock as part of a library is mostly consuming storage for no added value from the lib users point of view. Also chronik-client doesn't need the mock.
bytesofman committed rABCc99767329fcc: [alias-server] Deprecate local script lib (authored by bytesofman).
[alias-server] Deprecate local script lib
teamcity triaged T3296: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
In D14517#326035, @bytesofman wrote:ninja all check-all
Is this run by teamcity?
Fabien committed rABC6aa3bbb32394: [chronik] Add support for HTTPS connection to the test framework python client (authored by Fabien).
[chronik] Add support for HTTPS connection to the test framework python client
Fabien added a comment to D14515: [chronik] Add support for HTTPS connection to the test framework python client.
In D14515#326029, @bytesofman wrote:potential nit: https is set to False by default in the init, but the way the if/else connection and websocket url definition gates are ordered it would seem https is the expected condition.
ninja all check-all
bytesofman accepted D14515: [chronik] Add support for HTTPS connection to the test framework python client.
potential nit: https is set to False by default in the init, but the way the if/else connection and websocket url definition gates are ordered it would seem https is the expected condition.
teamcity triaged T3295: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Unbreak Now! priority.
bytesofman committed rABC90fb1b988731: [Cashtab] Clear input forms when user toggles between single and multi-send (authored by bytesofman).
[Cashtab] Clear input forms when user toggles between single and multi-send
bytesofman committed rABC6991ac9fccd4: [apps] Consistently apply naming convention for mocha unit test files (authored by bytesofman).
[apps] Consistently apply naming convention for mocha unit test files
bytesofman committed rABC5c292c35cff0: [Cashtab] Deprecate unused function (authored by bytesofman).
[Cashtab] Deprecate unused function
bytesofman planned changes to D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
To create and implement an ecash-specific coinselect lib
remove another indentation by appending "already complete" inputs first
need_dl_txids[prevout_hash].append((i, n)) also needs duplicating. Add comments.
remove more indentation (this requires some duplication of inps.append(inp))
Fabien requested changes to D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
I looked closely at the coinselect library, and I'm not sold to this solution:
- It obviously expects some format that is close but not similar to chronik utxos, adding some boilerplate to convert between the formats
- It doesn't support txs with more than 253 in/outs
- It doesn't manage the dust in an eCash compatible way
- As a consequence you can end up with a change output which is below the dust threshold, which is not handled by your code and would cause your tx to get rejected
Sep 20 2023
Sep 20 2023
Update snapshot
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
bytesofman requested review of D14511: [apps] Consistently apply naming convention for mocha unit test files.
bytesofman committed rABCfe9a1aad5426: [alias-server] remove redundant address validation from db function (authored by bytesofman).
[alias-server] remove redundant address validation from db function
bytesofman added inline comments to D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
bytesofman updated the diff for D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
Add error case unit test for signInputs
bytesofman planned changes to D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
need some test cases for tx signing errors
bytesofman updated the diff for D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
Better code comments and variable names
bytesofman updated the diff for D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
Move generated mocks to a marked file
bytesofman planned changes to D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
Move generated items out of fixtures file
bytesofman updated the diff for D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
add p2sh destination address test vector
PiRK committed rABCd51fd7394adc: [electrum] check output type in Transaction and fix a callsites that still… (authored by PiRK).
[electrum] check output type in Transaction and fix a callsites that still…
PiRK updated the diff for D14508: [electrum] check output type in Transaction and fix a callsites that still passes a regular tuple.
rebase
PiRK committed rABCcff5b05affcb: [electrum] use TxInput (almost) everywhere in transaction.py (authored by PiRK).
[electrum] use TxInput (almost) everywhere in transaction.py
[electrum] add prev_tx to TxInput
bytesofman planned changes to D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
add test vector for sending to p2sh
bytesofman updated the summary of D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
[electrum] convert var_int to return bytes
bytesofman updated the diff for D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
Better comments
fix typo (i'm pretty sure I fixed this before, but maybe it got lost in an aborted rebase)
Rerun all the interactive tests to be sure.
bytesofman updated the diff for D14507: [Cashtab] Use updated ecash-coinselect lib to create min fee txs.
Add simplified signing function, add new test vectore, remove debug logging
i think there was a rebase incident
rebase after doing the prev_tx change in another diff
fix the test name (the scope is larger than hardware wallets), no need to pop "value" if not specified
don't add "value" when the input is complete, don't assert value is not None for incomplete TxInput (it can be constructed like this initially and the value can be added later by the wallet), add a test for the different behavior between complete transactions and incomplete transactions