Page MenuHomePhabricator
Feed Advanced Search

Mar 26 2024

PiRK published D15756: Remove ::dustRelayFee global for review.
Mar 26 2024, 15:30
PiRK closed D15778: remove ::fAcceptDatacarrier global.
Mar 26 2024, 14:18
PiRK committed rABCfcf58d6bd71c: remove ::fAcceptDatacarrier global (authored by PiRK).
remove ::fAcceptDatacarrier global
Mar 26 2024, 14:18
PiRK accepted D15781: [avalanche] Reject blocks that contains txs conflicting with finalized txs.
Mar 26 2024, 14:17
PiRK updated the summary of D15778: remove ::fAcceptDatacarrier global.
Mar 26 2024, 10:18
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

remove the ArgsManager shortcut, the parsing of arguments is now only needed in one place

Mar 26 2024, 08:10
PiRK closed D15780: fix includes in standard.{h|cpp}.
Mar 26 2024, 07:51
PiRK committed rABC4b15b2af0406: fix includes in standard.{h|cpp} (authored by PiRK).
fix includes in standard.{h|cpp}
Mar 26 2024, 07:51

Mar 25 2024

PiRK planned changes to D15778: remove ::fAcceptDatacarrier global.

the system.h changes are no longer required, the args inspection code can be moved to mempool_options.h

Mar 25 2024, 16:24
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

revert most avalanche changes, wrap IsStandard for the purpose of checking a proof's validity

Mar 25 2024, 15:42
PiRK updated the summary of D15780: fix includes in standard.{h|cpp}.
Mar 25 2024, 14:42
PiRK accepted D15779: [avalanche] Check the node can mine a finalized tx.
Mar 25 2024, 14:41
PiRK updated the diff for D15780: fix includes in standard.{h|cpp}.

don't remove the uint256.h include (uint160 needed for templates) and don't confuse uint256 with sha256

Mar 25 2024, 14:40
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

MakeProcessor takes argsman as a parameter, no need to access it via the global gArgs

Mar 25 2024, 14:30
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

rebase onto D15780

Mar 25 2024, 14:25
PiRK requested review of D15780: fix includes in standard.{h|cpp}.
Mar 25 2024, 14:23
PiRK closed D15777: Remove ::GetVirtualTransactionSize() alias.
Mar 25 2024, 13:45
PiRK closed D15757: Remove ::fIsBareMultisigStd global.
Mar 25 2024, 13:45
PiRK committed rABCfb43a8161191: Remove ::fIsBareMultisigStd global (authored by MacroFake <falke.marco@gmail.com>).
Remove ::fIsBareMultisigStd global
Mar 25 2024, 13:45
PiRK committed rABC6341c2a89327: Remove ::GetVirtualTransactionSize() alias (authored by MacroFake <falke.marco@gmail.com>).
Remove ::GetVirtualTransactionSize() alias
Mar 25 2024, 13:45
PiRK closed D15755: Remove ::IsStandardTx(tx, reason) alias.
Mar 25 2024, 13:45
PiRK closed D15754: test: Remove unused cs_main.
Mar 25 2024, 13:44
PiRK committed rABC2692dad01c14: Remove ::IsStandardTx(tx, reason) alias (authored by MacroFake <falke.marco@gmail.com>).
Remove ::IsStandardTx(tx, reason) alias
Mar 25 2024, 13:44
PiRK committed rABC9bbe839c31b7: test: Remove unused cs_main (authored by MacroFake <falke.marco@gmail.com>).
test: Remove unused cs_main
Mar 25 2024, 13:44
PiRK closed D15753: Remove ::minRelayTxFee global.
Mar 25 2024, 13:44
PiRK closed D15752: Remove ::fRequireStandard global.
Mar 25 2024, 13:44
PiRK committed rABC1f260dda7638: Remove ::minRelayTxFee global (authored by MacroFake <falke.marco@gmail.com>).
Remove ::minRelayTxFee global
Mar 25 2024, 13:44
PiRK committed rABC0dae545fa338: Remove ::fRequireStandard global (authored by MacroFake <falke.marco@gmail.com>).
Remove ::fRequireStandard global
Mar 25 2024, 13:44
PiRK closed D15751: Return optional error from ApplyArgsManOptions.
Mar 25 2024, 13:44
PiRK committed rABC2a09ae226d0c: Return optional error from ApplyArgsManOptions (authored by MacroFake <falke.marco@gmail.com>).
Return optional error from ApplyArgsManOptions
Mar 25 2024, 13:44
PiRK added inline comments to D15755: Remove ::IsStandardTx(tx, reason) alias.
Mar 25 2024, 12:31
PiRK updated the diff for D15753: Remove ::minRelayTxFee global.

improve policy/README.md

Mar 25 2024, 11:32
PiRK added inline comments to D15753: Remove ::minRelayTxFee global.
Mar 25 2024, 11:32
PiRK planned changes to D15778: remove ::fAcceptDatacarrier global.

circular dependency issue

Mar 25 2024, 09:48
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

fix more fuzzers, adjust the transaction_tests test to use the proper custom max size param and remove now unneeded gArgs.ForceSetArg

Mar 25 2024, 09:43
PiRK planned changes to D15778: remove ::fAcceptDatacarrier global.

fuzzer needs fixing, one of the transaction test needs adjusting

Mar 25 2024, 09:31
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

remove unused max_datacarrier_bytes in processor.cpp

Mar 25 2024, 09:28
PiRK requested review of D15778: remove ::fAcceptDatacarrier global.
Mar 25 2024, 09:25
PiRK updated the test plan for D15777: Remove ::GetVirtualTransactionSize() alias.
Mar 25 2024, 09:25
PiRK requested review of D15777: Remove ::GetVirtualTransactionSize() alias.
Mar 25 2024, 09:23

Mar 22 2024

PiRK published D15757: Remove ::fIsBareMultisigStd global for review.
Mar 22 2024, 16:08
PiRK updated the diff for D15755: Remove ::IsStandardTx(tx, reason) alias.

rebase

Mar 22 2024, 16:06
PiRK published D15754: test: Remove unused cs_main for review.
Mar 22 2024, 16:05
PiRK published D15753: Remove ::minRelayTxFee global for review.
Mar 22 2024, 16:03
PiRK published D15752: Remove ::fRequireStandard global for review.
Mar 22 2024, 16:02
PiRK published D15751: Return optional error from ApplyArgsManOptions for review.
Mar 22 2024, 16:01
PiRK accepted D15765: [Cashtab] Update dependencies.

I ran the npm audit fix command locally and got the same results

Mar 22 2024, 11:04
PiRK accepted D15761: [token-server] Support token icon creation from extension and dev sites.
Mar 22 2024, 11:01

Mar 21 2024

PiRK accepted D15762: [Cashtab] Standardize modal size for upgrades.
Mar 21 2024, 19:22
PiRK accepted D15763: [Cashtab] Remove css typo.
Mar 21 2024, 19:20
PiRK accepted D15760: [Cashtab] Remove debug log for token icons.
Mar 21 2024, 19:20
PiRK accepted D15759: [token-server] stop logging ws events.
Mar 21 2024, 19:19
PiRK accepted D15758: [CI] Use non gold linker for the AUR packages.
Mar 21 2024, 19:19
PiRK planned changes to D15755: Remove ::IsStandardTx(tx, reason) alias.

this was meant to be a draft for now, like the rest of the stack

Mar 21 2024, 16:31
PiRK requested review of D15755: Remove ::IsStandardTx(tx, reason) alias.
Mar 21 2024, 16:09
teamcity awarded D15754: test: Remove unused cs_main a Haypence token.
Mar 21 2024, 16:09
PiRK accepted D15747: [guix] Always use the same user name in the container.
Mar 21 2024, 10:40

Mar 20 2024

PiRK accepted D15742: [avalanche] Consistently use the default constant when checking for preconsensus.
Mar 20 2024, 17:21
PiRK accepted D15743: [guix] Don't use empty string with git clean.

that works

Mar 20 2024, 15:27
PiRK accepted D15741: [guix] Fix guix-clean on CI.
Mar 20 2024, 14:22
PiRK accepted D15686: [avalanche] Allow for yes-voting several winners.
Mar 20 2024, 09:12
PiRK accepted D15685: [avalanche] Prepare the data structure to hold several staking reward winners.
Mar 20 2024, 09:11
PiRK closed D15740: validationcaches: Use size_t for sizes.
Mar 20 2024, 07:17
PiRK committed rABC3e9bd73fad12: validationcaches: Use size_t for sizes (authored by Carl Dong <contact@carldong.me>).
validationcaches: Use size_t for sizes
Mar 20 2024, 07:17

Mar 19 2024

PiRK closed D15738: validationcaches: Add and use ValidationCacheSizes.
Mar 19 2024, 16:21
PiRK closed D15737: cuckoocache: Check for uint32 overflow in setup_bytes.
Mar 19 2024, 16:21
PiRK closed D15736: validationcaches: Abolish arbitrary limit.
Mar 19 2024, 16:21
PiRK committed rABCe80abca4f815: validationcaches: Add and use ValidationCacheSizes (authored by Carl Dong <contact@carldong.me>).
validationcaches: Add and use ValidationCacheSizes
Mar 19 2024, 16:21
PiRK committed rABCab5c81a17032: cuckoocache: Check for uint32 overflow in setup_bytes (authored by Carl Dong <contact@carldong.me>).
cuckoocache: Check for uint32 overflow in setup_bytes
Mar 19 2024, 16:21
PiRK committed rABCf2314681f2d4: validationcaches: Abolish arbitrary limit (authored by Carl Dong <contact@carldong.me>).
validationcaches: Abolish arbitrary limit
Mar 19 2024, 16:21
PiRK closed D15734: tests: Reduce calls to InitS*Cache().
Mar 19 2024, 16:21
PiRK closed D15735: cuckoocache: Return approximate memory size.
Mar 19 2024, 16:21
PiRK committed rABC7b417a053e6f: cuckoocache: Return approximate memory size (authored by Carl Dong <contact@carldong.me>).
cuckoocache: Return approximate memory size
Mar 19 2024, 16:21
PiRK committed rABC06fe55382386: tests: Reduce calls to InitS*Cache() (authored by Carl Dong <contact@carldong.me>).
tests: Reduce calls to InitS*Cache()
Mar 19 2024, 16:21
PiRK closed D15733: [test] remove unneeded InitScriptExecutionCache.
Mar 19 2024, 16:21
PiRK committed rABC8c3a652ab918: [test] remove unneeded InitScriptExecutionCache (authored by PiRK).
[test] remove unneeded InitScriptExecutionCache
Mar 19 2024, 16:21
PiRK updated the diff for D15740: validationcaches: Use size_t for sizes.

remove unused line

Mar 19 2024, 15:04
PiRK planned changes to D15740: validationcaches: Use size_t for sizes.

?!

Mar 19 2024, 15:01
PiRK requested review of D15740: validationcaches: Use size_t for sizes.
Mar 19 2024, 14:56
PiRK updated the diff for D15738: validationcaches: Add and use ValidationCacheSizes.

fix rebase issue (resulted of splitting of error message in init.cpp in D15735 and partially fixing the resulting conflict)

Mar 19 2024, 14:13
PiRK updated the test plan for D15734: tests: Reduce calls to InitS*Cache().
Mar 19 2024, 13:58
PiRK planned changes to D15738: validationcaches: Add and use ValidationCacheSizes.

I broke something during the rebase

Mar 19 2024, 13:57
PiRK accepted D15739: [cmake] Explicitely exclude the CI build directory from the source package.
Mar 19 2024, 13:42
PiRK updated the summary of D15738: validationcaches: Add and use ValidationCacheSizes.
Mar 19 2024, 12:50
PiRK requested review of D15738: validationcaches: Add and use ValidationCacheSizes.
Mar 19 2024, 12:47
PiRK requested review of D15737: cuckoocache: Check for uint32 overflow in setup_bytes.
Mar 19 2024, 12:42
PiRK requested review of D15736: validationcaches: Abolish arbitrary limit.
Mar 19 2024, 12:39
PiRK updated the diff for D15735: cuckoocache: Return approximate memory size.

split the error log for InitSignatureCache and InitScriptExecutionCache (in Bitcoin ABC they are deifferent args)

Mar 19 2024, 12:37
PiRK requested review of D15735: cuckoocache: Return approximate memory size.
Mar 19 2024, 12:32
PiRK requested review of D15734: tests: Reduce calls to InitS*Cache().
Mar 19 2024, 12:31
PiRK updated the diff for D15733: [test] remove unneeded InitScriptExecutionCache.

rebase

Mar 19 2024, 12:29
PiRK requested review of D15733: [test] remove unneeded InitScriptExecutionCache.
Mar 19 2024, 12:25
PiRK accepted D15732: [e.cash] Add link to Devs and builders Telegram group on Developers page.
Mar 19 2024, 07:52
PiRK accepted D15730: [chronik] Make chronik_serve bind once to the same ip.

Otherwise LGTM, except for the confusing summary.

Mar 19 2024, 07:50
PiRK added a comment to D15730: [chronik] Make chronik_serve bind once to the same ip.

The datadir always adds a binding to 127.0.0.1 which is not what the test is expecting.

Mar 19 2024, 07:50

Mar 18 2024

PiRK accepted D15725: Bump version to 0.28.12.
Mar 18 2024, 16:23
PiRK closed D15724: Move {Load,Dump}Mempool to kernel namespace.
Mar 18 2024, 15:17
PiRK closed D15721: test/fuzz: Invoke LoadMempool via Chainstate.
Mar 18 2024, 15:17
PiRK committed rABC6abd8113c18c: Move {Load,Dump}Mempool to kernel namespace (authored by Carl Dong <contact@carldong.me>).
Move {Load,Dump}Mempool to kernel namespace
Mar 18 2024, 15:17
PiRK closed D15722: LoadMempool: Pass in load_path, stop using gArgs.
Mar 18 2024, 15:17