Page MenuHomePhabricator
Feed Advanced Search

Sep 4 2024

emack closed D16711: [Cashtab] Patch airdrop blank screen bug.
Sep 4 2024, 09:31
emack committed rABC883ad6210b2f: [Cashtab] Patch airdrop blank screen bug (authored by emack).
[Cashtab] Patch airdrop blank screen bug
Sep 4 2024, 09:30
emack updated the diff for D16711: [Cashtab] Patch airdrop blank screen bug.

version bump

Sep 4 2024, 09:14
emack requested review of D16711: [Cashtab] Patch airdrop blank screen bug.
Sep 4 2024, 01:39
emack requested changes to D16710: [chronik-client] Version bump to publish non-nng chronik-client.
Sep 4 2024, 01:09
emack accepted D16709: [token-server] Bump XEC reward.
Sep 4 2024, 01:01

Aug 31 2024

emack added inline comments to D16699: Update chronik documentation after NNG deprecation.
Aug 31 2024, 15:49
emack requested changes to D16699: Update chronik documentation after NNG deprecation.
  • I did a quick grep and there's no documentation on the chronik.lokadId() API, which is exclusively on in-node chronik?
  • Maybe outside the scope of this diff, but can do with a production considerations section that talks to the various production challenges e.g. retrieving an address' history since inception can be tricky, as it's typically larger than the max number of pages retrievable per API call (200 pages). In which case the doc should recommend retrieving the first page so you get the numPages property which can be used to then work out the appropriate history pagination or to loop through and build up an array of promises for concurrent execution.
Aug 31 2024, 15:40
emack accepted D16698: [token-server] Bump rate limit window to one hour.
Aug 31 2024, 01:23

Aug 30 2024

emack accepted D16697: [token-server] Implement rate limiting by IP.
Aug 30 2024, 14:49

Aug 29 2024

emack accepted D16344: [alias-server] Migrate to in-node chronik-client.

minor nit

Aug 29 2024, 04:42

Aug 17 2024

emack added a comment to D16660: [dependencies] Patch checksum for nodesetup.h.

@bot ecash-herald-tests

Aug 17 2024, 05:11
emack accepted D16661: [Cashtab] Display some ideas for how to use a new amount of XEC.

Minor nit

Aug 17 2024, 05:10
emack accepted D16656: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient.
Aug 17 2024, 05:07

Aug 16 2024

emack closed D16558: [Cashtab] Render paywall id directly as hex.
Aug 16 2024, 03:55
emack committed rABCca773975d162: [Cashtab] Render paywall id directly as hex (authored by emack).
[Cashtab] Render paywall id directly as hex
Aug 16 2024, 03:55
emack updated the diff for D16558: [Cashtab] Render paywall id directly as hex.

version bump

Aug 16 2024, 01:55
emack updated the summary of D16558: [Cashtab] Render paywall id directly as hex.
Aug 16 2024, 01:53
emack updated the summary of D16558: [Cashtab] Render paywall id directly as hex.
Aug 16 2024, 01:50
emack accepted D16657: [ecash-agora] Replace legacy ChronikClientNode with ChronikClient.
Aug 16 2024, 01:35
emack requested changes to D16656: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient.

Are these the equivalent of node_module files for react apps and can be ignored?

image.png (89×1 px, 28 KB)

Aug 16 2024, 01:30
emack accepted D16655: [Cashtab] ChronikClientNode to ChronikClient.

grep should be grep -r ChronikClientNode src/ otherwise it'll return all the ChronikClientNode references in node_modules

Aug 16 2024, 01:26
emack accepted D16653: [ecash-herald] Replace ChronikClientNode with ChronikClient.
Aug 16 2024, 01:21
emack accepted D16654: [token-server] Replace references to ChronikClientNode with ChronikClient.
Aug 16 2024, 01:20

Aug 15 2024

emack requested changes to D16654: [token-server] Replace references to ChronikClientNode with ChronikClient.

Just so I'm understanding this correctly, there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path? But external apps using the chronik-client will right?

Aug 15 2024, 23:43
emack added a comment to D16654: [token-server] Replace references to ChronikClientNode with ChronikClient.

Just so I'm understanding this correctly, there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path? But external apps using the chronik-client will right?

Aug 15 2024, 23:29
emack closed D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.
Aug 15 2024, 08:14
emack committed rABC0ce298120039: [ecash-herald] Update parseOpReturn to recognize authentication txs (authored by emack).
[ecash-herald] Update parseOpReturn to recognize authentication txs
Aug 15 2024, 08:14
emack updated the diff for D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.

Rebase to master and version bump

Aug 15 2024, 07:30
emack closed D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.
Aug 15 2024, 07:19
emack committed rABC1415a0b02a29: [ecash-herald] Update parseOpReturn to recognize paywall payments (authored by emack).
[ecash-herald] Update parseOpReturn to recognize paywall payments
Aug 15 2024, 07:19

Aug 14 2024

emack added inline comments to D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.
Aug 14 2024, 13:11
emack updated the diff for D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.

Updated with on-spec but empty identifier condition

Aug 14 2024, 13:11
emack added a comment to D16627: [chronik client + ecash-herald + token-server + cashtab + ecash-lib + ecash-agora] Deprecate NNG support from chronik-client.

We probably need some comms on this along the lines of:

  1. next version is a breaking change for apps using NNG
  2. For existing in-node apps, refactor all references to ChronikClientNode to be ChronikClient
  3. For existing NNG powered apps, keep in mind changes a, b, c...... e.g. using address.history() going forward instead of script.history()
Aug 14 2024, 07:50
emack closed D16625: Add dust tx authentication prefix to standards doc.
Aug 14 2024, 05:02
emack committed rABCb05a734b5c0d: Add dust tx authentication prefix to standards doc (authored by emack).
Add dust tx authentication prefix to standards doc
Aug 14 2024, 05:02
emack closed D16626: [Explorer] Update readme with additional dependency.
Aug 14 2024, 04:21
emack committed rABCb1cbec841bc7: [Explorer] Update readme with additional dependency (authored by emack).
[Explorer] Update readme with additional dependency
Aug 14 2024, 04:21
emack added a comment to D16625: Add dust tx authentication prefix to standards doc.

beyond the scope of this diff -- but why different lokad id for all of these things that are different functions of ecashchat?

Aug 14 2024, 04:19
emack updated the diff for D16625: Add dust tx authentication prefix to standards doc.

Updated author

Aug 14 2024, 04:19
emack added inline comments to D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.
Aug 14 2024, 01:58
emack updated the diff for D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.

Updated to parse hex article txids and updated off spec messaging

Aug 14 2024, 01:58
emack added inline comments to D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.
Aug 14 2024, 01:04
emack updated the diff for D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.

Updated rendered messages

Aug 14 2024, 01:04
emack updated the diff for D16626: [Explorer] Update readme with additional dependency.

Updated dependency

Aug 14 2024, 00:53
emack updated the summary of D16625: Add dust tx authentication prefix to standards doc.
Aug 14 2024, 00:52
emack updated the diff for D16625: Add dust tx authentication prefix to standards doc.

Updated author and payload labelling

Aug 14 2024, 00:46
emack added a comment to D16625: Add dust tx authentication prefix to standards doc.

is there any expected byte length here? what makes it unique? what happens if someone starts broadcasting clones of these txs ... there's no way to guarantee this is unique since it is public.

Aug 14 2024, 00:46

Aug 12 2024

emack requested review of D16626: [Explorer] Update readme with additional dependency.
Aug 12 2024, 15:03
emack accepted D16606: [explorer] Add copy paste button for addresses on transaction page.
Aug 12 2024, 14:59
emack requested review of D16625: Add dust tx authentication prefix to standards doc.
Aug 12 2024, 14:47
emack updated the diff for D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.

Updated authentication tx msg and added reference to spec

Aug 12 2024, 14:41
emack added inline comments to D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.
Aug 12 2024, 14:30
emack updated the diff for D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.

Updated article paywall render to be an explorer link, removed invalid article id renders and added reference to spec.

Aug 12 2024, 14:29
emack requested review of D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.
Aug 12 2024, 05:33
emack requested review of D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.
Aug 12 2024, 05:11
emack closed D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.
Aug 12 2024, 04:06
emack committed rABCdd17b5dae543: [Cashtab] Update tx history to parse eCashChat authentication txs (authored by emack).
[Cashtab] Update tx history to parse eCashChat authentication txs
Aug 12 2024, 04:06
emack updated the diff for D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.

version bump

Aug 12 2024, 04:01
emack added inline comments to D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.
Aug 12 2024, 03:59
emack accepted D16621: Update Telegram link on apps/examples/readme.
Aug 12 2024, 01:49

Aug 11 2024

emack added inline comments to D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.
Aug 11 2024, 14:48
emack updated the diff for D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.

Updated comments

Aug 11 2024, 14:48
emack requested changes to D16606: [explorer] Add copy paste button for addresses on transaction page.

Clicking the copy icon for txid at the top gives this

image.png (103×527 px, 9 KB)

Aug 11 2024, 12:31
emack added a comment to D16606: [explorer] Add copy paste button for addresses on transaction page.

@bot preview-explorer

Aug 11 2024, 12:27
emack published D16620: [Cashtab] Update tx history to parse eCashChat authentication txs for review.
Aug 11 2024, 12:26
emack accepted D16618: [mock-chronik-client] Add diff to change log.
Aug 11 2024, 12:20

Aug 9 2024

emack requested changes to D16606: [explorer] Add copy paste button for addresses on transaction page.
Aug 9 2024, 04:37
emack accepted D16555: [token-server] Implement ecash-lib for tx building.
Aug 9 2024, 04:30

Aug 2 2024

emack closed D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.
Aug 2 2024, 05:00
emack committed rABC9975eba9a1ed: [Cashtab] Update TxHistory to recognize article post and article reply txs from… (authored by emack).
[Cashtab] Update TxHistory to recognize article post and article reply txs from…
Aug 2 2024, 05:00

Jul 31 2024

emack planned changes to D16558: [Cashtab] Render paywall id directly as hex.
Jul 31 2024, 09:56
emack published D16558: [Cashtab] Render paywall id directly as hex for review.
Jul 31 2024, 09:49

Jul 30 2024

emack updated the diff for D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.

version bump

Jul 30 2024, 14:12
emack closed D16553: [Cashtab] Reinstate paywall article link.
Jul 30 2024, 14:08
emack committed rABC838ac730812e: [Cashtab] Reinstate paywall article link (authored by emack).
[Cashtab] Reinstate paywall article link
Jul 30 2024, 14:08
emack updated the diff for D16553: [Cashtab] Reinstate paywall article link.

version bump

Jul 30 2024, 14:04
emack updated the diff for D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.

Added stackArray size check and updated int tests

Jul 30 2024, 14:00
emack published D16553: [Cashtab] Reinstate paywall article link for review.
Jul 30 2024, 13:34
emack accepted D16328: [Cashtab] Support NFT trading.

Accepted subject to a decision on plugin use vs current implementation

Jul 30 2024, 06:00

Jul 26 2024

emack requested changes to D16328: [Cashtab] Support NFT trading.

On a semi related note, not for this diff, but if you try to use a non-jpg/png file (e.g. webp) for the NFT collection it crashes the app (blank white screen), with the console spitting out TypeError: Cannot read properties of undefined (reading 'size').

Jul 26 2024, 15:27

Jul 25 2024

emack added inline comments to D16328: [Cashtab] Support NFT trading.
Jul 25 2024, 23:55

Jul 22 2024

emack abandoned D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 21:32
emack planned changes to D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 13:45
emack added inline comments to D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 13:34
emack updated the diff for D16516: [Cashtab] Add maintenance mode with config toggle.

Moved maintenance toggle to .env, removed ETA in messaging and the unnecessary reference to funds

Jul 22 2024, 13:33
emack planned changes to D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 12:23
emack updated the diff for D16516: [Cashtab] Add maintenance mode with config toggle.

Updated message

Jul 22 2024, 12:22
emack published D16516: [Cashtab] Add maintenance mode with config toggle for review.
Jul 22 2024, 12:17
emack closed D16514: [Cashtab] version bump for D16513.
Jul 22 2024, 08:59
emack committed rABC699f81ab9e63: [Cashtab] version bump for D16513 (authored by emack).
[Cashtab] version bump for D16513
Jul 22 2024, 08:59
emack requested review of D16514: [Cashtab] version bump for D16513.
Jul 22 2024, 08:52
emack closed D16513: [Cashtab] Remove article hyperlink.
Jul 22 2024, 08:21
emack committed rABC8477ea119600: [Cashtab] Remove article hyperlink (authored by emack).
[Cashtab] Remove article hyperlink
Jul 22 2024, 08:21
emack published D16513: [Cashtab] Remove article hyperlink for review.
Jul 22 2024, 08:20

Jul 21 2024

emack published D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat for review.
Jul 21 2024, 16:12
emack accepted D16511: [Cashtab] Update README to reflect current deployment requirements.
Jul 21 2024, 03:32
emack added a comment to D16510: [Cashtab] Patch dockerfile to build ecash-agora correctly.

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

Jul 21 2024, 01:58
emack accepted D16510: [Cashtab] Patch dockerfile to build ecash-agora correctly.

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

Jul 21 2024, 01:55

Jul 20 2024

emack accepted D16509: [Cashtab] Show option to claim token reward from Home page if wallet is new.

Accepted with minor nit

Jul 20 2024, 15:09