fix !

remove GetNextOp, rename some functions to map more closely to what they do

@bot build-bench build-fuzzer

Updated the summary to avoid confusion, fixed the typo and added a comment about the rejected finalized tx being a safety net

oxford commas ftw

nice -- cool design, on top of being much better thant what we have at the moment

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41496 for the next 60 minutes.

@bot preview-e.cash

A lot of complexity here. I'm not sure it's possible to really get what is going on without creating and taking offers. However, also important to limit the scope of the diff where its practical. So here, the tests confirm expected txs are made (tho the txs themselves are not really human-readable...at least not by this reviewer).

rebase onto D16754.

rebase onto D16753.

rebase onto D16745.

rebase onto D16743

rebase on master

Remove unecessary header

Rebase on D16767

remove rebase-related double change

Improve display of NFTs by showing only available-to-buy or available-to-manage, with no separate scrollable panel

exposing CastToBool is not needed

add tests, refactor a bit

let's add some tests

Will add unit tests for GetTx and GetConflictTx, and maybe split this out

add missing headers

fix assertion for index vs len(hashes), and also assert that len(hashes) is strictly larger than 0

Minor nit

In D16763#380097, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <Token /> available actions rendered We can send an SLP1 NFT ======
Error: expect(received).toHaveProperty(path, value)

Expected path: "checked"

Expected value: true
Received value: false
    at Object.toHaveProperty (/work/cashtab/src/components/Etokens/__tests__/TokenActions.test.js:829:34)

Each failure log is accessible here:
CashTab Unit Tests: <Token /> available actions rendered We can send an SLP1 NFT

will split out the "quick fix" stuff. the other issues here need refactors.

When loading the NFT component it is complaining of a type error. Only appears on this diff and not on master.

This has a weird double-scroll behavior. Isn't just simpler to just put all the stuff in cashtab and let the browser handle the scrolling?