Page MenuHomePhabricator
Feed Advanced Search

Mon, Nov 4

Fabien requested review of D17068: [avalanche] Always print the finalization messages.
Mon, Nov 4, 14:06
Fabien closed D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 10:06
Fabien committed rABC346ecaef2c58: Deprecate the address_type field of the getnewaddress RPC (authored by Fabien).
Deprecate the address_type field of the getnewaddress RPC
Mon, Nov 4, 10:06
Fabien closed D17066: Bump version to 0.30.4.
Mon, Nov 4, 10:06
Fabien committed rABC486094e3a645: Bump version to 0.30.4 (authored by Fabien).
Bump version to 0.30.4
Mon, Nov 4, 10:06
Fabien updated the summary of D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 09:40
Fabien requested review of D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 09:30
Fabien requested review of D17066: Bump version to 0.30.4.
Mon, Nov 4, 08:58

Fri, Nov 1

Fabien accepted D17058: Fix lock order inversion in promoteStakeContendersToTip.
Fri, Nov 1, 21:59
Fabien added a comment to D17058: Fix lock order inversion in promoteStakeContendersToTip.

@bot build-tsan

Fri, Nov 1, 21:18
Fabien added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Fri, Nov 1, 13:27
Fabien accepted D17057: [ecash-herald] Patch axios syntax bug in getNextStakingReward.

Good catch !

Fri, Nov 1, 13:25

Thu, Oct 31

Fabien accepted D17027: [avalanche] Promote stake contenders when the chain tip updates.
Thu, Oct 31, 07:29

Wed, Oct 30

Fabien closed D17040: [herald] Always print the staking reward winner for invalidated blocks.
Wed, Oct 30, 08:54
Fabien committed rABC6fccffff629a: [herald] Always print the staking reward winner for invalidated blocks (authored by Fabien).
[herald] Always print the staking reward winner for invalidated blocks
Wed, Oct 30, 08:54

Tue, Oct 29

Fabien requested changes to D17027: [avalanche] Promote stake contenders when the chain tip updates.

back to your queue

Tue, Oct 29, 20:22
Fabien requested review of D17040: [herald] Always print the staking reward winner for invalidated blocks.
Tue, Oct 29, 20:18
Fabien accepted D17039: [explorer] chronik back to 2.
Tue, Oct 29, 19:24
Fabien accepted D17038: [explorer] swap to chronik 1.
Tue, Oct 29, 18:52
Fabien closed D17033: [CI] Fix windows tests.
Tue, Oct 29, 14:38
Fabien committed rABC03eef8eae483: [CI] Fix windows tests (authored by Fabien).
[CI] Fix windows tests
Tue, Oct 29, 14:38
teamcity awarded D17033: [CI] Fix windows tests a Haypence token.
Tue, Oct 29, 11:57
Fabien added a comment to D17033: [CI] Fix windows tests.

@bot build-win64

Tue, Oct 29, 11:57
Fabien updated the diff for D17033: [CI] Fix windows tests.

Don't install the packaged version anymore

Tue, Oct 29, 11:57
Fabien requested review of D17033: [CI] Fix windows tests.
Tue, Oct 29, 11:56
Fabien closed D17032: build: GCC-12 build improvements.
Tue, Oct 29, 10:20
Fabien committed rABC1861b9e766c5: build: GCC-12 build improvements (authored by fanquake <fanquake@gmail.com>).
build: GCC-12 build improvements
Tue, Oct 29, 10:20
Fabien closed D17031: [CI] Fix the check source control tools build.
Tue, Oct 29, 10:20
Fabien committed rABCd5463a37394e: [CI] Fix the check source control tools build (authored by Fabien).
[CI] Fix the check source control tools build
Tue, Oct 29, 10:20
Fabien requested changes to D17027: [avalanche] Promote stake contenders when the chain tip updates.
Tue, Oct 29, 09:06
Fabien accepted D17024: [avalanche] Add stake contender cache to avalanche processor.
Tue, Oct 29, 08:56
teamcity awarded D17032: build: GCC-12 build improvements a Haypence token.
Tue, Oct 29, 08:36
Fabien added a comment to D17032: build: GCC-12 build improvements.

@bot build-linux64

Tue, Oct 29, 08:36
Fabien requested review of D17032: build: GCC-12 build improvements.
Tue, Oct 29, 08:35
Fabien requested review of D17031: [CI] Fix the check source control tools build.
Tue, Oct 29, 08:06

Mon, Oct 28

Fabien accepted D17025: [avalanche] Fix contender cache isEmpty return type.
Mon, Oct 28, 22:00
Fabien requested changes to D17024: [avalanche] Add stake contender cache to avalanche processor.

Back to your queue

Mon, Oct 28, 19:44
Fabien closed D17022: [CI] Prepare to use Debian Bookworm.
Mon, Oct 28, 19:39
Fabien committed rABC7a3f74be1241: [CI] Prepare to use Debian Bookworm (authored by Fabien).
[CI] Prepare to use Debian Bookworm
Mon, Oct 28, 19:39
Fabien closed D17021: [chronik] Fix flaky pugin integration test.
Mon, Oct 28, 19:38
Fabien committed rABCa8f59556e55a: [chronik] Fix flaky pugin integration test (authored by Fabien).
[chronik] Fix flaky pugin integration test
Mon, Oct 28, 19:38
Fabien requested review of D17022: [CI] Prepare to use Debian Bookworm.
Mon, Oct 28, 13:14
Fabien requested review of D17021: [chronik] Fix flaky pugin integration test.
Mon, Oct 28, 13:13

Oct 27 2024

Fabien accepted D17002: [Cashtab] Do not render empty parentheses for tickerless tokens in tx history.
Oct 27 2024, 19:55
Fabien accepted D17018: [Cashtab] Update agora blacklist with raipay scam.

This is not sustainable

Oct 27 2024, 13:21

Oct 26 2024

Fabien accepted D17015: [Cashtab] Attempt to patch agora-crashing bug.
Oct 26 2024, 18:54
Fabien added inline comments to D17015: [Cashtab] Attempt to patch agora-crashing bug.
Oct 26 2024, 18:48
Fabien accepted D17014: [Cashtab] Fix bug in agora tx parsing.
Oct 26 2024, 18:45
Fabien closed D17013: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it.
Oct 26 2024, 18:20
Fabien committed rABCb20de2fca342: wallet: avoid returning a reference to vMasterKey after releasing the mutex… (authored by Vasil Dimov <vd@FreeBSD.org>).
wallet: avoid returning a reference to vMasterKey after releasing the mutex…
Oct 26 2024, 18:20
Fabien closed D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 18:20
Fabien committed rABC3ab65b20c797: ArgsManager: return path by value from GetBlocksDirPath() (authored by Vasil Dimov <vd@FreeBSD.org>).
ArgsManager: return path by value from GetBlocksDirPath()
Oct 26 2024, 18:20
Fabien requested review of D17013: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it.
Oct 26 2024, 12:30
Fabien requested review of D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 12:09
Fabien accepted D17009: [CONTRIBUTING.md] Update webdev versions.
Oct 26 2024, 11:01
Fabien closed D17006: Bump our clang toolchain to version 16.
Oct 26 2024, 10:05
Fabien committed rABCe50d1ee720e0: Bump our clang toolchain to version 16 (authored by Fabien).
Bump our clang toolchain to version 16
Oct 26 2024, 10:05
Fabien closed D17004: [CI] Properly pass the cflags in the secp256k1 c++ test.
Oct 26 2024, 10:05
Fabien committed rABC019781ae84f5: [CI] Properly pass the cflags in the secp256k1 c++ test (authored by Fabien).
[CI] Properly pass the cflags in the secp256k1 c++ test
Oct 26 2024, 10:05

Oct 25 2024

Fabien published D17006: Bump our clang toolchain to version 16 for review.
Oct 25 2024, 21:21
teamcity awarded D17006: Bump our clang toolchain to version 16 a Haypence token.
Oct 25 2024, 20:46
Fabien requested review of D17004: [CI] Properly pass the cflags in the secp256k1 c++ test.
Oct 25 2024, 19:23
Fabien requested changes to D16992: [avalanche] Start populating the staking contender cache.

This can be split into several parts:

  • Automate the stake contenders promotion via updatedBlockTip()
  • Add the manual winners to the cache
  • Vote on manual winners
Oct 25 2024, 13:02
Fabien added a comment to D16992: [avalanche] Start populating the staking contender cache.

@bot build-tsan

Oct 25 2024, 13:01
Fabien requested changes to D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file.
Oct 25 2024, 12:37
Fabien requested changes to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

I still don't get what you're doing with the test. Look at the scriptnum10 purpose: it's an older implementation and is here to check the new implementation behaves the same.
Your change is breaking that expectation, deliberately. To check if this introduces a problem:

  • You need to make sure opcodes are well covered by existing tests, including edge cases. I suggest you add these tests if they don't already exist in another diff to prove this one introduces no change in behavior.
  • Just remove that legacy compliant test, which is no longer relevant exactly because of that change.
Oct 25 2024, 12:21
Fabien requested changes to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 25 2024, 08:15

Oct 24 2024

Fabien closed D16989: [explorer] Show the correct unit in the faucet.
Oct 24 2024, 18:57
Fabien committed rABCa355cc677892: [explorer] Show the correct unit in the faucet (authored by Fabien).
[explorer] Show the correct unit in the faucet
Oct 24 2024, 18:56
teamcity awarded D16989: [explorer] Show the correct unit in the faucet a Haypence token.
Oct 24 2024, 18:43
Fabien added a comment to D16989: [explorer] Show the correct unit in the faucet.

@bot preview-explorer

Oct 24 2024, 18:43
Fabien requested review of D16989: [explorer] Show the correct unit in the faucet.
Oct 24 2024, 18:42
Fabien closed D16987: [explorer] Update the url of the testnet faucet.
Oct 24 2024, 18:29
Fabien committed rABC51b9df735b66: [explorer] Update the url of the testnet faucet (authored by Fabien).
[explorer] Update the url of the testnet faucet
Oct 24 2024, 18:29
Fabien requested review of D16987: [explorer] Update the url of the testnet faucet.
Oct 24 2024, 14:00
Fabien closed D16985: [CI] Remove PPA package for Ubuntu 20.04 Focal.
Oct 24 2024, 13:57
Fabien committed rABC0e98326c7596: [CI] Remove PPA package for Ubuntu 20.04 Focal (authored by Fabien).
[CI] Remove PPA package for Ubuntu 20.04 Focal
Oct 24 2024, 13:57
Fabien closed D16978: [CI] Deploy nodejs on Debian Bookworm.
Oct 24 2024, 13:56
Fabien committed rABC7886dfa67a11: [CI] Deploy nodejs on Debian Bookworm (authored by Fabien).
[CI] Deploy nodejs on Debian Bookworm
Oct 24 2024, 13:56
Fabien closed D16976: [faucet] Allow to retry upon request failure.
Oct 24 2024, 13:35
Fabien committed rABC9856864d5e0e: [faucet] Allow to retry upon request failure (authored by Fabien).
[faucet] Allow to retry upon request failure
Oct 24 2024, 13:35
Fabien closed D16979: [faucet] Add a docker config for the faucet.
Oct 24 2024, 13:32
Fabien committed rABC4d927831191e: [faucet] Add a docker config for the faucet (authored by Fabien).
[faucet] Add a docker config for the faucet
Oct 24 2024, 13:32
Fabien closed D16984: [secp256k1] Fix the Cirrus build.
Oct 24 2024, 13:31
Fabien committed rABCa9cf47a326c1: [secp256k1] Fix the Cirrus build (authored by Fabien).
[secp256k1] Fix the Cirrus build
Oct 24 2024, 13:31
Fabien requested review of D16985: [CI] Remove PPA package for Ubuntu 20.04 Focal.
Oct 24 2024, 13:31
Fabien requested review of D16984: [secp256k1] Fix the Cirrus build.
Oct 24 2024, 13:17
Fabien accepted D16981: [CI] Update build-configurations with secp256k1 dependencies.
Oct 24 2024, 12:43
Fabien updated the diff for D16979: [faucet] Add a docker config for the faucet.

Rebase

Oct 24 2024, 12:32
Fabien updated the diff for D16978: [CI] Deploy nodejs on Debian Bookworm.

Rebase

Oct 24 2024, 12:30
Fabien accepted D16983: [Cashtab + token-server + ecash-lib] Copy src/secp256k1 in docker container.
Oct 24 2024, 12:28
Fabien closed D16977: [CI] Include ecash-secp256k1 in the docker builds.
Oct 24 2024, 11:58
Fabien committed rABC0fb0091228c1: [CI] Include ecash-secp256k1 in the docker builds (authored by Fabien).
[CI] Include ecash-secp256k1 in the docker builds
Oct 24 2024, 11:58
Fabien accepted D16982: [Iguana] Display empty stack items as `""`.
Oct 24 2024, 11:23
Fabien accepted D16980: [linter] Fix shebang lint false positive.
Oct 24 2024, 09:29
Fabien requested review of D16979: [faucet] Add a docker config for the faucet.
Oct 24 2024, 08:52
Fabien requested review of D16978: [CI] Deploy nodejs on Debian Bookworm.
Oct 24 2024, 08:50
Fabien requested review of D16977: [CI] Include ecash-secp256k1 in the docker builds.
Oct 24 2024, 08:47
Fabien requested review of D16976: [faucet] Allow to retry upon request failure.
Oct 24 2024, 08:05
Fabien accepted D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
Oct 24 2024, 07:40