Page MenuHomePhabricator
Feed Advanced Search

Nov 6 2024

emack published D17087: [Cashtab] Alternate token icon source for animated images for review.
Nov 6 2024, 13:38
emack accepted D17083: [Cashtab] Add canvas mock to prevent annoying jest debug logs.
Nov 6 2024, 11:33
emack accepted D17081: [Cashtab] Add fn and test cases for agora oneshot fuel inputs.
Nov 6 2024, 11:05
emack requested changes to D17080: [Cashtab] Wallet methods to ts.
Nov 6 2024, 07:37
emack accepted D17084: [Cashtab] Add a jest setup file to avoid repeating global mocks.
Nov 6 2024, 07:30
emack accepted D17079: [Cashtab] Migrate CashtabSettings to ts.
Nov 6 2024, 03:10
emack accepted D17078: [Cashtab] Convert CashtabCache to ts.
Nov 6 2024, 03:06

Nov 5 2024

emack accepted D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 06:24
emack requested changes to D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 04:18

Nov 4 2024

emack accepted D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Nov 4 2024, 00:51
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.
Nov 4 2024, 00:43

Nov 3 2024

emack accepted D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Nov 3 2024, 11:52
emack requested changes to D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
  • the orderbook in manage listings become a "Buy token", which makes sense since you no longer have any offers left, but shouldn't it not be displayed at all?
Nov 3 2024, 11:24
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.

Have verified the merging of orderbooks for the same token offer, though I wasn't getting a duplicate key error in the first place on master (v2.49.1).

Nov 3 2024, 11:18
emack accepted D17060: [ecash-herald] Implement typescript.
Nov 3 2024, 11:03
emack accepted D17062: [token-server] Improve organization of test files.
Nov 3 2024, 10:53

Nov 2 2024

emack accepted D17053: [Cashtab] Implement typescript.
Nov 2 2024, 00:54

Nov 1 2024

emack accepted D17052: [Cashtab] Improved styling for OrderBook.
Nov 1 2024, 00:11
emack accepted D17054: [Cashtab] Lint GoogleAnalytics.js.
Nov 1 2024, 00:06

Oct 31 2024

emack accepted D17055: [Cashtab] Remove debug statement from test file.
Oct 31 2024, 23:30
emack accepted D17051: [Cashtab] Organize OrderBook and styles.
Oct 31 2024, 23:29
emack accepted D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.
Oct 31 2024, 12:11
emack accepted D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 12:05
emack accepted D17050: [token-server] Patch bug in token validation function.
Oct 31 2024, 12:04
emack accepted D17049: [Cashtab] Update bad tokenId validation function.
Oct 31 2024, 11:05
emack requested changes to D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 04:44
emack requested changes to D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.

http://localhost:3000/#/token/ just renders a blank page with the header - perhaps default to / route?.

Oct 31 2024, 04:17
emack accepted D17044: [Cashtab] Improve bignumber parsing for token agora.
Oct 31 2024, 02:58

Oct 30 2024

emack requested changes to D17044: [Cashtab] Improve bignumber parsing for token agora.

And perhaps for another diff, add a Max button to buy the full offer?

Oct 30 2024, 12:21
emack accepted D17041: [token-server] Link token blacklist with icon approval actions.
Oct 30 2024, 06:27
emack accepted D17034: [Cashtab] Add margin to info boxes.
Oct 30 2024, 01:39
emack accepted D17036: [Cashtab] Use token-server blacklist for agora.
Oct 30 2024, 01:37
emack requested changes to D17041: [token-server] Link token blacklist with icon approval actions.
Oct 30 2024, 01:36
emack requested changes to D17036: [Cashtab] Use token-server blacklist for agora.
Oct 30 2024, 01:04
emack accepted D17035: [Cashtab] Remove repeated and unnecessary specialized styled component.
Oct 30 2024, 00:56
emack accepted D17042: [Cashtab] Use ABC chronik first.
Oct 30 2024, 00:50

Oct 29 2024

emack accepted D17020: [token-server] Add database and initialize blacklist endpoints.
Oct 29 2024, 13:16
emack added a comment to D17005: [Cashtab] Upgrade existing token page to show trading info and display tokens the user does not hold.

image.png (1×329 px, 60 KB)

This is pretty unsightly - can you separate the orderbook in its own Buy Alita toggle?

Oct 29 2024, 12:51
emack requested changes to D17005: [Cashtab] Upgrade existing token page to show trading info and display tokens the user does not hold.

More than half the diff seems to be linting changes. Can you touch it and lint in a separate diff and then rebase this one?

Oct 29 2024, 12:45
emack accepted D17019: [ecash-herald] Parse agora actions.
Oct 29 2024, 12:26

Oct 28 2024

emack requested changes to D17019: [ecash-herald] Parse agora actions.
Oct 28 2024, 12:39
emack accepted D17017: [Cashtab] Refactor Orderbook to handle more logic.
Oct 28 2024, 11:50

Oct 27 2024

emack requested changes to D17017: [Cashtab] Refactor Orderbook to handle more logic.
Oct 27 2024, 03:25

Oct 26 2024

emack accepted D17016: [Cashtab] Fix agora depth bar fill effect.
Oct 26 2024, 22:34

Oct 25 2024

emack accepted D16998: [Cashtab] Patch cancel vs buy distinction in agora partials.
Oct 25 2024, 08:31
emack accepted D16994: [Cashtab] Patch tx parsing for agora buy/sell/cancel.
Oct 25 2024, 00:18

Oct 24 2024

emack accepted D16975: [Cashtab] Move google analytics id out of monorepo.
Oct 24 2024, 05:37
emack accepted D16972: [Cashtab] Parse agora oneshot buys and sells.
Oct 24 2024, 05:32
emack accepted D16973: [ecash-agora] Catch up changelog for next published version.
Oct 24 2024, 02:07
emack accepted D16974: [ecash-herald] Deprecate block-based daily msgs.
Oct 24 2024, 02:05
emack accepted D16846: [Cashtab] Support agora partial listings, cancels, and buys.
Oct 24 2024, 02:01

Oct 23 2024

emack accepted D16965: [ecash-herald] Send daily summaries based on time (like cron) and not block timestamps.
Oct 23 2024, 14:13
emack requested changes to D16846: [Cashtab] Support agora partial listings, cancels, and buys.

Pretty cool seeing an orderbook on ecash!

Oct 23 2024, 13:36
emack accepted D16961: [ecash-herald] Include price and market summary for 24-hr window.
Oct 23 2024, 04:28
emack accepted D16960: [Cashtab] Parse agora ad prep txs in tx history.
Oct 23 2024, 00:18
emack requested changes to D16960: [Cashtab] Parse agora ad prep txs in tx history.
Oct 23 2024, 00:06

Oct 22 2024

emack accepted D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.
Oct 22 2024, 23:43
emack accepted D16959: [ecash-herald] Parse app txs in daily summaries.
Oct 22 2024, 23:23
emack requested changes to D16959: [ecash-herald] Parse app txs in daily summaries.
Oct 22 2024, 22:56
emack requested changes to D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.
Oct 22 2024, 12:58
emack requested changes to D16846: [Cashtab] Support agora partial listings, cancels, and buys.

WSOD as per tg chat

Oct 22 2024, 12:44
emack accepted D16952: [ecash-agora] Add integration test dev env instructions to README.
Oct 22 2024, 11:37

Oct 20 2024

emack accepted D16942: [Cashtab] Improve input-collecting functions for Agora partial accept and cancel txs.
Oct 20 2024, 11:22
emack accepted D16940: [Cashtab] Patch proptypes for slider.
Oct 20 2024, 06:08
emack accepted D16945: [ecash-herald] Patch bug in daily summary calc.
Oct 20 2024, 06:06

Oct 19 2024

emack accepted D16935: [ecash-herald] Improve logs and bump number of blocks to check for 24 hr window.
Oct 19 2024, 22:41

Oct 18 2024

emack accepted D16931: [ecash-herald] Improve formatting of daily summary msgs.
Oct 18 2024, 15:24
emack accepted D16929: [mock-chronik-client] Extend MockAgora support.
Oct 18 2024, 13:12
emack accepted D16928: [ecash-agora] ts linting in agora.ts.
Oct 18 2024, 13:05
emack requested changes to D16931: [ecash-herald] Improve formatting of daily summary msgs.
Oct 18 2024, 13:02
emack accepted D16927: [Cashtab] Add method for getting agora partial fuel input.
Oct 18 2024, 12:49
emack accepted D16926: [Cashtab] Introduce nanosat to xec conversion functions.
Oct 18 2024, 12:45
emack accepted D16923: [Cashtab] Improve slider components.
Oct 18 2024, 09:58

Oct 17 2024

emack accepted D16914: [ecash-herald] Send daily summaries covering exact 24-hr windows.
Oct 17 2024, 11:38

Oct 16 2024

emack requested changes to D16914: [ecash-herald] Send daily summaries covering exact 24-hr windows.
Oct 16 2024, 06:46

Oct 13 2024

emack accepted D16900: [Cashtab] Update dependencies.
Oct 13 2024, 01:35

Oct 11 2024

emack accepted D16892: [e.cash] Remove ecash-script from build page.
Oct 11 2024, 05:03

Oct 8 2024

emack accepted D16864: [Cashtab] Minimize fees for NFT listing txs.
Oct 8 2024, 11:01

Oct 4 2024

emack accepted D16860: [token-server] log IP addresses of rate limited requests.
Oct 4 2024, 22:54

Oct 3 2024

emack accepted D16849: [ecash-herald] Give Cashtab XEC rewards their own line.
Oct 3 2024, 11:16
emack accepted D16847: [Cashtab] Do not show non-ONESHOT offers on the NFT listings page.
Oct 3 2024, 01:15
emack accepted D16841: [token-server] Make rate limit error cashtab-friendly.
Oct 3 2024, 00:35
emack accepted D16843: [token-server] Adjustments to rate limits.
Oct 3 2024, 00:34
emack accepted D16848: [Cashtab] Add an info log on the NFT listings page.
Oct 3 2024, 00:26
emack requested changes to D16849: [ecash-herald] Give Cashtab XEC rewards their own line.
Oct 3 2024, 00:24

Sep 24 2024

emack accepted D16804: [Cashtab] Do not render parenthesis around non-existent NFT tickers.

Not for this diff but tickers sound like something we should be mandating during token creation. It's an easy alternative to token id to separate identical tokens. But if we do mandate it then it's worth tracking whether a ticker already exist.
I also checked etoken creation and it's not mandated there either.

Sep 24 2024, 03:16

Sep 19 2024

emack added inline comments to D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.
Sep 19 2024, 03:19

Sep 18 2024

emack accepted D16777: [chronik.e.cash] Use array implementation in examples.
Sep 18 2024, 14:29
emack accepted D16750: [chronik.e.cash] Update chronik-client in docs.

accepted with minor nits

Sep 18 2024, 05:52
emack accepted D16775: [Cashtab] Filter token list by token type.
Sep 18 2024, 05:45
emack accepted D16769: [Cashtab] Extend Cashtab bip21 support to cover multiple addresses and amounts.

Following chat on tg, issue was on ecc app side. Extension now testing all ok.

image.png (994×498 px, 71 KB)

Sep 18 2024, 04:52
emack accepted D16774: [Cashtab] Update dependencies.
Sep 18 2024, 02:39
emack requested changes to D16769: [Cashtab] Extend Cashtab bip21 support to cover multiple addresses and amounts.

Desktop and mobile tested all ok via BIP21 url querystring, with different amounts, decimals and addresses

Sep 18 2024, 02:34

Sep 17 2024

emack accepted D16759: [Cashtab] Toggle "buy nfts" and "manage nfts" for better user presentation.
Sep 17 2024, 14:46

Sep 16 2024

emack accepted D16764: [token-server] Tighten rate limits.

Minor nit

Sep 16 2024, 01:10
emack accepted D16762: [Cashtab] Use promise.all to debottleneck NFT offer loadtime.
Sep 16 2024, 01:08

Sep 15 2024

emack accepted D16763: [Cashtab] Do not lock UI while token info is loading on NFT screen.
Sep 15 2024, 13:55

Sep 14 2024

emack accepted D16760: [Cashtab] Show a spinner during loading process.
Sep 14 2024, 15:04
emack accepted D16761: [Cashtab] Prevent horizontal scrolling in NFT panel.
Sep 14 2024, 15:01
emack requested changes to D16759: [Cashtab] Toggle "buy nfts" and "manage nfts" for better user presentation.

When loading the NFT component it is complaining of a type error. Only appears on this diff and not on master.

image.png (122×477 px, 15 KB)

Sep 14 2024, 13:41