Page MenuHomePhabricator
Feed All Stories

Wed, Feb 12

PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Wed, Feb 12, 10:39
PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Wed, Feb 12, 10:36
teamcity awarded D17659: [WIP] CI investigation a Love token.
Wed, Feb 12, 10:35
teamcity awarded D17659: [WIP] CI investigation a Like token.
Wed, Feb 12, 10:25
teamcity awarded D17659: [WIP] CI investigation a Mountain of Wealth token.
Wed, Feb 12, 10:25
teamcity awarded D17659: [WIP] CI investigation a Doubloon token.
Wed, Feb 12, 10:16
teamcity awarded D17659: [WIP] CI investigation a Piece of Eight token.
Wed, Feb 12, 10:14
teamcity awarded D17659: [WIP] CI investigation a Haypence token.
Wed, Feb 12, 10:09
Fabien published D17573: [electrum] Sign stakes using Trezor devices for review.
Wed, Feb 12, 09:46
Fabien updated the diff for D17658: Add a simplifygbt option to simplify parsing the block template for miners.

Use -simplegbt, make the script a constant

Wed, Feb 12, 08:53
Fabien added inline comments to D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Wed, Feb 12, 08:50
Mengerian added a comment to D17658: Add a simplifygbt option to simplify parsing the block template for miners.

How about naming it "-simplegbt" instead... seems simpler

I would argue that it's not simple but only simpler than before.

Wed, Feb 12, 03:13

Tue, Feb 11

roqqit accepted D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Tue, Feb 11, 21:56
Fabien added a comment to D17658: Add a simplifygbt option to simplify parsing the block template for miners.

How about naming it "-simplegbt" instead... seems simpler

Tue, Feb 11, 19:21
Mengerian added a comment to D17658: Add a simplifygbt option to simplify parsing the block template for miners.

How about naming it "-simplegbt" instead... seems simpler

Tue, Feb 11, 19:19
Fabien updated the summary of D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Tue, Feb 11, 19:15
Fabien requested review of D17658: Add a simplifygbt option to simplify parsing the block template for miners.

Is there a reason -simplifygbt is a command line arg and not a parameter to getblocktemplate?

Tue, Feb 11, 19:09
roqqit requested changes to D17658: Add a simplifygbt option to simplify parsing the block template for miners.

Is there a reason -simplifygbt is a command line arg and not a parameter to getblocktemplate?

Tue, Feb 11, 16:32
Fabien updated the summary of D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Tue, Feb 11, 15:08
Fabien updated the diff for D17658: Add a simplifygbt option to simplify parsing the block template for miners.

Rebase and feedback

Tue, Feb 11, 15:08
Fabien committed rABC4d18082f0bad: Bump version to 0.30.11 (authored by Fabien).
Bump version to 0.30.11
Tue, Feb 11, 15:07
Fabien closed D17657: Bump version to 0.30.11.
Tue, Feb 11, 15:07
PiRK closed D17646: wallet: avoid rescans if under the snapshot.
Tue, Feb 11, 14:43
PiRK committed rABC2069f3c76279: wallet: avoid rescans if under the snapshot (authored by James O'Beirne <james.obeirne@gmail.com>).
wallet: avoid rescans if under the snapshot
Tue, Feb 11, 14:43
PiRK added inline comments to D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Tue, Feb 11, 14:42
teamcity closed T3747: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Tue, Feb 11, 14:40
PiRK accepted D17657: Bump version to 0.30.11.
Tue, Feb 11, 14:34
Fabien accepted D17646: wallet: avoid rescans if under the snapshot.
Tue, Feb 11, 14:33
Fabien committed rABC45ecb7b1162e: Temporarly disable the getavaaddr_interval_test (authored by Fabien).
Temporarly disable the getavaaddr_interval_test
Tue, Feb 11, 14:23
Fabien closed D17656: Temporarly disable the getavaaddr_interval_test.
Tue, Feb 11, 14:23
Fabien requested review of D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Tue, Feb 11, 14:22
Fabien requested review of D17657: Bump version to 0.30.11.
Tue, Feb 11, 14:10
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase again

Tue, Feb 11, 14:04
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Tue, Feb 11, 13:36
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

ecash-herald copyright update, ecash-agora camelCase patches, rust proto tighten comment line length

Tue, Feb 11, 13:23
bytesofman added inline comments to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Tue, Feb 11, 13:19
PiRK accepted D17656: Temporarly disable the getavaaddr_interval_test.
Tue, Feb 11, 12:33
Fabien requested review of D17656: Temporarly disable the getavaaddr_interval_test.
Tue, Feb 11, 12:28
tobias_ruck requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Tue, Feb 11, 11:31
PiRK closed D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Tue, Feb 11, 11:28
PiRK committed rABC6db422501d60: [chronik] implement the blockchain.scripthash.get_balance Electrum method (authored by PiRK).
[chronik] implement the blockchain.scripthash.get_balance Electrum method
Tue, Feb 11, 11:28
teamcity triaged T3747: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Tue, Feb 11, 11:17
Fabien closed D17655: test: improve robustness of connect_nodes().
Tue, Feb 11, 11:10
Fabien committed rABCb8637fc6645b: test: improve robustness of connect_nodes() (authored by furszy <matiasfurszyfer@protonmail.com>).
test: improve robustness of connect_nodes()
Tue, Feb 11, 11:10
teamcity added a comment to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Tue, Feb 11, 10:32
PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase, nit

Tue, Feb 11, 10:14
PiRK accepted D17655: test: improve robustness of connect_nodes().
Tue, Feb 11, 09:42
teamcity updated the summary of D17655: test: improve robustness of connect_nodes().
Tue, Feb 11, 09:20
Fabien requested review of D17655: test: improve robustness of connect_nodes().
Tue, Feb 11, 09:20
teamcity closed T3746: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Tue, Feb 11, 09:07
teamcity added a comment to D17646: wallet: avoid rescans if under the snapshot.
Tue, Feb 11, 08:44
teamcity added a comment to D17646: wallet: avoid rescans if under the snapshot.
Tue, Feb 11, 08:41
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase. I'm convinced the feature_assumevalid.py failure is unrelated to this diff

Tue, Feb 11, 08:34
PiRK closed D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Tue, Feb 11, 08:31
PiRK committed rABCdb526ab596e1: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to… (authored by Ryan Ofsky <ryan@ofsky.org>).
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to…
Tue, Feb 11, 08:31
teamcity triaged T3746: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Tue, Feb 11, 07:22
PiRK closed D17651: [electrum] fix output parsing when pay-to field is empty.
Tue, Feb 11, 07:07
PiRK committed rABC1b64fae67afe: [electrum] fix output parsing when pay-to field is empty (authored by SomberNight <somber.night@protonmail.com>).
[electrum] fix output parsing when pay-to field is empty
Tue, Feb 11, 07:07
bytesofman published D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens) for review.
Tue, Feb 11, 04:30

Mon, Feb 10

teamcity closed T3744: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Resolved.
Mon, Feb 10, 17:16
roqqit closed D17615: [avalanche] Add stake contender to AnyVoteItem.
Mon, Feb 10, 17:09
roqqit committed rABC95622f64aac3: [avalanche] Add stake contender to AnyVoteItem (authored by roqqit).
[avalanche] Add stake contender to AnyVoteItem
Mon, Feb 10, 17:09
Fabien accepted D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Mon, Feb 10, 11:23
Fabien accepted D17651: [electrum] fix output parsing when pay-to field is empty.
Mon, Feb 10, 11:20
Fabien accepted D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Mon, Feb 10, 11:19
Fabien requested changes to D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.

See comments from the other reviews. Also why do you need Eyre for in this test ?

Mon, Feb 10, 11:13
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

See the feedback from D17595: remove the debug statements, and rebase. The suggestion from Pierre is also a good one that you should take into account. Otherwise the state machine looks good to me.

Mon, Feb 10, 11:09
Fabien accepted D17615: [avalanche] Add stake contender to AnyVoteItem.
Mon, Feb 10, 11:06
teamcity triaged T3744: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Unbreak Now! priority.
Mon, Feb 10, 08:50
Fabien committed rABCc2a10e94db25: Remove useless timeouts in p2p_timeouts (authored by Fabien).
Remove useless timeouts in p2p_timeouts
Mon, Feb 10, 08:43
Fabien closed D17654: Remove useless timeouts in p2p_timeouts.
Mon, Feb 10, 08:43
Unknown Object (User) added a comment to D16087: [ecash-agora] Add `AgoraOneshot`.
Mon, Feb 10, 06:39

Sun, Feb 9

abc-bot committed rABC71c4c542308f: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Feb 9, 22:16
abc-bot committed rABCb2a9511d4fd1: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Feb 9, 22:08
teamcity closed T3743: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Sun, Feb 9, 21:52
abc-bot committed rABC423af1160782: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, Feb 9, 21:37
teamcity triaged T3743: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Sun, Feb 9, 13:53
PiRK closed D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Sun, Feb 9, 13:41
PiRK committed rABC8fc3de71d547: test: fix test failures in test/functional/p2p_timeouts.py (authored by Jon Atack <jon@atack.com>).
test: fix test failures in test/functional/p2p_timeouts.py
Sun, Feb 9, 13:41
PiRK accepted D17654: Remove useless timeouts in p2p_timeouts.
Sun, Feb 9, 13:39
Fabien added a comment to D17652: test: fix test failures in test/functional/p2p_timeouts.py.

Related: D17654

Sun, Feb 9, 11:21
Fabien accepted D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Sun, Feb 9, 11:20
Fabien requested review of D17654: Remove useless timeouts in p2p_timeouts.
Sun, Feb 9, 11:17

Sat, Feb 8

hazzarust updated the test plan for D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.
Sat, Feb 8, 20:57
hazzarust updated the diff for D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.

lint

Sat, Feb 8, 20:01
hazzarust updated the summary of D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.
Sat, Feb 8, 20:00
hazzarust requested review of D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.
Sat, Feb 8, 19:59
teamcity updated the summary of D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Sat, Feb 8, 17:01
PiRK requested review of D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Sat, Feb 8, 17:01
PiRK updated the test plan for D17651: [electrum] fix output parsing when pay-to field is empty.
Sat, Feb 8, 16:48
PiRK planned changes to D17646: wallet: avoid rescans if under the snapshot.

need to investigate that CI second failure (the first one is clearly unrelated)

Sat, Feb 8, 16:46
PiRK requested review of D17651: [electrum] fix output parsing when pay-to field is empty.
Sat, Feb 8, 16:39
teamcity added a comment to D17646: wallet: avoid rescans if under the snapshot.
Sat, Feb 8, 10:43
teamcity closed T3741: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Sat, Feb 8, 10:42
teamcity added a comment to D17646: wallet: avoid rescans if under the snapshot.
Sat, Feb 8, 10:41
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase

Sat, Feb 8, 10:33
PiRK closed D17645: wallet: make chain optional for CWallet::Create.
Sat, Feb 8, 10:32
PiRK committed rABC95c17f9917b3: wallet: make chain optional for CWallet::Create (authored by Ivan Metlushko <metlushko@gmail.com>).
wallet: make chain optional for CWallet::Create
Sat, Feb 8, 10:32
PiRK closed D17644: CWallet::Create move chain init message up into calling code.
Sat, Feb 8, 10:32
PiRK committed rABCf8e022ee1291: CWallet::Create move chain init message up into calling code (authored by Ivan Metlushko <metlushko@gmail.com>).
CWallet::Create move chain init message up into calling code
Sat, Feb 8, 10:32