Page MenuHomePhabricator
Feed Advanced Search

Feb 25 2019

jasonbcox updated the summary of D2597: Refactor the imports in rpc_* tests.
Feb 25 2019, 19:42
jasonbcox updated the summary of D2597: Refactor the imports in rpc_* tests.
Feb 25 2019, 19:42
jasonbcox accepted D2598: Refactor the imports in wallet_* tests.
Feb 25 2019, 19:04
jasonbcox committed rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee() (authored by jasonbcox).
Cleanup unused confirm target in GetMinimumFee()
Feb 25 2019, 19:02
jasonbcox closed D2588: Cleanup unused confirm target in GetMinimumFee().
Feb 25 2019, 19:01
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 25 2019, 18:58
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Fixed named arguments + added a test for it

Feb 25 2019, 18:57

Feb 22 2019

jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Removed assert_equal_float as it's no longer necessary

Feb 22 2019, 20:34
jasonbcox added inline comments to D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Feb 22 2019, 19:00
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Rebase + don't overengineer casting

Feb 22 2019, 18:52
jasonbcox added a comment to T536: Make nTxConfirmTarget use config instead of being global.

As part of this ticket, investigate to see if -txconfirmtarget is useful at all anymore. It's likely that we can get rid of it entirely.

Feb 22 2019, 18:43 · Bootcamp, Restricted Project
jasonbcox added inline comments to D2588: Cleanup unused confirm target in GetMinimumFee().
Feb 22 2019, 18:43
jasonbcox closed T538: Backport Core PR13554 as Resolved.
Feb 22 2019, 18:36 · Restricted Project
jasonbcox closed T538: Backport Core PR13554, a subtask of T537: Backport Core PR14670, as Resolved.
Feb 22 2019, 18:36 · Restricted Project
jasonbcox committed rABCc9e3c4c329f0: Remove unused argument to ThreadHTTP(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove unused argument to ThreadHTTP(...)
Feb 22 2019, 18:36
jasonbcox closed D2587: Remove unused argument to ThreadHTTP(...).
Feb 22 2019, 18:35
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 22 2019, 01:06
Herald added a reviewer for D2588: Cleanup unused confirm target in GetMinimumFee(): Restricted Project.
Feb 22 2019, 01:06
jasonbcox requested changes to D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Feb 22 2019, 00:46

Feb 21 2019

jasonbcox accepted D2585: [avalanche] Cycle through a set of 8 nodes in multi_block_register test.
Feb 21 2019, 23:54
jasonbcox accepted D2584: [avalanche] Cycle through a set of 8 nodes in block_register test.
Feb 21 2019, 23:44
jasonbcox added a subtask for T541: Backport Core PR10267 to support includeconf: T417: Backport PR10244 from core.
Feb 21 2019, 22:40 · Restricted Project
jasonbcox added a parent task for T417: Backport PR10244 from core: T541: Backport Core PR10267 to support includeconf.
Feb 21 2019, 22:40 · Backport
jasonbcox updated the summary of D2587: Remove unused argument to ThreadHTTP(...).
Feb 21 2019, 22:18
Herald added a reviewer for D2587: Remove unused argument to ThreadHTTP(...): Restricted Project.
Feb 21 2019, 22:11
jasonbcox requested changes to D2557: Add a linter to detect python % format and convert them to use .format().
Feb 21 2019, 21:55
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Fixed logic flow + added assert_equal_float for precision checking

Feb 21 2019, 21:53
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 21 2019, 21:28
jasonbcox committed rABCd2746f81d140: Rotate security GPG key (authored by jasonbcox).
Rotate security GPG key
Feb 21 2019, 19:55
jasonbcox closed D2582: Rotate security GPG key.
Feb 21 2019, 19:55
jasonbcox committed rABC355b1f1d5369: Improve shutdown process (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
Improve shutdown process
Feb 21 2019, 19:54
jasonbcox closed D2544: Improve shutdown process.
Feb 21 2019, 19:54
jasonbcox closed T539: Backport Core PR12366 as Resolved.
Feb 21 2019, 18:49 · Restricted Project
jasonbcox closed T539: Backport Core PR12366, a subtask of T537: Backport Core PR14670, as Resolved.
Feb 21 2019, 18:49 · Restricted Project
jasonbcox committed rABC68a8aec201e4: Merge #12366: http: Join worker threads before deleting work queue (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12366: http: Join worker threads before deleting work queue
Feb 21 2019, 18:47
jasonbcox closed D2547: Merge #12366: http: Join worker threads before deleting work queue.
Feb 21 2019, 18:47
jasonbcox committed rABC3c0491f33cc4: Add bitcoin-qt testing explicitly to the releease process (authored by jasonbcox).
Add bitcoin-qt testing explicitly to the releease process
Feb 21 2019, 18:24
jasonbcox closed D2581: Add bitcoin-qt testing explicitly to the releease process.
Feb 21 2019, 18:23
jasonbcox added a comment to D2582: Rotate security GPG key.

Associated bitcoinabc.org change: https://github.com/Bitcoin-ABC/bitcoinabc.org/pull/47/files

Feb 21 2019, 00:42
Herald added a reviewer for D2582: Rotate security GPG key: Restricted Project.
Feb 21 2019, 00:38

Feb 20 2019

Herald added a reviewer for D2581: Add bitcoin-qt testing explicitly to the releease process: Restricted Project.
Feb 20 2019, 19:44
jasonbcox committed rABC7b6fe604fb1e: Bump version to 0.19.1 (authored by jasonbcox).
Bump version to 0.19.1
Feb 20 2019, 17:32
jasonbcox closed D2580: Bump version to 0.19.1.
Feb 20 2019, 17:31
jasonbcox added a comment to D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.

Macro likestamp:

Feb 20 2019, 01:11
jasonbcox requested changes to D2557: Add a linter to detect python % format and convert them to use .format().
Feb 20 2019, 00:40
jasonbcox updated the summary of D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 20 2019, 00:26
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Added:

  • deprecation facility
  • release notes
  • tests
Feb 20 2019, 00:25

Feb 19 2019

Herald added a reviewer for D2580: Bump version to 0.19.1: Restricted Project.
Feb 19 2019, 23:54
jasonbcox accepted D2579: Update seeds.
Feb 19 2019, 19:49
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Cleanup nBlocksToConfirm and change nblocks argument deprecation implementation

Feb 19 2019, 19:45
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 19 2019, 19:43
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 19 2019, 19:26
jasonbcox planned changes to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 19 2019, 19:25
jasonbcox accepted D2578: Replace BTC by BCH in util.py error messages and docstrings.
Feb 19 2019, 19:22

Feb 18 2019

jasonbcox committed rABCd252e8987d66: Added missing release notes for 0.19 (authored by jasonbcox).
Added missing release notes for 0.19
Feb 18 2019, 19:47
jasonbcox closed D2563: Added missing release notes for 0.19.
Feb 18 2019, 19:47
jasonbcox committed rABC15445e3a4ab2: Update manpages for 0.19 (authored by jasonbcox).
Update manpages for 0.19
Feb 18 2019, 19:46
jasonbcox closed D2565: Update manpages for 0.19.
Feb 18 2019, 19:45
jasonbcox committed rABCc148a1582e7b: Update chainparams for 0.19 (authored by jasonbcox).
Update chainparams for 0.19
Feb 18 2019, 19:45
jasonbcox closed D2564: Update chainparams for 0.19.
Feb 18 2019, 19:45
jasonbcox added inline comments to D2565: Update manpages for 0.19.
Feb 18 2019, 19:16
Herald added a reviewer for D2565: Update manpages for 0.19: Restricted Project.
Feb 18 2019, 19:13
jasonbcox triaged T542: Give proper error message when DISPLAY is not set (rather than crash) as Low priority.
Feb 18 2019, 19:08 · Bootcamp, Restricted Project
Herald added a reviewer for D2564: Update chainparams for 0.19: Restricted Project.
Feb 18 2019, 18:40
Herald added a reviewer for D2563: Added missing release notes for 0.19: Restricted Project.
Feb 18 2019, 18:32
jasonbcox accepted D2562: un-mention segwit in addnode help text.
Feb 18 2019, 17:27

Feb 16 2019

jasonbcox accepted D2559: fix Qt crash.
Feb 16 2019, 03:22

Feb 14 2019

jasonbcox committed rABC4a2ad75ca9c4: qt: Poll ShutdownTimer after init is done (authored by MarcoFalke <falke.marco@gmail.com>).
qt: Poll ShutdownTimer after init is done
Feb 14 2019, 15:38
jasonbcox closed D2545: qt: Poll ShutdownTimer after init is done.
Feb 14 2019, 15:38
jasonbcox accepted D2552: Check that key length is correct when deserializing CExtKey.
Feb 14 2019, 15:31
jasonbcox accepted D2550: Various nit in pubkey.h.
Feb 14 2019, 15:26
jasonbcox accepted D2548: fix abc-parkedchain timeouts.
Feb 14 2019, 05:34
jasonbcox requested changes to D2548: fix abc-parkedchain timeouts.
Feb 14 2019, 04:59
jasonbcox committed rABC2ba3ac5b795d: Fix regression in getrawtransaction (authored by jasonbcox).
Fix regression in getrawtransaction
Feb 14 2019, 01:14
jasonbcox closed D2546: Fix regression in getrawtransaction.
Feb 14 2019, 01:14
jasonbcox added a comment to D2499: refactor TxToJSON() and ScriptPubKeyToJSON().

For posterity, this backport was fubar'd. See D2546 for details.

Feb 14 2019, 01:14
Herald added a reviewer for D2547: Merge #12366: http: Join worker threads before deleting work queue: Restricted Project.
Feb 14 2019, 01:11
jasonbcox added a comment to D2544: Improve shutdown process.

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Feb 14 2019, 00:41
jasonbcox triaged T541: Backport Core PR10267 to support includeconf as Normal priority.
Feb 14 2019, 00:25 · Restricted Project
jasonbcox triaged T540: Backport Core PR12755 as High priority.
Feb 14 2019, 00:23 · Restricted Project
jasonbcox triaged T539: Backport Core PR12366 as High priority.
Feb 14 2019, 00:16 · Restricted Project
jasonbcox triaged T538: Backport Core PR13554 as Normal priority.
Feb 14 2019, 00:14 · Restricted Project
jasonbcox triaged T537: Backport Core PR14670 as High priority.
Feb 14 2019, 00:13 · Restricted Project
jasonbcox updated the summary of D2546: Fix regression in getrawtransaction.
Feb 14 2019, 00:03

Feb 13 2019

Herald added a reviewer for D2546: Fix regression in getrawtransaction: Restricted Project.
Feb 13 2019, 23:57
Herald added a reviewer for D2545: qt: Poll ShutdownTimer after init is done: Restricted Project.
Feb 13 2019, 20:00
Herald added a reviewer for D2544: Improve shutdown process: Restricted Project.
Feb 13 2019, 19:45
jasonbcox added inline comments to D2542: Format BIP32 test cases manually.
Feb 13 2019, 19:30
Herald added a reviewer for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC: Restricted Project.
Feb 13 2019, 19:18
jasonbcox added a parent task for T521: Backport Core PR 10706: T536: Make nTxConfirmTarget use config instead of being global.
Feb 13 2019, 18:24 · Backport
jasonbcox added a subtask for T536: Make nTxConfirmTarget use config instead of being global: T521: Backport Core PR 10706.
Feb 13 2019, 18:24 · Bootcamp, Restricted Project
jasonbcox triaged T536: Make nTxConfirmTarget use config instead of being global as Normal priority.
Feb 13 2019, 18:24 · Bootcamp, Restricted Project
jasonbcox committed rABCea21177017ac: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee (authored by jasonbcox).
Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee
Feb 13 2019, 18:03
jasonbcox closed D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.
Feb 13 2019, 18:03
jasonbcox accepted D2527: Improved mempool handling when changing validation rulesets.
Feb 13 2019, 00:59

Feb 12 2019

jasonbcox accepted D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Feb 12 2019, 23:50
jasonbcox accepted D2009: [Target v0.19] Deprecate and add test for signrawtransaction.
Feb 12 2019, 23:47
jasonbcox accepted D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Feb 12 2019, 23:46
jasonbcox accepted D2483: Schnorr signature activation.
Feb 12 2019, 23:36
jasonbcox requested changes to D2527: Improved mempool handling when changing validation rulesets.
Feb 12 2019, 23:25