Page MenuHomePhabricator
Feed Advanced Search

Jun 28 2019

deadalnix added a comment to D3436: Fix concurrency-related bugs in ActivateBestChain.

Rebase

Jun 28 2019, 14:09
deadalnix committed rABC461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress. (authored by Matt Corallo <git@bluematt.me>).
Do not unlock cs_main in ABC unless we've actually made progress.
Jun 28 2019, 14:07
deadalnix closed D3435: Do not unlock cs_main in ABC unless we've actually made progress..
Jun 28 2019, 14:06
D3458: qa: Rename cli.args to cli.options is now accepted and ready to land.
Jun 28 2019, 14:06
D3459: qa: Make TestNodeCLI command optional in send_cli is now accepted and ready to land.

This is the type of PR you typicaly may want to backport in one piece to reduce the work involved.

Jun 28 2019, 14:06
D3457: test_runner: Readable output if create_cache.py fails is now accepted and ready to land.
Jun 28 2019, 14:04
D3456: Fix a typo in functional tests documentation is now accepted and ready to land.
Jun 28 2019, 14:03
deadalnix added a comment to D3441: Handle various leftover from PR10321.

Rebase

Jun 28 2019, 14:02
D3265: add new encoding checker for Schnorr sigs is now accepted and ready to land.
Jun 28 2019, 13:58
deadalnix committed rABCe0856fd24ff6: Do not permit copying FastRandomContexts (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Do not permit copying FastRandomContexts
Jun 28 2019, 13:51
deadalnix closed D3454: Do not permit copying FastRandomContexts.
Jun 28 2019, 13:51
deadalnix committed rABC1236be7d3b0a: Simplify testing RNG code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Simplify testing RNG code
Jun 28 2019, 13:46
deadalnix closed D3451: Simplify testing RNG code.
Jun 28 2019, 13:46
deadalnix committed rABC232034f4aae3: Use a local FastRandomContext in a few more places in net (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use a local FastRandomContext in a few more places in net
Jun 28 2019, 13:41
deadalnix closed D3447: Use a local FastRandomContext in a few more places in net.
Jun 28 2019, 13:41
D3455: Trivial: Fix spelling in zapwallettxes test description is now accepted and ready to land.
Jun 28 2019, 13:40
deadalnix committed rABC5354651279af: Use a FastRandomContext in LimitOrphanTxSize (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use a FastRandomContext in LimitOrphanTxSize
Jun 28 2019, 13:39
deadalnix closed D3448: Use a FastRandomContext in LimitOrphanTxSize.
Jun 28 2019, 13:39
deadalnix committed rABCf8f1272d9e7e: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection
Jun 28 2019, 13:35
deadalnix closed D3449: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection.
Jun 28 2019, 13:35
deadalnix committed rABC814ecbd1177c: Bugfix: randbytes should seed when needed (non reachable issue) (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Bugfix: randbytes should seed when needed (non reachable issue)
Jun 28 2019, 13:30
deadalnix closed D3446: Bugfix: randbytes should seed when needed (non reachable issue).
Jun 28 2019, 13:30
deadalnix committed rABC8d19410b648e: Make addrman use its local RNG exclusively (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make addrman use its local RNG exclusively
Jun 28 2019, 13:28
deadalnix closed D3445: Make addrman use its local RNG exclusively.
Jun 28 2019, 13:28
D3442: Merge #11210: Stop test_bitcoin-qt touching ~/.bitcoin is now accepted and ready to land.
Jun 28 2019, 01:27
deadalnix created D3454: Do not permit copying FastRandomContexts.
Jun 28 2019, 00:29
deadalnix created D3451: Simplify testing RNG code.
Jun 28 2019, 00:12
deadalnix created D3450: Make unit tests use the insecure_rand_ctx exclusively.
Jun 28 2019, 00:06

Jun 27 2019

deadalnix created D3449: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection.
Jun 27 2019, 23:52
deadalnix created D3448: Use a FastRandomContext in LimitOrphanTxSize.
Jun 27 2019, 23:47
deadalnix created D3447: Use a local FastRandomContext in a few more places in net.
Jun 27 2019, 23:44
deadalnix created D3446: Bugfix: randbytes should seed when needed (non reachable issue).
Jun 27 2019, 23:40
deadalnix created D3445: Make addrman use its local RNG exclusively.
Jun 27 2019, 23:38
deadalnix added a comment to D3441: Handle various leftover from PR10321.

Revert prevector_tester ctor.

Jun 27 2019, 23:08
deadalnix retitled D3441: Handle various leftover from PR10321 from Handle variosu leftover from PR10321 to Handle various leftover from PR10321.
Jun 27 2019, 23:04
deadalnix added a comment to D3438: Update seeds for 0.19.9 release.

No change for tests?

Jun 27 2019, 17:51
D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests is now accepted and ready to land.
Jun 27 2019, 17:50
deadalnix created D3441: Handle various leftover from PR10321.
Jun 27 2019, 17:28
deadalnix created D3437: Add unit tests for signals generated by ProcessNewBlock().
Jun 27 2019, 16:48
deadalnix created D3436: Fix concurrency-related bugs in ActivateBestChain.
Jun 27 2019, 16:42
deadalnix created D3435: Do not unlock cs_main in ABC unless we've actually made progress..
Jun 27 2019, 16:38
deadalnix committed rABC1f934d334612: shuffle selected coins before transaction finalization (authored by Gregory Sanders <gsanders87@gmail.com>).
shuffle selected coins before transaction finalization
Jun 27 2019, 15:04
deadalnix closed D3429: shuffle selected coins before transaction finalization.
Jun 27 2019, 15:04
D3433: Fix incorrect Markdown link is now accepted and ready to land.
Jun 27 2019, 15:03
D3420: Diagnose unsuitable outputs in lockunspent(). is now accepted and ready to land.
Jun 27 2019, 15:02
deadalnix created D3429: shuffle selected coins before transaction finalization.
Jun 27 2019, 02:45
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.

Rather than grepping and replacing within the script, you could simply generate a header that is 100% generated by the script and defines a few constants that then get used in the chainparam code. You'll get a more robust design and people won't get merge conflicts with a bot.

Jun 27 2019, 01:04

Jun 26 2019

D3416: clean up script_tests -- move segwit recovery into static json is now accepted and ready to land.
Jun 26 2019, 23:07
D3423: Fix the timestamp format when -logtimemicros is set is now accepted and ready to land.
Jun 26 2019, 23:06
D3425: Don't attempt mempool entry for wallet tx on start if already in mempool is now accepted and ready to land.
Jun 26 2019, 23:05
D3427: Fix string concatenation to os.path.join and add exception case is now accepted and ready to land.
Jun 26 2019, 23:04
D3417: [sigencoding] refactor schnorr size check is now accepted and ready to land.

This makes the code more semantically driven. Me gusta :)

Jun 26 2019, 23:02
D3418: Fix exit in generate_header.py and some formatting nits is now accepted and ready to land.
Jun 26 2019, 23:02
D3420: Diagnose unsuitable outputs in lockunspent(). now requires changes to proceed.
Jun 26 2019, 23:01
D3426: [rpc] mempoolinfo should take ::minRelayTxFee into account is now accepted and ready to land.
Jun 26 2019, 22:58
D3421: [Trivial] BTC => BCH in functional tests comments is now accepted and ready to land.
Jun 26 2019, 22:50
D3424: [tests] Combine logs on failure is now accepted and ready to land.
Jun 26 2019, 22:50
deadalnix committed rABCcb56cbc0d97e: bench: Make CoinSelection output groups pass eligibility filter (authored by Andrew Chow <achow101-github@achow101.com>).
bench: Make CoinSelection output groups pass eligibility filter
Jun 26 2019, 22:43
deadalnix closed D3428: bench: Make CoinSelection output groups pass eligibility filter.
Jun 26 2019, 22:43
deadalnix created D3428: bench: Make CoinSelection output groups pass eligibility filter.
Jun 26 2019, 19:04
deadalnix committed rABC27b6f17553c0: wallet: shuffle coins before grouping, where warranted (authored by Karl-Johan Alm <kalle.alm@gmail.com>).
wallet: shuffle coins before grouping, where warranted
Jun 26 2019, 12:59
deadalnix closed D3414: wallet: shuffle coins before grouping, where warranted.
Jun 26 2019, 12:59
deadalnix committed rABC903806fc9f40: Make FastRandomContext support standard C++11 RNG interface (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make FastRandomContext support standard C++11 RNG interface
Jun 26 2019, 12:56
deadalnix closed D3413: Make FastRandomContext support standard C++11 RNG interface.
Jun 26 2019, 12:56
deadalnix committed rABC2f24287f7e02: wallet: sum ancestors rather than taking max in output groups (authored by Karl-Johan Alm <kalle.alm@gmail.com>).
wallet: sum ancestors rather than taking max in output groups
Jun 26 2019, 12:50
deadalnix closed D3412: wallet: sum ancestors rather than taking max in output groups.
Jun 26 2019, 12:50
D3295: Added a script to automate collecting and updating seeds now requires changes to proceed.

The whole thing doesn't actually test what we are interested in: that the node effectively have a good list of node to bootstrap from.

Jun 26 2019, 00:57
deadalnix created D3414: wallet: shuffle coins before grouping, where warranted.
Jun 26 2019, 00:24
deadalnix created D3413: Make FastRandomContext support standard C++11 RNG interface.
Jun 26 2019, 00:20

Jun 25 2019

deadalnix created D3412: wallet: sum ancestors rather than taking max in output groups.
Jun 25 2019, 23:56
D3335: [LINTER] Make the check-doc linter run only once now requires changes to proceed.
Jun 25 2019, 23:26
D3363: [CMAKE] Build checkblock benchmark is now accepted and ready to land.
Jun 25 2019, 23:19
D2645: Reject headers building on invalid chains by tracking invalidity is now accepted and ready to land.
Jun 25 2019, 23:17
D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests now requires changes to proceed.

Don't use 0 for flags.

Jun 25 2019, 23:05
D3264: sigencoding_tests: improve test coverage is now accepted and ready to land.
Jun 25 2019, 20:26
D3347: [script_tests] improve coverage of minimal number encoding is now accepted and ready to land.
Jun 25 2019, 20:25
D3283: Merge #10408, #13291, and partial #13163 is now accepted and ready to land.

OK I got back to it. I don't get the way things are split up. Why do this, which introduce a memory leak, and then do PR10587 to fix it? If the goal was to merge things so that we don't land bugs then what is it about? On the other hand, PR13291 was merged here, but clearly it is not bugfix. The logic of the decoupage do not seems to follow any principle.

Jun 25 2019, 20:24
D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress() is now accepted and ready to land.
Jun 25 2019, 20:13
D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag is now accepted and ready to land.
Jun 25 2019, 20:07
D3388: Backport last relevant bit of #11389 is now accepted and ready to land.
Jun 25 2019, 16:36
D3410: Improve signmessages functional test is now accepted and ready to land.
Jun 25 2019, 15:43
D3409: Add getmininginfo functional test is now accepted and ready to land.
Jun 25 2019, 15:43
D3411: Update importprivkey named args documentation is now accepted and ready to land.
Jun 25 2019, 15:34
D3363: [CMAKE] Build checkblock benchmark now requires changes to proceed.
Jun 25 2019, 15:33
deadalnix committed rABC57a774c7dc30: doc: Add release notes for -avoidpartialspends (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
doc: Add release notes for -avoidpartialspends
Jun 25 2019, 15:11
deadalnix closed D3398: doc: Add release notes for -avoidpartialspends.
Jun 25 2019, 15:10
deadalnix committed rABC4ba29712a331: test: Add basic testing for wallet groups (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
test: Add basic testing for wallet groups
Jun 25 2019, 15:07
deadalnix closed D3395: test: Add basic testing for wallet groups.
Jun 25 2019, 15:06
deadalnix committed rABC909f0eeba114: wallet: Remove deprecated OutputEligibleForSpending (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Remove deprecated OutputEligibleForSpending
Jun 25 2019, 15:05
deadalnix closed D3396: wallet: Remove deprecated OutputEligibleForSpending.
Jun 25 2019, 15:04
deadalnix committed rABC8dcaeabfcaff: clean-up: Remove no longer used ivars from CInputCoin (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
clean-up: Remove no longer used ivars from CInputCoin
Jun 25 2019, 15:02
deadalnix closed D3397: clean-up: Remove no longer used ivars from CInputCoin.
Jun 25 2019, 15:01
deadalnix committed rABCafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Switch to using output groups instead of coins in coin selection
Jun 25 2019, 14:58
deadalnix closed D3394: wallet: Switch to using output groups instead of coins in coin selection.
Jun 25 2019, 14:58
deadalnix committed rABC6e53ab546d81: Add -avoidpartialspends and m_avoid_partial_spends (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
Add -avoidpartialspends and m_avoid_partial_spends
Jun 25 2019, 14:54
deadalnix closed D3392: Add -avoidpartialspends and m_avoid_partial_spends.
Jun 25 2019, 14:54
deadalnix committed rABC7bc2342c29d0: wallet: Add output grouping (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Add output grouping
Jun 25 2019, 14:51
deadalnix closed D3393: wallet: Add output grouping.
Jun 25 2019, 14:51
deadalnix added a comment to D3395: test: Add basic testing for wallet groups.

Add test case from PR13805 and addres various comments

Jun 25 2019, 14:44
deadalnix updated the summary of D3395: test: Add basic testing for wallet groups.
Jun 25 2019, 14:39