Page MenuHomePhabricator
Feed Advanced Search

Nov 12 2024

roqqit requested review of D17117: [avalanche] Add manual stake winners to the contender cache.
Nov 12 2024, 17:55

Nov 5 2024

roqqit accepted D17071: [avalanche] Cleanup the logs.
Nov 5 2024, 16:42
roqqit closed D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Nov 5 2024, 00:05
roqqit committed rABCa66b32711df2: [avalanche] Only allow contender cache cleanup up to the height of the last… (authored by roqqit).
[avalanche] Only allow contender cache cleanup up to the height of the last…
Nov 5 2024, 00:05

Nov 4 2024

roqqit updated the diff for D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.

Fix style nit

Nov 4 2024, 21:47
roqqit requested review of D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Nov 4 2024, 20:35
roqqit accepted D17068: [avalanche] Always print the finalization messages.
Nov 4 2024, 17:41
roqqit requested changes to D17071: [avalanche] Cleanup the logs.

Back to you for the test failure

Nov 4 2024, 17:21
roqqit accepted D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 17:20

Nov 1 2024

roqqit closed D17058: Fix lock order inversion in promoteStakeContendersToTip.
Nov 1 2024, 22:12
roqqit committed rABC88a5faa04223: Fix lock order inversion in promoteStakeContendersToTip (authored by roqqit).
Fix lock order inversion in promoteStakeContendersToTip
Nov 1 2024, 22:12
roqqit added a comment to D17058: Fix lock order inversion in promoteStakeContendersToTip.

https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/845463?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false

Nov 1 2024, 21:58
teamcity awarded D17058: Fix lock order inversion in promoteStakeContendersToTip a Haypence token.
Nov 1 2024, 21:18
roqqit abandoned D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 21:17
roqqit published D17058: Fix lock order inversion in promoteStakeContendersToTip for review.
Nov 1 2024, 21:17
roqqit requested review of D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 18:17
roqqit added a reverting change for D17027: [avalanche] Promote stake contenders when the chain tip updates: D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 18:17
roqqit added a reverting change for rABCf223acc35389: [avalanche] Promote stake contenders when the chain tip updates: D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 18:16
roqqit closed D17027: [avalanche] Promote stake contenders when the chain tip updates.
Nov 1 2024, 15:48
roqqit committed rABCf223acc35389: [avalanche] Promote stake contenders when the chain tip updates (authored by roqqit).
[avalanche] Promote stake contenders when the chain tip updates
Nov 1 2024, 15:48

Oct 29 2024

roqqit updated the diff for D17027: [avalanche] Promote stake contenders when the chain tip updates.

Fix clang error

Oct 29 2024, 22:06
roqqit updated the diff for D17027: [avalanche] Promote stake contenders when the chain tip updates.

Cleanup locks

Oct 29 2024, 18:28
roqqit updated the diff for D17027: [avalanche] Promote stake contenders when the chain tip updates.

Feedback. Only cleanup cache once per block finalization.

Oct 29 2024, 18:25
roqqit closed D17024: [avalanche] Add stake contender cache to avalanche processor.
Oct 29 2024, 18:24
roqqit committed rABCb9a55d2cdd2d: [avalanche] Add stake contender cache to avalanche processor (authored by roqqit).
[avalanche] Add stake contender cache to avalanche processor
Oct 29 2024, 18:24

Oct 28 2024

roqqit closed D17025: [avalanche] Fix contender cache isEmpty return type.
Oct 28 2024, 23:52
roqqit committed rABC3a8cbaf3c108: [avalanche] Fix contender cache isEmpty return type (authored by roqqit).
[avalanche] Fix contender cache isEmpty return type
Oct 28 2024, 23:52
roqqit requested review of D17027: [avalanche] Promote stake contenders when the chain tip updates.
Oct 28 2024, 21:33
roqqit requested review of D17025: [avalanche] Fix contender cache isEmpty return type.
Oct 28 2024, 20:30
roqqit updated the diff for D17024: [avalanche] Add stake contender cache to avalanche processor.

Fix build failure and rebase

Oct 28 2024, 20:11
roqqit updated the diff for D17024: [avalanche] Add stake contender cache to avalanche processor.

Address early feedback in https://reviews.bitcoinabc.org/D16992#inline-74171

Oct 28 2024, 17:22
roqqit planned changes to D17024: [avalanche] Add stake contender cache to avalanche processor.
Oct 28 2024, 17:16
roqqit requested review of D17024: [avalanche] Add stake contender cache to avalanche processor.
Oct 28 2024, 17:15

Oct 25 2024

teamcity awarded D16992: [avalanche] Start populating the staking contender cache a Haypence token.
Oct 25 2024, 13:01

Oct 24 2024

roqqit updated the diff for D16992: [avalanche] Start populating the staking contender cache.

Fix chainstate dependency

Oct 24 2024, 20:54
roqqit requested review of D16992: [avalanche] Start populating the staking contender cache.
Oct 24 2024, 20:28
roqqit closed D16951: [avalanche] Add a way to promote old entries in the contender cache to a new chain tip.
Oct 24 2024, 18:11
roqqit committed rABCff7cabede390: [avalanche] Add a way to promote old entries in the contender cache to a new… (authored by roqqit).
[avalanche] Add a way to promote old entries in the contender cache to a new…
Oct 24 2024, 18:11

Oct 23 2024

roqqit updated the summary of D16951: [avalanche] Add a way to promote old entries in the contender cache to a new chain tip.
Oct 23 2024, 20:52
roqqit updated the diff for D16951: [avalanche] Add a way to promote old entries in the contender cache to a new chain tip.

Pass peer manager down per feedback. This no longer black boxes the logic of the proof validity check and the testing is not significantly worse.

Oct 23 2024, 20:51

Oct 22 2024

roqqit planned changes to D16951: [avalanche] Add a way to promote old entries in the contender cache to a new chain tip.
Oct 22 2024, 20:15

Oct 21 2024

roqqit requested review of D16951: [avalanche] Add a way to promote old entries in the contender cache to a new chain tip.
Oct 21 2024, 18:36
roqqit closed D16933: [avalanche] Streamline API for setting manual stake winners to contender cache.
Oct 21 2024, 15:51
roqqit committed rABC42af549c25df: [avalanche] Streamline API for setting manual stake winners to contender cache (authored by roqqit).
[avalanche] Streamline API for setting manual stake winners to contender cache
Oct 21 2024, 15:51

Oct 18 2024

roqqit closed D16932: [avalanche] Add a way to check if a proof is a remote proof.
Oct 18 2024, 22:41
roqqit committed rABCf1c48b59e493: [avalanche] Add a way to check if a proof is a remote proof (authored by roqqit).
[avalanche] Add a way to check if a proof is a remote proof
Oct 18 2024, 22:41
teamcity awarded D16934: [avalanche] Do not register proofs during IBD a Haypence token.
Oct 18 2024, 16:56
roqqit requested review of D16933: [avalanche] Streamline API for setting manual stake winners to contender cache.
Oct 18 2024, 16:01
roqqit requested review of D16932: [avalanche] Add a way to check if a proof is a remote proof.
Oct 18 2024, 15:53

Oct 17 2024

roqqit accepted D16918: build: set --build when configuring packages in depends.
Oct 17 2024, 17:07

Oct 10 2024

roqqit closed D16888: Merge bitcoin/bitcoin#27177: test: fix intermittent issue in `feature_bip68_sequence`.
Oct 10 2024, 21:51
roqqit committed rABC69d0c97e131b: Merge bitcoin/bitcoin#27177: test: fix intermittent issue in… (authored by Andrew Chow <github@achow101.com>).
Merge bitcoin/bitcoin#27177: test: fix intermittent issue in…
Oct 10 2024, 21:51
roqqit requested review of D16888: Merge bitcoin/bitcoin#27177: test: fix intermittent issue in `feature_bip68_sequence`.
Oct 10 2024, 20:41

Oct 9 2024

roqqit closed D16876: [avalanche] Add test case of vote status for manually added stake winner.
Oct 9 2024, 20:38
roqqit committed rABC36b7920c9271: [avalanche] Add test case of vote status for manually added stake winner (authored by roqqit).
[avalanche] Add test case of vote status for manually added stake winner
Oct 9 2024, 20:38
roqqit requested review of D16876: [avalanche] Add test case of vote status for manually added stake winner.
Oct 9 2024, 16:12
roqqit closed D16874: test: simplify uint256 (de)serialization routines.
Oct 9 2024, 15:41
roqqit committed rABCca4d4be53648: test: simplify uint256 (de)serialization routines (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: simplify uint256 (de)serialization routines
Oct 9 2024, 15:41

Oct 8 2024

roqqit updated the summary of D16874: test: simplify uint256 (de)serialization routines.
Oct 8 2024, 23:48
roqqit updated the summary of D16874: test: simplify uint256 (de)serialization routines.
Oct 8 2024, 23:48
roqqit requested review of D16874: test: simplify uint256 (de)serialization routines.
Oct 8 2024, 23:46

Oct 3 2024

roqqit closed D16837: [avalanche] Add a way to get stake contender vote status.
Oct 3 2024, 18:44
roqqit committed rABC52b9f0503a48: [avalanche] Add a way to get stake contender vote status (authored by roqqit).
[avalanche] Add a way to get stake contender vote status
Oct 3 2024, 18:44

Oct 2 2024

roqqit requested review of D16837: [avalanche] Add a way to get stake contender vote status.
Oct 2 2024, 16:14

Oct 1 2024

roqqit requested review of D16837: [avalanche] Add a way to get stake contender vote status.
Oct 1 2024, 22:30

Sep 26 2024

roqqit closed D16814: [avalanche] Check unknown inv type in cooldown test.
Sep 26 2024, 19:31
roqqit committed rABC30c59afc75a5: [avalanche] Check unknown inv type in cooldown test (authored by roqqit).
[avalanche] Check unknown inv type in cooldown test
Sep 26 2024, 19:31
roqqit updated the diff for D16814: [avalanche] Check unknown inv type in cooldown test.

add MSG_UNDEFINED constant

Sep 26 2024, 16:22
roqqit closed D16813: [avalanche] Check all inv types in cooldown test.
Sep 26 2024, 16:18
roqqit committed rABCf9542fe9c350: [avalanche] Check all inv types in cooldown test (authored by roqqit).
[avalanche] Check all inv types in cooldown test
Sep 26 2024, 16:18

Sep 25 2024

roqqit requested review of D16814: [avalanche] Check unknown inv type in cooldown test.
Sep 25 2024, 18:44
roqqit requested review of D16813: [avalanche] Check all inv types in cooldown test.
Sep 25 2024, 18:42

Sep 23 2024

roqqit closed D16782: [avalanche] Implement cleanup for stake contender cache.
Sep 23 2024, 20:00
roqqit committed rABC2f0cd61946ba: [avalanche] Implement cleanup for stake contender cache (authored by roqqit).
[avalanche] Implement cleanup for stake contender cache
Sep 23 2024, 20:00
roqqit accepted D16802: [avalanche] Add a block invalidated validation callback.
Sep 23 2024, 16:26
roqqit accepted D16801: Lock cs_main when calling the block finalized validation interface.
Sep 23 2024, 16:17
roqqit accepted D16791: Store the last 20 headers reception time to a file.
Sep 23 2024, 16:15
roqqit added a comment to D16782: [avalanche] Implement cleanup for stake contender cache.

I see your test doesn't check for contiguous heights, you should add that

Sep 23 2024, 16:13
roqqit updated the diff for D16782: [avalanche] Implement cleanup for stake contender cache.

Use lower_bound instead since it is more technically correct and robust to future changes. There is no change in behavior.

Sep 23 2024, 16:09

Sep 20 2024

roqqit closed D16793: [avalanche] Use block index instead of blockhash for adding contenders to the cache.
Sep 20 2024, 16:57
roqqit committed rABCb5fe46c6e31d: [avalanche] Use block index instead of blockhash for adding contenders to the… (authored by roqqit).
[avalanche] Use block index instead of blockhash for adding contenders to the…
Sep 20 2024, 16:57
roqqit closed D16792: [avalanche] Cleanup unneeded variable in contender cache test.
Sep 20 2024, 16:57
roqqit committed rABCe686b296e89b: [avalanche] Cleanup unneeded variable in contender cache test (authored by roqqit).
[avalanche] Cleanup unneeded variable in contender cache test
Sep 20 2024, 16:56
roqqit requested changes to D16791: Store the last 20 headers reception time to a file.

The patch looks ok but there is a test failure

Sep 20 2024, 00:38
roqqit accepted D16791: Store the last 20 headers reception time to a file.
Sep 20 2024, 00:37
roqqit updated the diff for D16782: [avalanche] Implement cleanup for stake contender cache.

changes per feedback to remove the cs_main lock. now depends on D16793

Sep 20 2024, 00:18
roqqit requested review of D16793: [avalanche] Use block index instead of blockhash for adding contenders to the cache.
Sep 20 2024, 00:14
roqqit requested review of D16792: [avalanche] Cleanup unneeded variable in contender cache test.
Sep 20 2024, 00:10

Sep 18 2024

roqqit closed D16779: [avalanche] Add missing const to getWinners.
Sep 18 2024, 21:33
roqqit committed rABCa18387188c0d: [avalanche] Add missing const to getWinners (authored by roqqit).
[avalanche] Add missing const to getWinners
Sep 18 2024, 21:33
roqqit requested review of D16782: [avalanche] Implement cleanup for stake contender cache.
Sep 18 2024, 16:24
roqqit requested review of D16779: [avalanche] Add missing const to getWinners.
Sep 18 2024, 16:06

Sep 17 2024

roqqit accepted D16757: [avalanche] Vote on conflicting txs.
Sep 17 2024, 20:56
roqqit accepted D16773: Compute the real-time hash target for the next block.
Sep 17 2024, 19:54

Sep 16 2024

roqqit added inline comments to D16757: [avalanche] Vote on conflicting txs.
Sep 16 2024, 23:57

Sep 13 2024

roqqit accepted D16729: Reject blocks that violate the real time target policy.
Sep 13 2024, 19:49

Sep 12 2024

roqqit requested changes to D16729: Reject blocks that violate the real time target policy.
Sep 12 2024, 15:41
roqqit accepted D16728: Compute the real-time hash target for the next block.
Sep 12 2024, 15:38

Sep 11 2024

roqqit accepted D16730: Return the RTT parameters in the block template.
Sep 11 2024, 21:23
roqqit requested changes to D16729: Reject blocks that violate the real time target policy.
Sep 11 2024, 21:15