remove comment (x52), include new test from D17113

add more tests (mostly abc*). Note that the new way of setting the option is persistent accross node restarts. abc_p2p_avalanche_proof_voting is an example that fails if we set this attribute, because it needs to restart without the noban permission in one of the subtests.

feedback

In D17110#388296, @Fabien wrote:

The commits are not the correct ones

interface_rest.py | ✓ Passed | 21 s

I'm not able to reproduce the failure in 100 runs of the test , but I noticed that the test duration variability is wild, with values ranging from 6s to 41s.
I will backport 27114 to hopefully speed this up.

lock issue or lock annotation issue to be investigated

functional test failure to be investigated

remove .as_ref() that does nothing, dedup copyright header

fix decompress_script injection

i forgot about the dependency injection issue

provide error 400 (index disabled) and fix "creates a temporary value which is freed while still in use" by making script_ser a vec<u8> rather than a &[u8]

add the error 400 when index is disabled

rebase and add tests

remove redundant clone (&[u8] implements the copy trait)

add test for scenario "a mined tx replaces a mempool tx leaving the history empty", remove unused import causing compile warning (seems unrelated to this diff??)

Build failures

Make member_ser_by_member_hash return a &[u8] and make it work in the callsite
Add an additional test that covers two of the requested scenarii:

• one where there’s still one left in the mempool
• one where there’s still one left in the db

still working on more tests

rebase

merge imports

still need to fix the decompress_script injection which currently breaks tests

Actually I'm not sure we should remove it. It seems like this was reused and re-removed even after D4576 (see D5283). Maybe we should keep looking for it in Electrum it for another potential future node consensus upgrade?

rebase

rebase

remove now useless functions and imports

remove the need to access db for checking if the index is enabled

no more need for the todo

then_some, don't allocate

revert accidental squashing

I accidentaly squashed the child diff while trying to reabase and amend it

use then_some, don't allocate to query the hashmap

return a better error if the scripthash index is disabled

looks like the decompress_script injection breaks a bunch of tests

simplify expressions

use ok_or, fix the test suite's name

rebase

don't panic

write a new test dedicated to scripthash, make it a bit simpler (no need to retest all the things already tested in the other 3 tests)