Feed All Stories
Dec 6 2024
Dec 6 2024
hazzarust retitled D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer from [BITCOIN-ABC] Allowing rust analyser to work in web/explorer to [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer.
hazzarust retitled D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer from [BITCOIN-ABC] Changes to rust analyser to [BITCOIN-ABC] Allowing rust analyser to work in web/explorer.
hazzarust updated the summary of D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer.
hazzarust updated the summary of D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer.
hazzarust retitled D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer from Changes to rust analyzer to [BITCOIN-ABC] Changes to rust analyser.
hazzarust updated the summary of D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer.
hazzarust published D17292: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer for review.
Dec 5 2024
Dec 5 2024
tobias_ruck committed rABCd9bedb004bfb: [64-bit ints] Change `CScriptNum::getint` to return `int64_t` (authored by tobias_ruck).
[64-bit ints] Change `CScriptNum::getint` to return `int64_t`
tobias_ruck committed rABCf67fd8dd5fd8: [64-bit ints] Add script_tests for `getint` coverage (authored by tobias_ruck).
[64-bit ints] Add script_tests for `getint` coverage
PiRK updated the summary of D17299: [electrum] fix the minimum python version.
PiRK requested review of D17299: [electrum] fix the minimum python version.
johnkuney updated the diff for D17296: [cashtab] Cleanup theme file.
add menu glow value
PiRK requested review of D17298: [electrum] bump libudev-dev for the AppImage release.
bytesofman committed rABCb88a433009ea: Revert "[Cashtab] Convert wallet context to ts" (authored by bytesofman).
Revert "[Cashtab] Convert wallet context to ts"
bytesofman added a reverting change for rABCd42543241000: [Cashtab] Convert wallet context to ts: rABCb88a433009ea: Revert "[Cashtab] Convert wallet context to ts".
bytesofman added a reverting change for D17288: [Cashtab] Convert wallet context to ts: rABCb88a433009ea: Revert "[Cashtab] Convert wallet context to ts".
johnkuney added inline comments to D17296: [cashtab] Cleanup theme file.
bytesofman published D17297: Revert "[Cashtab] Convert wallet context to ts" for review.
bytesofman added a reverting change for D17288: [Cashtab] Convert wallet context to ts: D17297: Revert "[Cashtab] Convert wallet context to ts".
bytesofman added a reverting change for rABCd42543241000: [Cashtab] Convert wallet context to ts: D17297: Revert "[Cashtab] Convert wallet context to ts".
bytesofman requested changes to D17296: [cashtab] Cleanup theme file.
nice, Cashtab has needed this. Much more maintainable.
Fabien committed rABCd275d0e46129: [electrum] Better support for Trezor safe devices (authored by Fabien).
[electrum] Better support for Trezor safe devices
Fabien added a comment to D17294: [electrum] Better support for Trezor safe devices.
bytesofman committed rABCd42543241000: [Cashtab] Convert wallet context to ts (authored by bytesofman).
[Cashtab] Convert wallet context to ts
PiRK added a comment to D17294: [electrum] Better support for Trezor safe devices.
I will build a beta AppImage and test that the release actually works with this bump. But I really see no reason why it wouldn"t. Trezorlib is pure python so no weird compatibility surprises to be expected related to compiled libs. And it supports all python versions >=8 (we package with 3.11
At some point we can also change the regular (non-deterministic) requirements.txt to force >= 0.13.9 and drop the compat.py code. It can be done in a separate diff, though. I'm still trying to think of potential downsides of doing so. Electrum maintains support for trezor>=0.13.0 mainly because there are packagers on various Linux distros who have to work with older trezor packages. We don't have this issue with Electrum ABC.
johnkuney updated the diff for D17296: [cashtab] Cleanup theme file.
put background image back
johnkuney updated the diff for D17296: [cashtab] Cleanup theme file.
remove unused import
It works with only a minor change in Electrum ABC code
teamcity added a comment to D17296: [cashtab] Cleanup theme file.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
teamcity added a comment to D17296: [cashtab] Cleanup theme file.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
johnkuney requested review of D17296: [cashtab] Cleanup theme file.
Fabien updated the diff for D17294: [electrum] Better support for Trezor safe devices.
Fix comment
Fabien updated the diff for D17185: [chronik] Create a new optional JSON RPC interface.
Sanitize the imports
I still think it's not the best option but I'm not dying on the hill since both are valid anyway.
bytesofman requested changes to D17294: [electrum] Better support for Trezor safe devices.
Fabien added inline comments to D17185: [chronik] Create a new optional JSON RPC interface.
Fabien added inline comments to D17294: [electrum] Better support for Trezor safe devices.
bytesofman added inline comments to D17294: [electrum] Better support for Trezor safe devices.
tobias_ruck requested changes to D17185: [chronik] Create a new optional JSON RPC interface.
tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
fix CheckNegate
tobias_ruck added inline comments to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
tobias_ruck committed rABC805a0f137bf6: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file (authored by tobias_ruck).
[64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file
tobias_ruck updated the diff for D17290: [64-bit ints] Add script_tests for `getint` coverage.
add rationales
Fabien requested review of D17294: [electrum] Better support for Trezor safe devices.
bytesofman updated the diff for D17288: [Cashtab] Convert wallet context to ts.
typo patch
bytesofman added inline comments to D17288: [Cashtab] Convert wallet context to ts.
emack requested changes to D17288: [Cashtab] Convert wallet context to ts.
bytesofman published D17288: [Cashtab] Convert wallet context to ts for review.
bytesofman committed rABCb5b7145ef776: [ecash-herald] Tighten up daily summary msgs (authored by bytesofman).
[ecash-herald] Tighten up daily summary msgs
bytesofman published D17293: [ecash-herald] Tighten up daily summary msgs for review.
Fabien updated the diff for D17185: [chronik] Create a new optional JSON RPC interface.
Rebase, feedback
Fabien added inline comments to D17185: [chronik] Create a new optional JSON RPC interface.
Fabien requested changes to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Fabien requested changes to D17290: [64-bit ints] Add script_tests for `getint` coverage.
[Cashtab] Remove swap screen
emack accepted D17291: [Cashtab] Remove swap screen.
FWIW - The widget is working in prod for me
Dec 4 2024
Dec 4 2024
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.
build lint
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-tests) failed.
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-tests) failed.
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
bytesofman updated the summary of D17291: [Cashtab] Remove swap screen.
bytesofman published D17291: [Cashtab] Remove swap screen for review.
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.
improve file organization as suggested
tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
address review, remove CScriptNum10 and replace tests with tests that test the behavior of CScriptNum instead of testing whether it matches CScriptNum10
tobias_ruck requested review of D17290: [64-bit ints] Add script_tests for `getint` coverage.
tobias_ruck updated the diff for D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file.
address review
tobias_ruck added inline comments to D17185: [chronik] Create a new optional JSON RPC interface.
tobias_ruck requested changes to D17185: [chronik] Create a new optional JSON RPC interface.
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
PiRK added inline comments to D17185: [chronik] Create a new optional JSON RPC interface.
Fabien requested review of D17185: [chronik] Create a new optional JSON RPC interface.
Fabien planned changes to D17185: [chronik] Create a new optional JSON RPC interface.
Fabien updated the diff for D17185: [chronik] Create a new optional JSON RPC interface.
An optional codec for the server has been upstreamed (https://github.com/karyontech/karyon/pull/10) and we can leverage this to add the weird \n that fulcrum expects.
This makes it compatible with electrum with no parsing change required (but we still need to send the jsonrpc field which is required by the standard).
roqqit committed rABC518391383004: Remove executable file mode from some functional tests (authored by roqqit).
Remove executable file mode from some functional tests