Page MenuHomePhabricator
Feed All Stories

Jan 8 2025

Fabien closed D17497: [avalanche] Fix UB in the reward rank comparator.
Jan 8 2025, 21:46
Fabien committed rABC7332a8874dd4: [avalanche] Fix UB in the reward rank comparator (authored by Fabien).
[avalanche] Fix UB in the reward rank comparator
Jan 8 2025, 21:46
roqqit accepted D17497: [avalanche] Fix UB in the reward rank comparator.
Jan 8 2025, 21:45
teamcity awarded D17497: [avalanche] Fix UB in the reward rank comparator a Haypence token.
Jan 8 2025, 21:17
Fabien added a comment to D17497: [avalanche] Fix UB in the reward rank comparator.

@bot build-ubsan

Jan 8 2025, 21:17
Fabien requested review of D17497: [avalanche] Fix UB in the reward rank comparator.
Jan 8 2025, 21:17
teamcity triaged T3720: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jan 8 2025, 20:48
roqqit closed D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 20:37
roqqit committed rABC11d2e76dd3c3: [avalanche] Refactor reward ranking logic into its own comparator (authored by roqqit).
[avalanche] Refactor reward ranking logic into its own comparator
Jan 8 2025, 20:37
Fabien committed rABCaf0b36e7a75e: [chronik] Fix flakiness in chronik_script_history (authored by Fabien).
[chronik] Fix flakiness in chronik_script_history
Jan 8 2025, 19:55
Fabien closed D17494: [chronik] Fix flakiness in chronik_script_history.
Jan 8 2025, 19:55
Fabien accepted D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 19:54
Fabien requested changes to D17496: [chronik] bump karyon_jsonrpc.

Couple nits but otherwise looks good

Jan 8 2025, 19:51
PiRK updated the diff for D17496: [chronik] bump karyon_jsonrpc.

same

Jan 8 2025, 18:59
PiRK updated the diff for D17496: [chronik] bump karyon_jsonrpc.

nit: use format! rather than concat! and save a to_string() conversion

Jan 8 2025, 18:56
PiRK updated the summary of D17496: [chronik] bump karyon_jsonrpc.
Jan 8 2025, 18:54
PiRK requested review of D17496: [chronik] bump karyon_jsonrpc.
Jan 8 2025, 18:52
roqqit updated the diff for D17495: [avalanche] Refactor reward ranking logic into its own comparator.

Fix circular dependency

Jan 8 2025, 18:25
teamcity added a comment to D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 17:46
teamcity added a comment to D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 17:44
roqqit requested review of D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 17:44
bytesofman accepted D17494: [chronik] Fix flakiness in chronik_script_history.
Jan 8 2025, 17:26
roqqit closed D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 8 2025, 16:53
roqqit committed rABC53d16b29628d: [avalanche] Add a way to get pollable contenders from contender cache (authored by roqqit).
[avalanche] Add a way to get pollable contenders from contender cache
Jan 8 2025, 16:53
teamcity closed T3718: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Jan 8 2025, 13:28
Fabien added a comment to D17494: [chronik] Fix flakiness in chronik_script_history.

The debug build failed to start due to teamcity bug, not related to this diff

Jan 8 2025, 13:28
teamcity added a comment to D17494: [chronik] Fix flakiness in chronik_script_history.
Jan 8 2025, 13:14
Fabien requested review of D17494: [chronik] Fix flakiness in chronik_script_history.
Jan 8 2025, 13:14
teamcity triaged T3718: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jan 8 2025, 13:04
Fabien closed D17493: Rename chronik-agora to chronik-plugins.
Jan 8 2025, 12:54
Fabien committed rABC8592b9457a71: Rename chronik-agora to chronik-plugins (authored by Fabien).
Rename chronik-agora to chronik-plugins
Jan 8 2025, 12:54
Fabien closed D17492: [chronik] Specify the base image version via a build arg for the chronik-agora image.
Jan 8 2025, 12:54
Fabien closed D17491: [chronik] Reduce the size of the chronik-agora image.
Jan 8 2025, 12:54
Fabien committed rABC74acb2552f46: [chronik] Specify the base image version via a build arg for the chronik-agora… (authored by Fabien).
[chronik] Specify the base image version via a build arg for the chronik-agora…
Jan 8 2025, 12:54
Fabien committed rABCd9b81f574a27: [chronik] Reduce the size of the chronik-agora image (authored by Fabien).
[chronik] Reduce the size of the chronik-agora image
Jan 8 2025, 12:54
bytesofman added inline comments to D17493: Rename chronik-agora to chronik-plugins.
Jan 8 2025, 12:53
Fabien added inline comments to D17493: Rename chronik-agora to chronik-plugins.
Jan 8 2025, 12:52
bytesofman added inline comments to D17491: [chronik] Reduce the size of the chronik-agora image.
Jan 8 2025, 12:51
bytesofman accepted D17493: Rename chronik-agora to chronik-plugins.
Jan 8 2025, 12:50
Fabien added inline comments to D17491: [chronik] Reduce the size of the chronik-agora image.
Jan 8 2025, 12:49
bytesofman accepted D17492: [chronik] Specify the base image version via a build arg for the chronik-agora image.
Jan 8 2025, 12:48
bytesofman accepted D17491: [chronik] Reduce the size of the chronik-agora image.

brings the image size from ~11.8GB down to ~173MB.

Jan 8 2025, 12:47
Fabien requested review of D17493: Rename chronik-agora to chronik-plugins.
Jan 8 2025, 12:31
Fabien requested review of D17492: [chronik] Specify the base image version via a build arg for the chronik-agora image.
Jan 8 2025, 12:25
bytesofman closed D17490: [ecash-herald] Better handling of undefined keys.
Jan 8 2025, 12:20
bytesofman committed rABCeb534347deff: [ecash-herald] Better handling of undefined keys (authored by bytesofman).
[ecash-herald] Better handling of undefined keys
Jan 8 2025, 12:20
Fabien retitled D17491: [chronik] Reduce the size of the chronik-agora image from [chronik] Recuce the size of the chronik-agora image to [chronik] Reduce the size of the chronik-agora image.
Jan 8 2025, 12:14
Fabien accepted D17490: [ecash-herald] Better handling of undefined keys.
Jan 8 2025, 12:13
Fabien requested review of D17491: [chronik] Reduce the size of the chronik-agora image.
Jan 8 2025, 12:12
bytesofman published D17490: [ecash-herald] Better handling of undefined keys for review.
Jan 8 2025, 12:00
bytesofman added inline comments to D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Jan 8 2025, 12:00
bytesofman closed D17489: [ecash-herald] Sort agora tokens by volume instead of buy count.
Jan 8 2025, 11:29
bytesofman committed rABCdbfc44c48fb1: [ecash-herald] Sort agora tokens by volume instead of buy count (authored by bytesofman).
[ecash-herald] Sort agora tokens by volume instead of buy count
Jan 8 2025, 11:29
bytesofman added inline comments to D17489: [ecash-herald] Sort agora tokens by volume instead of buy count.
Jan 8 2025, 11:29
Fabien added inline comments to D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Jan 8 2025, 08:31
Fabien accepted D17489: [ecash-herald] Sort agora tokens by volume instead of buy count.
Jan 8 2025, 08:26
Fabien accepted D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 8 2025, 08:19
bytesofman published D17489: [ecash-herald] Sort agora tokens by volume instead of buy count for review.
Jan 8 2025, 00:43

Jan 7 2025

roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.

Cleanup unnecessary nesting when sorting contenders and make the sorting work the same as staking rewards selection.

Jan 7 2025, 22:22
Fabien requested changes to D17485: [chronik] implement blockchain.block.header electrum method.
Jan 7 2025, 21:58
Fabien accepted D17486: [chronik] actually run the functional test for blockchain.transaction.get_height.
Jan 7 2025, 21:55
Fabien closed D17488: [chronik] Add another server to the list.
Jan 7 2025, 21:53
Fabien committed rABC4e3f08dbb58e: [chronik] Add another server to the list (authored by Fabien).
[chronik] Add another server to the list
Jan 7 2025, 21:53
Fabien closed D17487: [chronik] Add a docker image for an agora enabled bitcoind.
Jan 7 2025, 21:05
Fabien committed rABC672dbf93ee0d: [chronik] Add a docker image for an agora enabled bitcoind (authored by Fabien).
[chronik] Add a docker image for an agora enabled bitcoind
Jan 7 2025, 21:05
bytesofman accepted D17487: [chronik] Add a docker image for an agora enabled bitcoind.
Jan 7 2025, 21:02
Fabien added a comment to D17487: [chronik] Add a docker image for an agora enabled bitcoind.

I can kind of follow this by parsing the code. I think a README.md in this dir would be helpful?

Should we add nginx to this as well? How would a user go from having this docker image running to having a chronik server available?

Jan 7 2025, 20:59
bytesofman accepted D17488: [chronik] Add another server to the list.

confirmed i can get agora plugin output from API calls and use agora to subscribe to plugin websockets with this new instance

Jan 7 2025, 20:58
bytesofman added a comment to D17487: [chronik] Add a docker image for an agora enabled bitcoind.

I can kind of follow this by parsing the code. I think a README.md in this dir would be helpful?

Jan 7 2025, 20:56
Fabien requested review of D17488: [chronik] Add another server to the list.
Jan 7 2025, 20:54
Fabien requested review of D17487: [chronik] Add a docker image for an agora enabled bitcoind.
Jan 7 2025, 20:44
bytesofman published D17484: [Cashtab] Improve form entry and validation for listing tokens on agora for review.
Jan 7 2025, 20:12
roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.
  • Fix rare sorting case where two proofs have the same rank.
  • Make num pollable a parameter so the processor will have control over how many contenders to poll for.
  • Return number of contenders instead of bool.
  • Fix test not actually checking the contender order.
Jan 7 2025, 20:04
PiRK retitled D17486: [chronik] actually run the functional test for blockchain.transaction.get_height from [chronik] actually run the test_transaction_get_height functional test to [chronik] actually run the functional test for blockchain.transaction.get_height.
Jan 7 2025, 16:33
PiRK requested review of D17486: [chronik] actually run the functional test for blockchain.transaction.get_height.
Jan 7 2025, 15:15
PiRK published D17485: [chronik] implement blockchain.block.header electrum method for review.
Jan 7 2025, 15:14
bytesofman closed D17468: [Cashtab] Bring back noisy test logs if not in CI.
Jan 7 2025, 13:39
bytesofman committed rABCaa4a52165ea8: [Cashtab] Bring back noisy test logs if not in CI (authored by bytesofman).
[Cashtab] Bring back noisy test logs if not in CI
Jan 7 2025, 13:39
bytesofman closed D17483: [Cashtab, ecash-herald] Improve and comment chronik stack.
Jan 7 2025, 13:38
bytesofman committed rABCa41daa752ba8: [Cashtab, ecash-herald] Improve and comment chronik stack (authored by bytesofman).
[Cashtab, ecash-herald] Improve and comment chronik stack
Jan 7 2025, 13:38
Fabien accepted D17468: [Cashtab] Bring back noisy test logs if not in CI.
Jan 7 2025, 13:26
Fabien closed D17476: [explorer] Show as much token tx information as possible when the genesis info is missing.
Jan 7 2025, 13:25
Fabien committed rABC3ec850ae770c: [explorer] Show as much token tx information as possible when the genesis info… (authored by Fabien).
[explorer] Show as much token tx information as possible when the genesis info…
Jan 7 2025, 13:25
Fabien committed rABC65c69104773f: Simplify the new mempool transaction validation callback (authored by Fabien).
Simplify the new mempool transaction validation callback
Jan 7 2025, 13:25
teamcity closed T3717: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Jan 7 2025, 13:15
Fabien accepted D17483: [Cashtab, ecash-herald] Improve and comment chronik stack.
Jan 7 2025, 13:09
bytesofman updated the diff for D17468: [Cashtab] Bring back noisy test logs if not in CI.

remove debug log

Jan 7 2025, 12:35
bytesofman updated the diff for D17468: [Cashtab] Bring back noisy test logs if not in CI.

default silent logs with npm test, add debug command to print logs

Jan 7 2025, 12:32
bytesofman closed D17481: [Cashtab] Improve notification styles.
Jan 7 2025, 12:22
bytesofman committed rABC6bd50f94a4a8: [Cashtab] Improve notification styles (authored by bytesofman).
[Cashtab] Improve notification styles
Jan 7 2025, 12:22
teamcity triaged T3717: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Jan 7 2025, 12:15
bytesofman published D17483: [Cashtab, ecash-herald] Improve and comment chronik stack for review.
Jan 7 2025, 12:13
Fabien closed D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 7 2025, 11:19
Fabien committed rABC56a2c5847155: [explorer] Don't fail to render invalid token txs with non existing token id (authored by Fabien).
[explorer] Don't fail to render invalid token txs with non existing token id
Jan 7 2025, 11:19
PiRK accepted D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 7 2025, 10:40
Fabien requested changes to D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 7 2025, 10:20
Fabien updated the diff for D17470: [explorer] Don't fail to render invalid token txs with non existing token id.

Rebase, remove commented out code

Jan 7 2025, 09:15
PiRK accepted D17476: [explorer] Show as much token tx information as possible when the genesis info is missing.
Jan 7 2025, 08:55
PiRK accepted D17481: [Cashtab] Improve notification styles.
Jan 7 2025, 07:51
teamcity awarded D17476: [explorer] Show as much token tx information as possible when the genesis info is missing a Haypence token.
Jan 7 2025, 07:46