A small change, but otherwise, LGTM.
Feed Advanced Search
Jun 20 2019
Jun 20 2019
D3114: De-witnessing some comments is now accepted and ready to land.
D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... now requires changes to proceed.
Jun 19 2019
Jun 19 2019
deadalnix added a comment to D3364: wallet: Make fee settings non-static members.
Rebase
deadalnix committed rABC04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[refactor] Make TransactionWithinChainLimit more flexible
Jun 18 2019
Jun 18 2019
deadalnix added a comment to D3343: [refactor] Make TransactionWithinChainLimit more flexible.
GetHash => GetId
deadalnix added a comment to D3283: Merge #10408, #13291, and partial #13163.
There are no explanation as to why the squash is necessary in the link you provided nor in your comment.
D3354: Clarify include guard naming convention is now accepted and ready to land.
Restore CWallet::minTxFee
deadalnix committed rABCe389a8cb3527: bench: Simplify CoinSelection (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
bench: Simplify CoinSelection
deadalnix retitled D3353: Restore CWallet::minTxFee from Restor CWallet::minTxFee to Restore CWallet::minTxFee.
deadalnix committed rABC25eb9b97fd71: Add a test to make sure that negative effective values are filtered (authored by Andrew Chow <achow101-github@achow101.com>).
Add a test to make sure that negative effective values are filtered
deadalnix committed rABC167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it (authored by Andrew Chow <achow101-github@achow101.com>).
Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it
deadalnix committed rABC0d8923573d99: tests: Avoid copies of CTransaction (authored by MarcoFalke <falke.marco@gmail.com>).
tests: Avoid copies of CTransaction
Jun 17 2019
Jun 17 2019
deadalnix committed rABC80d081077dc0: Use mempool's descendent count in the wallet code (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
Use mempool's descendent count in the wallet code
Restore minRelayTxFee
deadalnix committed rABC1f83114372e2: Implement getRequiredFee in the node interface and use it (authored by deadalnix).
Implement getRequiredFee in the node interface and use it
deadalnix added a comment to D3336: tests: Avoid copies of CTransaction.
Fix mempool_tests.cpp , Fix comment saying +2 when +3 is relevent.
deadalnix added inline comments to D3336: tests: Avoid copies of CTransaction.
deadalnix added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Remove witness overhead
deadalnix requested review of D3342: Use mempool's descendent count in the wallet code.
deadalnix committed rABC79d37414f1ac: Dead code removal (authored by Thomas Snider <tjps636@gmail.com>).
Dead code removal
D3253: Remove Schnorr activation now requires changes to proceed.
Jun 16 2019
Jun 16 2019
D3351: Fix lock reference in miner.h is now accepted and ready to land.
D3335: [LINTER] Make the check-doc linter run only once now requires changes to proceed.
I'll need more time to actually review this, but it's clear that the API is not what you'd expect.
Jun 15 2019
Jun 15 2019
D3310: Merge #14085: index: Fix for indexers skipping genesis block. is now accepted and ready to land.
D3334: [LINTER] Set the rules for the phpdoc comments is now accepted and ready to land.
D3341: Add benchmark for AES is now accepted and ready to land.
D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction` now requires changes to proceed.
developer notes are missing.
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.
deadalnix committed rABC33ff49689bcd: Make CMutableTransaction constructor explicit (authored by MarcoFalke <falke.marco@gmail.com>).
Make CMutableTransaction constructor explicit
deadalnix committed rABC06ac73365f35: bitcoin-tx: Remove unused for loop (authored by MarcoFalke <falke.marco@gmail.com>).
bitcoin-tx: Remove unused for loop
deadalnix committed rABCadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
Jun 14 2019
Jun 14 2019
deadalnix committed rABC0f49f7a5185d: Kill MAX_FREE_TRANSACTION_CREATE_SIZE (authored by deadalnix).
Kill MAX_FREE_TRANSACTION_CREATE_SIZE
D3333: Avoid including a C file in crypto/aes.cpp now requires changes to proceed.
You prevent any inlining here. This is why you get 5% perf regression. Don't do this.
deadalnix retitled D3342: Use mempool's descendent count in the wallet code from Use mempool's descendent count int he wallet code to Use mempool's descendent count in the wallet code.
deadalnix updated the summary of D3342: Use mempool's descendent count in the wallet code.
deadalnix added a comment to D3342: Use mempool's descendent count in the wallet code.
Calculate descendant maximum thoroughly
deadalnix committed rABCdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp (authored by deadalnix).
Directly use CMutableTransaction more often in txvaidationcache_tests.cpp
deadalnix committed rABCaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool… (authored by practicalswift <practicalswift@users.noreply.github.com>).
mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool…
deadalnix added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).
rebase
deadalnix added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.
Rebase
deadalnix committed rABCbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags (authored by deadalnix).
Take a CTransaction as argument for ValidateCheckInputsForAllFlags
deadalnix committed rABC8ccdaf871c43: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp (authored by deadalnix).
Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp
deadalnix committed rABC137afdf1c0f2: Use MakeTransactionRef in serialize_tests.cpp (authored by deadalnix).
Use MakeTransactionRef in serialize_tests.cpp
deadalnix added inline comments to D3318: [LINTER] Prevent including a source file.
Update mempool eviction benchmark
D3292: Explicitly call out updating makeseeds.py after major releases is now accepted and ready to land.
D3333: Avoid including a C file in crypto/aes.cpp now requires changes to proceed.
I suspect this might be pretty bad for performance. I also suspect you don't intend to become maintainer of ctaes.
deadalnix committed rABC175362193461: Make m_coinbase_txns a vector of CTransactionRef (authored by deadalnix).
Make m_coinbase_txns a vector of CTransactionRef
coinbaseTxns => m_coinbase_txns
deadalnix committed rABC861e1e268cd6: Relayout comments in validation.cpp (authored by Andrew Chow <achow101-github@achow101.com>).
Relayout comments in validation.cpp
Jun 13 2019
Jun 13 2019
deadalnix added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
Remove unecessary copy
deadalnix added a comment to D3318: [LINTER] Prevent including a source file.
Has this error actually happened in the wild ? Also, do we need a new linter for each thing that can go wrong with includes ? It seems like one should be enough.
D3318: [LINTER] Prevent including a source file now requires changes to proceed.
This should also detect the inclusion of a .c .
D3310: Merge #14085: index: Fix for indexers skipping genesis block. now requires changes to proceed.
D3319: [LINTER] Enforce using angle brackets in #include directives is now accepted and ready to land.