+1 to Nico's comment. A simple ninja to build or ninja check to build + unit tests is sufficient.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 27 2019
Nov 27 2019
Nov 26 2019
Nov 26 2019
jasonbcox committed rABCd4fbe46116a2: Merge #13498: [wallet] Fixups from account API deprecation (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #13498: [wallet] Fixups from account API deprecation
jasonbcox committed rABC67c715cd4553: Add test coverage for messages requesting invalid blocks (authored by jasonbcox).
Add test coverage for messages requesting invalid blocks
jasonbcox committed rABC1fd348979cfd: Revert use of size_t in ParseParameters (authored by jasonbcox).
Revert use of size_t in ParseParameters
Nov 25 2019
Nov 25 2019
jasonbcox committed rABCd7f7fa754e7c: Fixes broken link to disclosure policy (authored by Ethan Heilman <ethan.r.heilman@gmail.com>).
Fixes broken link to disclosure policy
I already did this prior to you red'ing the diff.
- Use assert_debug_log instead of time.sleep
- Refactor to prevent needing to jump around the code just to read and understand everything.
- Add MSG_CMPCTBLOCK to messages.py
- Improve perf from ~25 seconds to ~6 seconds
jasonbcox retitled D3694: Update the github issue template to include disclosure policy from Update the github issue template with more relevant links to Update the github issue template to include disclosure policy.
jasonbcox updated the diff for D3694: Update the github issue template to include disclosure policy.
Fix extension
jasonbcox updated the diff for D3694: Update the github issue template to include disclosure policy.
Removed change to stackexchange link
jasonbcox updated the summary of D3694: Update the github issue template to include disclosure policy.
jasonbcox committed rABC4adf7c7104e8: Added support for -gravitonactivationtime to unit tests (authored by jasonbcox).
Added support for -gravitonactivationtime to unit tests
jasonbcox retitled D4537: Revert use of size_t in ParseParameters from Fix signed to unsigned int cast warning to Revert use of size_t in ParseParameters.
Change type
Rebase
jasonbcox committed rABC65f363942f17: Split out key-value parsing in ArgsManager into its own function (authored by jasonbcox).
Split out key-value parsing in ArgsManager into its own function
Nov 23 2019
Nov 23 2019
Nov 22 2019
Nov 22 2019
Address feedback
jasonbcox updated the diff for D4496: Split out key-value parsing in ArgsManager into its own function.
- Added some basic unit tests
- int -> size_t
- Funny how forcing yourself to write some tests reveals subtle design flaws. Moved ParseKeyValue() out of ArgsManager because it doesn't actually belong in that class. I still kept the implementations close to make backporting easier.
Rebase + rename build option
jasonbcox added a comment to D4496: Split out key-value parsing in ArgsManager into its own function.
In D4496#108676, @deadalnix wrote:Considering there are still many backports to do in there, I don't think this is very wise to go there.
jasonbcox updated the diff for D4496: Split out key-value parsing in ArgsManager into its own function.
Rebase
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.
Added error message + minor refactor
jasonbcox updated the test plan for D4279: Added autopatch script for patching and rebasing phabricator diffs.
Nov 21 2019
Nov 21 2019
Update manpages for 0.20.7 release
Update chainparams
Update seeds
jasonbcox accepted D4501: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool.
The build plan is ambiguous, so I trust you did both make and ninja
Nov 20 2019
Nov 20 2019
Removed envp
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.
Bail instead of resetting local commits.
Also fixed some bugs.
jasonbcox added inline comments to D4279: Added autopatch script for patching and rebasing phabricator diffs.
jasonbcox planned changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.
Fixed shellcheck warning
jasonbcox planned changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.
Fix origin/${BRANCH} -> ${REMOTE}/${BRANCH} so that any remote and branch name combination can work.
jasonbcox planned changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
Use ForceSetArg() instead of ParseParameters()
In D4474#108521, @deadalnix wrote:What about using this: https://www.boost.org/doc/libs/1_71_0/libs/test/doc/html/boost_test/runtime_config/custom_command_line_arguments.html ?
You can then setup gArgs as you want it to in BasicTestingSetup.
jasonbcox added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
A release has gone out, but the fix wasn't included. I'm urging them to give us an actual ETA, because we need to land this soon.
Added all boost runtime params to the whitelist
jasonbcox committed rABC1d290e5f49b7: Use local instance of ArgsManager in getarg_tests (authored by jasonbcox).
Use local instance of ArgsManager in getarg_tests
Nov 19 2019
Nov 19 2019