Page MenuHomePhabricator
Feed Advanced Search

Feb 3 2021

PiRK accepted D9144: [Cashtab] Patch validation error preventing send of amounts with less than 8 decimal places.
Feb 3 2021, 15:18
PiRK closed D9143: test: explicit imports from test_framework.messages in p2p_invalid_messages.py.
Feb 3 2021, 15:18
PiRK committed rABC3bf72f599da8: test: explicit imports from test_framework.messages in p2p_invalid_messages.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: explicit imports from test_framework.messages in p2p_invalid_messages.py
Feb 3 2021, 15:18
PiRK requested review of D9145: Add test for param interaction b/w -blocksonly and -whitelistforcerelay.
Feb 3 2021, 15:01
PiRK closed D9142: test: use inventory type constant MSG_CMPCT_BLOCK.
Feb 3 2021, 14:29
PiRK committed rABC6791b7f377cf: test: use inventory type constant MSG_CMPCT_BLOCK (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: use inventory type constant MSG_CMPCT_BLOCK
Feb 3 2021, 14:29
PiRK closed D9141: test: replace inv type magic numbers by constants.
Feb 3 2021, 14:27
PiRK committed rABCdb264f0835be: test: replace inv type magic numbers by constants (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: replace inv type magic numbers by constants
Feb 3 2021, 14:27
PiRK accepted D9140: Disallow automatic conversion between disparate hash types.
Feb 3 2021, 14:24
PiRK closed D9138: net: Remove un-actionable TODO.
Feb 3 2021, 14:15
PiRK committed rABCd9bec55622b2: net: Remove un-actionable TODO (authored by MarcoFalke <falke.marco@gmail.com>).
net: Remove un-actionable TODO
Feb 3 2021, 14:15
PiRK updated the summary of D9143: test: explicit imports from test_framework.messages in p2p_invalid_messages.py.
Feb 3 2021, 14:04
PiRK requested review of D9143: test: explicit imports from test_framework.messages in p2p_invalid_messages.py.
Feb 3 2021, 14:03
PiRK requested review of D9142: test: use inventory type constant MSG_CMPCT_BLOCK.
Feb 3 2021, 13:57
PiRK requested review of D9141: test: replace inv type magic numbers by constants.
Feb 3 2021, 13:54
PiRK requested review of D9138: net: Remove un-actionable TODO.
Feb 3 2021, 13:08
PiRK closed D9137: log: Remove "No rpcpassword set" from logs.
Feb 3 2021, 12:40
PiRK committed rABCba4e8e9d97a7: log: Remove "No rpcpassword set" from logs (authored by MarcoFalke <falke.marco@gmail.com>).
log: Remove "No rpcpassword set" from logs
Feb 3 2021, 12:40
PiRK accepted D8350: Fix rpc_bind flakiness.
Feb 3 2021, 12:19
PiRK requested review of D9137: log: Remove "No rpcpassword set" from logs.
Feb 3 2021, 11:15

Feb 2 2021

PiRK accepted D9115: [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition.
Feb 2 2021, 07:38

Feb 1 2021

PiRK closed D9125: test: Add capability to disable RPC timeout in functional tests..
Feb 1 2021, 17:14
PiRK committed rABCf647670d9a74: test: Add capability to disable RPC timeout in functional tests. (authored by codeShark149 <rajarshi149@gmail.com>).
test: Add capability to disable RPC timeout in functional tests.
Feb 1 2021, 17:14
PiRK added inline comments to D9126: scripted-diff: TxoutType C++11 scoped enum class.
Feb 1 2021, 17:13
PiRK accepted D9124: refactor: Replace const char* to std::string.
Feb 1 2021, 17:00
PiRK requested review of D9125: test: Add capability to disable RPC timeout in functional tests..
Feb 1 2021, 15:18
PiRK accepted D9123: tests: Add fuzzing harness for CHash{160,256}, C{HMAC_,}SHA{1,256,512}, CRIPEMD160, CSipHasher, etc..
Feb 1 2021, 14:45
PiRK accepted D9122: refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o).
Feb 1 2021, 14:44
PiRK closed D9119: avoided os-dependant path.
Feb 1 2021, 13:29
PiRK committed rABCd733ebb73f87: avoided os-dependant path (authored by Ferdinando M. Ametrano <fametrano@users.noreply.github.com>).
avoided os-dependant path
Feb 1 2021, 13:29
PiRK accepted D9117: tests: Add fuzzing harness for {Read,Write}{LE,BE}{16,32,64} (crypto/common.h).
Feb 1 2021, 13:24
PiRK closed D9116: test: Remove const to work around compiler error on xenial.
Feb 1 2021, 10:58
PiRK committed rABC7e535aabd808: test: Remove const to work around compiler error on xenial (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
test: Remove const to work around compiler error on xenial
Feb 1 2021, 10:57
PiRK closed D9118: Add templated GetRandomDuration<>.
Feb 1 2021, 10:51
PiRK committed rABC6731f60abe1a: Add templated GetRandomDuration<> (authored by MarcoFalke <falke.marco@gmail.com>).
Add templated GetRandomDuration<>
Feb 1 2021, 10:51
PiRK accepted D9120: Fix abc_p2p_fullblocktest timeout with TSAN.
Feb 1 2021, 10:50
PiRK requested review of D9119: avoided os-dependant path.
Feb 1 2021, 09:19
PiRK requested review of D9118: Add templated GetRandomDuration<>.
Feb 1 2021, 09:11
PiRK closed D9113: [net processing] Only send a getheaders for one block in an INV.
Feb 1 2021, 08:47
PiRK committed rABCba0016fcc62e: [net processing] Only send a getheaders for one block in an INV (authored by John Newbery <john@johnnewbery.com>).
[net processing] Only send a getheaders for one block in an INV
Feb 1 2021, 08:47
PiRK requested review of D9116: test: Remove const to work around compiler error on xenial.
Feb 1 2021, 08:38
PiRK updated the test plan for D9110: build: warn on potentially uninitialized reads.
Feb 1 2021, 07:06
PiRK requested changes to D9115: [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition.
Feb 1 2021, 06:27

Jan 31 2021

PiRK accepted D9114: [backport#14785] Scripts: Fix detection of copyright holders.
Jan 31 2021, 19:53
PiRK updated the diff for D9113: [net processing] Only send a getheaders for one block in an INV.

use a std::optional<BlockHash> and std::move

Jan 31 2021, 17:13
PiRK added inline comments to D9113: [net processing] Only send a getheaders for one block in an INV.
Jan 31 2021, 17:13

Jan 29 2021

PiRK closed D9112: rpcwallet: Replace pwallet-> with wallet..
Jan 29 2021, 17:49
PiRK committed rABC430c7599fc38: rpcwallet: Replace pwallet-> with wallet. (authored by MarcoFalke <falke.marco@gmail.com>).
rpcwallet: Replace pwallet-> with wallet.
Jan 29 2021, 17:49
PiRK updated the summary of D9112: rpcwallet: Replace pwallet-> with wallet..
Jan 29 2021, 17:40
PiRK requested review of D9113: [net processing] Only send a getheaders for one block in an INV.
Jan 29 2021, 17:37
PiRK updated the summary of D9112: rpcwallet: Replace pwallet-> with wallet..
Jan 29 2021, 16:48
PiRK requested review of D9112: rpcwallet: Replace pwallet-> with wallet..
Jan 29 2021, 16:45
PiRK accepted D9111: tests: Add fuzzing harnesses for functions in script/.
Jan 29 2021, 14:31
PiRK planned changes to D9110: build: warn on potentially uninitialized reads.
Jan 29 2021, 12:00
PiRK added a comment to D9110: build: warn on potentially uninitialized reads.

Working on submitting a patch upstream (secp256k1)

Jan 29 2021, 10:57
PiRK requested review of D9110: build: warn on potentially uninitialized reads.
Jan 29 2021, 09:27

Jan 28 2021

PiRK accepted D9109: build: ensure we aren't using GNU extensions.
Jan 28 2021, 19:45
PiRK closed D9099: refactor: Cleanup clientversion.cpp.
Jan 28 2021, 17:05
PiRK committed rABC67d04b398ced: refactor: Cleanup clientversion.cpp (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Cleanup clientversion.cpp
Jan 28 2021, 17:05
PiRK closed D9105: miner: Avoid stack-use-after-return in validationinterface.
Jan 28 2021, 17:04
PiRK committed rABCb3681986e349: miner: Avoid stack-use-after-return in validationinterface (authored by MarcoFalke <falke.marco@gmail.com>).
miner: Avoid stack-use-after-return in validationinterface
Jan 28 2021, 17:04
PiRK closed D9104: test: Remove UninterruptibleSleep from test and replace it by SyncWithValidationInterfaceQueue.
Jan 28 2021, 17:03
PiRK committed rABC66c052d5279f: test: Remove UninterruptibleSleep from test and replace it by… (authored by MarcoFalke <falke.marco@gmail.com>).
test: Remove UninterruptibleSleep from test and replace it by…
Jan 28 2021, 17:03
PiRK closed D9103: validationinterface: Rework documentation, Rename pwalletIn to callbacks.
Jan 28 2021, 16:59
PiRK committed rABC5db69d6d3877: validationinterface: Rework documentation, Rename pwalletIn to callbacks (authored by MarcoFalke <falke.marco@gmail.com>).
validationinterface: Rework documentation, Rename pwalletIn to callbacks
Jan 28 2021, 16:59
PiRK closed D9107: remove NETWORK_NAME.
Jan 28 2021, 16:57
PiRK committed rABC5ee8dcba43aa: remove NETWORK_NAME (authored by PiRK).
remove NETWORK_NAME
Jan 28 2021, 16:57
PiRK updated the diff for D9105: miner: Avoid stack-use-after-return in validationinterface.

rename inner sub to subscriber to avoid a shadow warning

Jan 28 2021, 15:53
PiRK requested review of D9107: remove NETWORK_NAME.
Jan 28 2021, 15:37
teamcity awarded D9099: refactor: Cleanup clientversion.cpp a Haypence token.
Jan 28 2021, 15:23
PiRK added a comment to D9099: refactor: Cleanup clientversion.cpp.

@bot gitian-linux gitian-osx gitian-win

Jan 28 2021, 15:23
PiRK updated the test plan for D9099: refactor: Cleanup clientversion.cpp.
Jan 28 2021, 15:22
PiRK updated the diff for D9099: refactor: Cleanup clientversion.cpp.

remove the CLIENT_VERSION_BUILD part that is not used for ABC

Jan 28 2021, 15:20
PiRK planned changes to D9101: test: Remove RPCOverloadWrapper boilerplate.

Needs to be rebased and completed after PR16528 is finished (missing the createwallet method)

Jan 28 2021, 14:41
PiRK updated the summary of D9105: miner: Avoid stack-use-after-return in validationinterface.
Jan 28 2021, 14:34
PiRK updated the summary of D9105: miner: Avoid stack-use-after-return in validationinterface.
Jan 28 2021, 14:33
PiRK updated the summary of D9104: test: Remove UninterruptibleSleep from test and replace it by SyncWithValidationInterfaceQueue.
Jan 28 2021, 14:32
PiRK requested review of D9105: miner: Avoid stack-use-after-return in validationinterface.
Jan 28 2021, 14:32
PiRK requested review of D9104: test: Remove UninterruptibleSleep from test and replace it by SyncWithValidationInterfaceQueue.
Jan 28 2021, 14:29
PiRK requested review of D9103: validationinterface: Rework documentation, Rename pwalletIn to callbacks.
Jan 28 2021, 14:28
PiRK requested review of D9101: test: Remove RPCOverloadWrapper boilerplate.
Jan 28 2021, 13:18
PiRK closed D9096: p2p: add MAX_FEELER_CONNECTIONS.
Jan 28 2021, 12:24
PiRK committed rABC2af1d6f3b1da: p2p: add MAX_FEELER_CONNECTIONS (authored by tryphe <tryphe@noreply.github.com>).
p2p: add MAX_FEELER_CONNECTIONS
Jan 28 2021, 12:24
PiRK closed D9097: gui: Fix itemWalletAddress leak when not tree mode.
Jan 28 2021, 12:18
PiRK committed rABC225d8df38a4b: gui: Fix itemWalletAddress leak when not tree mode (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
gui: Fix itemWalletAddress leak when not tree mode
Jan 28 2021, 12:18
PiRK closed D9093: [doc] Add a link from ZMQ doc to ZMQ example in contrib/.
Jan 28 2021, 12:10
PiRK committed rABC08cbbb97b833: [doc] Add a link from ZMQ doc to ZMQ example in contrib/ (authored by meeDamian).
[doc] Add a link from ZMQ doc to ZMQ example in contrib/
Jan 28 2021, 12:10
PiRK closed D9098: gui: Fix manual coin control with multiple wallets loaded.
Jan 28 2021, 11:08
PiRK committed rABCb6b0d79d2491: gui: Fix manual coin control with multiple wallets loaded (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
gui: Fix manual coin control with multiple wallets loaded
Jan 28 2021, 11:07
PiRK closed D9094: net: use CMessageHeader::HEADER_SIZE, add missing include.
Jan 28 2021, 10:58
PiRK committed rABC52644a5e025e: net: use CMessageHeader::HEADER_SIZE, add missing include (authored by Jon Atack <jon@atack.com>).
net: use CMessageHeader::HEADER_SIZE, add missing include
Jan 28 2021, 10:58
PiRK updated the test plan for D9099: refactor: Cleanup clientversion.cpp.
Jan 28 2021, 10:53
PiRK updated the diff for D9096: p2p: add MAX_FEELER_CONNECTIONS.

rebase

Jan 28 2021, 10:52
PiRK updated the diff for D9097: gui: Fix itemWalletAddress leak when not tree mode.

rebase

Jan 28 2021, 10:52
PiRK updated the diff for D9093: [doc] Add a link from ZMQ doc to ZMQ example in contrib/.

rebase

Jan 28 2021, 10:50
PiRK requested review of D9099: refactor: Cleanup clientversion.cpp.
Jan 28 2021, 10:49
PiRK updated the diff for D9094: net: use CMessageHeader::HEADER_SIZE, add missing include.

rebase

Jan 28 2021, 09:58
PiRK requested review of D9098: gui: Fix manual coin control with multiple wallets loaded.
Jan 28 2021, 09:52
PiRK closed D9086: [docs] Improve commenting in ProcessGetData().
Jan 28 2021, 08:48
PiRK committed rABCa28207584448: [docs] Improve commenting in ProcessGetData() (authored by John Newbery <john@johnnewbery.com>).
[docs] Improve commenting in ProcessGetData()
Jan 28 2021, 08:48