Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Thu, Apr 11

PiRK accepted D15943: [ecash_lib_wasm] Exclude from the workspace.

Thu, Apr 11, 10:09

PiRK updated the diff for D15936: Remove unused char serialize.

rebase

Thu, Apr 11, 07:05

PiRK updated the diff for D15935: Use spans of std::byte in serialize.

rebase

Thu, Apr 11, 07:04

PiRK updated the diff for D15934: span: Add BytePtr helper.

rebase

Thu, Apr 11, 06:53

PiRK updated the diff for D15933: refactor: [index] Replace deprecated char with uint8_t in serialization.

rebase

Thu, Apr 11, 06:52

Wed, Apr 10

PiRK added a comment to D15920: [Cashtab] Upgrade tx parsing.

In D15920#360352, @bytesofman wrote:

Note: investigating this CI failure, which is also happening on other diffs

./contrib/teamcity/build-configurations.py cashtab-tests is working locally

Wed, Apr 10, 19:15

PiRK requested review of D15936: Remove unused char serialize.

Wed, Apr 10, 15:14

PiRK updated the summary of D15935: Use spans of std::byte in serialize.

Wed, Apr 10, 15:06

PiRK requested review of D15935: Use spans of std::byte in serialize.

Wed, Apr 10, 15:05

PiRK requested review of D15934: span: Add BytePtr helper.

Wed, Apr 10, 15:03

PiRK requested review of D15933: refactor: [index] Replace deprecated char with uint8_t in serialization.

Wed, Apr 10, 14:44

PiRK closed D15929: refactor: Switch serialize to uint8_t.

Wed, Apr 10, 14:34

PiRK committed rABC6226c274e3be: refactor: Switch serialize to uint8_t (authored by MarcoFalke <falke.marco@gmail.com>).

refactor: Switch serialize to uint8_t

Wed, Apr 10, 14:34

PiRK accepted D15932: [ecash-lib] CI improvements for typescript projects.

Wed, Apr 10, 08:47

Tue, Apr 9

PiRK requested review of D15929: refactor: Switch serialize to uint8_t.

Tue, Apr 9, 14:58

PiRK closed D15927: tests: remove flaky mocktime test.

Tue, Apr 9, 12:08

PiRK committed rABCb132af74fbce: tests: remove flaky mocktime test (authored by PiRK).

tests: remove flaky mocktime test

Tue, Apr 9, 12:08

PiRK requested review of D15927: tests: remove flaky mocktime test.

Tue, Apr 9, 10:39

PiRK abandoned D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.

This would work only for my linux machine. Ideally the max value should be computed for each system ( std::chrono::system_clock::now().max() * std::chrono::system_clock::period), but that is overkill for a test RPC.

Tue, Apr 9, 10:30

PiRK updated the summary of D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.

Tue, Apr 9, 09:25

PiRK updated the diff for D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.

add a check for the upper limit in the RPC command, test it

Tue, Apr 9, 09:24

PiRK planned changes to D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.

Let's have the RPC return an error also, to guard against future flaky tests caused by overflows.

Tue, Apr 9, 09:13

PiRK updated the test plan for D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.

Tue, Apr 9, 09:05

PiRK requested review of D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.

Tue, Apr 9, 09:03

PiRK added a comment to D15921: [Chronik] Add LOKAD ID index.

Test coverage looks good and afaict the code is correct. I can't really review the API itself, I'm not in the loop regarding the intended use cases.

Tue, Apr 9, 08:01

Mon, Apr 8

PiRK closed D15905: Remove unused CDataStream methods.

Mon, Apr 8, 15:10

PiRK committed rABC30f5fdfc2a99: Remove unused CDataStream methods (authored by PiRK).

Remove unused CDataStream methods

Mon, Apr 8, 15:10

Apr 5 2024

PiRK closed D15907: [electrum] push notification for release 5.2.12.

Apr 5 2024, 21:08

PiRK committed rABCe6d49c9dae4f: [electrum] push notification for release 5.2.12 (authored by PiRK).

[electrum] push notification for release 5.2.12

Apr 5 2024, 21:08

PiRK requested review of D15907: [electrum] push notification for release 5.2.12.

Apr 5 2024, 13:58

PiRK closed D15903: Generalize/simplify VectorReader into SpanReader.

Apr 5 2024, 13:50

PiRK committed rABC23ac3f84c939: Generalize/simplify VectorReader into SpanReader (authored by Pieter Wuille <pieter@wuille.net>).

Generalize/simplify VectorReader into SpanReader

Apr 5 2024, 13:50

PiRK updated the summary of D15905: Remove unused CDataStream methods.

Apr 5 2024, 13:30

PiRK requested review of D15905: Remove unused CDataStream methods.

Apr 5 2024, 13:29

PiRK closed D15902: scripted-diff: Move bloom to src/common.

Apr 5 2024, 12:40

PiRK committed rABC9180dfe4aa82: scripted-diff: Move bloom to src/common (authored by PiRK).

scripted-diff: Move bloom to src/common

Apr 5 2024, 12:40

PiRK closed D15901: bloom: use Span instead of std::vector for `insert` and `contains`.

Apr 5 2024, 12:40

PiRK committed rABCae2feb449f1d: bloom: use Span instead of std::vector for `insert` and `contains` (authored by William Casarin <jb55@jb55.com>).

bloom: use Span instead of std::vector for `insert` and `contains`

Apr 5 2024, 12:40

PiRK requested review of D15903: Generalize/simplify VectorReader into SpanReader.

Apr 5 2024, 11:04

PiRK updated the diff for D15902: scripted-diff: Move bloom to src/common.

rebase

Apr 5 2024, 10:55

PiRK updated the diff for D15901: bloom: use Span instead of std::vector for `insert` and `contains`.

rebase

Apr 5 2024, 10:55

PiRK added a comment to D15901: bloom: use Span instead of std::vector for `insert` and `contains`.

In D15901#359396, @teamcity wrote:
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:
====== Bitcoin ABC functional tests: abc_rpc_mocktime.py ======

Apr 5 2024, 09:31

PiRK requested review of D15902: scripted-diff: Move bloom to src/common.

Apr 5 2024, 08:53

PiRK requested review of D15901: bloom: use Span instead of std::vector for `insert` and `contains`.

Apr 5 2024, 08:47

PiRK accepted D15900: Improve release note for 0.29.1.

Apr 5 2024, 07:34

PiRK accepted D15899: [net] Don't create outbound connection to the same ip as an inbound.

Apr 5 2024, 07:31

PiRK accepted D15898: Bump version to 0.29.1.

Apr 5 2024, 07:26

Apr 4 2024

PiRK closed D15859: span: Add std::byte helpers.

Apr 4 2024, 15:14

PiRK committed rABCd97242ade07e: span: Add std::byte helpers (authored by MarcoFalke <falke.marco@gmail.com>).

span: Add std::byte helpers

Apr 4 2024, 15:14

PiRK closed D15858: refactor: Use ignore helper when unserializing an invalid pubkey.

Apr 4 2024, 15:14

PiRK committed rABC5ad88878f816: refactor: Use ignore helper when unserializing an invalid pubkey (authored by MarcoFalke <falke.marco@gmail.com>).

refactor: Use ignore helper when unserializing an invalid pubkey

Apr 4 2024, 15:14

PiRK closed D15857: Use value_type in CDataStream where possible.

Apr 4 2024, 15:14

PiRK committed rABCd88558168af1: Use value_type in CDataStream where possible (authored by MarcoFalke <falke.marco@gmail.com>).

Use value_type in CDataStream where possible

Apr 4 2024, 15:14

PiRK closed D15885: [electrum] build: fix incompatible dependencies.

Apr 4 2024, 08:03

PiRK committed rABC1c890885e27e: [electrum] build: fix incompatible dependencies (authored by PiRK).

[electrum] build: fix incompatible dependencies

Apr 4 2024, 08:03

PiRK requested review of D15885: [electrum] build: fix incompatible dependencies.

Apr 4 2024, 07:13

Apr 3 2024

PiRK closed D15873: [electrum] Bump version to 5.2.12 and add release notes.

Apr 3 2024, 14:36

PiRK committed rABC35b8201a4d31: [electrum] Bump version to 5.2.12 and add release notes (authored by PiRK).

[electrum] Bump version to 5.2.12 and add release notes

Apr 3 2024, 14:36

PiRK closed D15872: [electrum] Progress on AppImage reproducibility.

Apr 3 2024, 14:36

PiRK closed D15871: [electrum] Use native architecture when building on macos.

Apr 3 2024, 14:36

PiRK committed rABC3523f2d225d1: [electrum] Progress on AppImage reproducibility (authored by EchterAgo).

[electrum] Progress on AppImage reproducibility

Apr 3 2024, 14:36

PiRK committed rABCf0d661a5be7e: [electrum] Use native architecture when building on macos (authored by Dustin Henning <ghrptr@mynym.us>).

[electrum] Use native architecture when building on macos

Apr 3 2024, 14:36

PiRK closed D15868: [electrum] build: remove deprecated apt-key for winehq key.

Apr 3 2024, 14:36

PiRK closed D15870: [electrum] bump python dependencies.

Apr 3 2024, 14:36

PiRK committed rABC060cdc152e93: [electrum] bump python dependencies (authored by EchterAgo).

[electrum] bump python dependencies

Apr 3 2024, 14:36

PiRK committed rABC3e26da4561f2: [electrum] build: remove deprecated apt-key for winehq key (authored by EchterAgo).

[electrum] build: remove deprecated apt-key for winehq key

Apr 3 2024, 14:36

PiRK accepted D15875: [doc] Update the release process to use GUIX instead of Gitian.

Apr 3 2024, 14:35

PiRK updated the diff for D15873: [electrum] Bump version to 5.2.12 and add release notes.

rebase after moving the unrelated change to where it belongs (D15872)

Apr 3 2024, 13:34

PiRK updated the diff for D15872: [electrum] Progress on AppImage reproducibility.

this was missing the filter_deps bash function, accidentaly amended to D15873

Apr 3 2024, 13:33

PiRK requested review of D15873: [electrum] Bump version to 5.2.12 and add release notes.

Apr 3 2024, 13:30

PiRK requested review of D15872: [electrum] Progress on AppImage reproducibility.

Apr 3 2024, 13:28

PiRK requested review of D15871: [electrum] Use native architecture when building on macos.

Apr 3 2024, 13:26

PiRK updated the summary of D15870: [electrum] bump python dependencies.

Apr 3 2024, 13:25

PiRK requested review of D15870: [electrum] bump python dependencies.

Apr 3 2024, 13:24

PiRK requested review of D15868: [electrum] build: remove deprecated apt-key for winehq key.

Apr 3 2024, 13:07

PiRK accepted D15842: [avalanche] Increase the delay for a proof to be eligible to staking rewards.

Apr 3 2024, 08:17

PiRK accepted D15791: [avalanche] Account for network propagation time for staking rewards.

Apr 3 2024, 08:14

PiRK requested review of D15857: Use value_type in CDataStream where possible.

Apr 3 2024, 07:45

PiRK requested review of D15858: refactor: Use ignore helper when unserializing an invalid pubkey.

Apr 3 2024, 07:45

PiRK added inline comments to D15859: span: Add std::byte helpers.

Apr 3 2024, 07:44

PiRK published D15859: span: Add std::byte helpers for review.

Apr 3 2024, 07:43

Apr 2 2024

PiRK closed D15849: [electrum] add the option to always add new addresses to wallet when scanning beyond gap.

Apr 2 2024, 19:41

PiRK committed rABCe0f63054e494: [electrum] add the option to always add new addresses to wallet when scanning… (authored by PiRK).

[electrum] add the option to always add new addresses to wallet when scanning…

Apr 2 2024, 19:41

PiRK planned changes to D15857: Use value_type in CDataStream where possible.

Apr 2 2024, 16:02

PiRK added a comment to D15857: Use value_type in CDataStream where possible.

still working on an issue in the last commit of the PR, let's wait before reviewing this

Apr 2 2024, 16:02

PiRK planned changes to D15858: refactor: Use ignore helper when unserializing an invalid pubkey.

still working on an issue in the last commit of the PR, let's wait before working on this

Apr 2 2024, 16:01

PiRK requested review of D15858: refactor: Use ignore helper when unserializing an invalid pubkey.

Apr 2 2024, 15:54

PiRK added inline comments to D15857: Use value_type in CDataStream where possible.

Apr 2 2024, 15:53

PiRK requested review of D15857: Use value_type in CDataStream where possible.

Apr 2 2024, 15:52

PiRK accepted D15856: Bump replay protection to November 2024.

Apr 2 2024, 15:04

PiRK accepted D15855: Bump version to 0.29.0.

Apr 2 2024, 14:51

PiRK accepted D15854: Bump the minimum block count for makeseeds.py.

Apr 2 2024, 14:50

PiRK updated the diff for D15849: [electrum] add the option to always add new addresses to wallet when scanning beyond gap.

No need for the intermediate vars

Apr 2 2024, 13:40

PiRK closed D15848: [electrum] minor cleanup of scan_beyond_gap.py.

Apr 2 2024, 13:35

PiRK committed rABC6e471bcdf70a: [electrum] minor cleanup of scan_beyond_gap.py (authored by PiRK).

[electrum] minor cleanup of scan_beyond_gap.py

Apr 2 2024, 13:35

PiRK accepted D15850: [net] Consistently check for existing connection based on ip:port.

Apr 2 2024, 12:49

PiRK updated the summary of D15849: [electrum] add the option to always add new addresses to wallet when scanning beyond gap.

Apr 2 2024, 12:45

PiRK accepted D15852: Bump makeseeds version filter.

Apr 2 2024, 11:59

PiRK accepted D15851: [website] Show 0.29.x versions on the release page.

Apr 2 2024, 11:59

PiRK requested review of D15849: [electrum] add the option to always add new addresses to wallet when scanning beyond gap.

Apr 2 2024, 09:12