Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Feb 26 2020

Fabien updated the diff for D5333: [CMAKE] Fix build with make as a generator.

Remove space.

Feb 26 2020, 19:09
jasonbcox accepted D5326: build: update RapidCheck Makefile.
Feb 26 2020, 19:09
Fabien added inline comments to D5333: [CMAKE] Fix build with make as a generator.
Feb 26 2020, 19:08
jasonbcox accepted D5325: build: dont compile rapidcheck with -Wall.
Feb 26 2020, 19:07
jasonbcox accepted D5324: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS.
Feb 26 2020, 19:04
Fabien updated the test plan for D5333: [CMAKE] Fix build with make as a generator.
Feb 26 2020, 18:58
teamcity added a comment to D5330: Add update-manpages to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 18:35
teamcity added a comment to D5330: Add update-manpages to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 18:16
jasonbcox updated the diff for D5330: Add update-manpages to automated-commits.

Addressed feedback

Feb 26 2020, 18:06
deadalnix accepted D5334: [CI] Run the cmake build with make as a generator.
Feb 26 2020, 18:02
deadalnix added inline comments to D5334: [CI] Run the cmake build with make as a generator.
Feb 26 2020, 18:02
jasonbcox accepted D5323: Integration of property based testing into Bitcoin ABC.
Feb 26 2020, 17:59
jasonbcox added inline comments to D5330: Add update-manpages to automated-commits.
Feb 26 2020, 17:37
jasonbcox committed rABCd5771bf781e3: Add update-seeds to automated-commits (authored by jasonbcox).
Add update-seeds to automated-commits
Feb 26 2020, 17:27
jasonbcox closed D5248: Add update-seeds to automated-commits.
Feb 26 2020, 17:27
jasonbcox committed rABCdf981eb91387: [automated-commits] Make sure BUILD_DIR exists and is exported (authored by jasonbcox).
[automated-commits] Make sure BUILD_DIR exists and is exported
Feb 26 2020, 17:25
jasonbcox closed D5331: [automated-commits] Make sure BUILD_DIR exists and is exported.
Feb 26 2020, 17:25
jasonbcox committed rABC48e96fc81347: Bump version to 0.21.1 (authored by jasonbcox).
Bump version to 0.21.1
Feb 26 2020, 17:25
jasonbcox closed D5332: Bump version to 0.21.1.
Feb 26 2020, 17:24
deadalnix added a comment to D5333: [CMAKE] Fix build with make as a generator.

You need to fix you test plan, it's not displaying right.

Feb 26 2020, 16:54
deadalnix requested changes to D5333: [CMAKE] Fix build with make as a generator.
Feb 26 2020, 16:51
teamcity added a comment to D5323: Integration of property based testing into Bitcoin ABC.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 15:49
teamcity added a comment to D5323: Integration of property based testing into Bitcoin ABC.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 15:39
Fabien updated the diff for D5323: Integration of property based testing into Bitcoin ABC.

Avoid duplicated if().

Feb 26 2020, 15:39
Fabien accepted D5332: Bump version to 0.21.1.
Feb 26 2020, 15:23
Fabien accepted D5331: [automated-commits] Make sure BUILD_DIR exists and is exported.
Feb 26 2020, 15:20
Fabien requested changes to D5330: Add update-manpages to automated-commits.
Feb 26 2020, 15:20
Fabien accepted D5248: Add update-seeds to automated-commits.
Feb 26 2020, 15:08
Fabien requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Feb 26 2020, 15:02
teamcity added a comment to D5323: Integration of property based testing into Bitcoin ABC.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 14:25
teamcity added a comment to D5323: Integration of property based testing into Bitcoin ABC.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 14:15
Fabien updated the diff for D5323: Integration of property based testing into Bitcoin ABC.

Fix typo and link the github issue.

Feb 26 2020, 14:15
Fabien updated the test plan for D5323: Integration of property based testing into Bitcoin ABC.
Feb 26 2020, 14:13
Fabien updated the test plan for D5323: Integration of property based testing into Bitcoin ABC.
Feb 26 2020, 14:11
teamcity added a comment to D5334: [CI] Run the cmake build with make as a generator.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 14:02
teamcity added a comment to D5334: [CI] Run the cmake build with make as a generator.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 13:52
Fabien created D5334: [CI] Run the cmake build with make as a generator.
Feb 26 2020, 13:52
teamcity added a comment to D5333: [CMAKE] Fix build with make as a generator.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 13:36
teamcity added a comment to D5333: [CMAKE] Fix build with make as a generator.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 13:27
Fabien created D5333: [CMAKE] Fix build with make as a generator.
Feb 26 2020, 13:26
Fabien added inline comments to D5323: Integration of property based testing into Bitcoin ABC.
Feb 26 2020, 12:26
teamcity added a comment to D5332: Bump version to 0.21.1.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 01:08
teamcity added a comment to D5332: Bump version to 0.21.1.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 00:57
jasonbcox created D5332: Bump version to 0.21.1.
Feb 26 2020, 00:57
jasonbcox accepted D5328: Label length unit tests for parse_name().
Feb 26 2020, 00:53
teamcity added a comment to D5330: Add update-manpages to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 00:53
jasonbcox accepted D5329: Enforce maximum name length for parse_name() and add unit tests.
Feb 26 2020, 00:51
teamcity added a comment to D5330: Add update-manpages to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 00:43
jasonbcox updated the diff for D5330: Add update-manpages to automated-commits.

Rebase

Feb 26 2020, 00:43
teamcity added a comment to D5248: Add update-seeds to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 00:43
teamcity added a comment to D5248: Add update-seeds to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 26 2020, 00:33
jasonbcox updated the summary of D5248: Add update-seeds to automated-commits.
Feb 26 2020, 00:33
jasonbcox updated the diff for D5248: Add update-seeds to automated-commits.

Fixed build and addressed feedback

Feb 26 2020, 00:33
teamcity added a comment to D5331: [automated-commits] Make sure BUILD_DIR exists and is exported.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 26 2020, 00:06

Feb 25 2020

teamcity added a comment to D5331: [automated-commits] Make sure BUILD_DIR exists and is exported.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 23:57
jasonbcox created D5331: [automated-commits] Make sure BUILD_DIR exists and is exported.
Feb 25 2020, 23:56
teamcity added a comment to D5330: Add update-manpages to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 23:50
jasonbcox planned changes to D5330: Add update-manpages to automated-commits.
Feb 25 2020, 23:45
teamcity added a comment to D5330: Add update-manpages to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 23:40
jasonbcox created D5330: Add update-manpages to automated-commits.
Feb 25 2020, 23:40
teamcity added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 23:24
teamcity added a comment to D5328: Label length unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 23:22
teamcity added a comment to D5328: Label length unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 23:12
nakihito updated the diff for D5328: Label length unit tests for parse_name().

Added const and removed unnecessary check.

Feb 25 2020, 23:12
teamcity added a comment to D5328: Label length unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 23:10
teamcity added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 23:08
nakihito updated the diff for D5329: Enforce maximum name length for parse_name() and add unit tests.

Separated qname length tests from label tests.

Feb 25 2020, 23:08
jasonbcox requested changes to D5328: Label length unit tests for parse_name().
Feb 25 2020, 23:06
jasonbcox accepted D4418: Add simple unit tests for parse_name().
Feb 25 2020, 23:04
teamcity added a comment to D5328: Label length unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 23:01
nakihito updated the diff for D5328: Label length unit tests for parse_name().

Removed for-loop initialization.

Feb 25 2020, 23:01
jasonbcox added inline comments to D5328: Label length unit tests for parse_name().
Feb 25 2020, 22:59
jasonbcox requested changes to D5329: Enforce maximum name length for parse_name() and add unit tests.
Feb 25 2020, 22:57
jasonbcox requested changes to D5328: Label length unit tests for parse_name().
Feb 25 2020, 22:55
jasonbcox requested changes to D5323: Integration of property based testing into Bitcoin ABC.

Test plan is incomplete. Other than the nits and other comments, everything else looks good.

Feb 25 2020, 22:42
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 22:40
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 22:30
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Adjusted comments related to ADDR_SOFT_CAP, removed verack message test, and added additional check for the version test.

Feb 25 2020, 22:30
teamcity added a comment to D5091: Make parse_name() fail when passed buffer size = 0.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 22:14
teamcity added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 21:57
teamcity added a comment to D5091: Make parse_name() fail when passed buffer size = 0.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 21:51
nakihito updated the diff for D5091: Make parse_name() fail when passed buffer size = 0.

Rebased in light of changes to D4418.

Feb 25 2020, 21:51
nakihito abandoned D5241: Make parse_name() properly fail when the query name is longer than 255 characters.

Dropped in favor of D5329.

Feb 25 2020, 21:48
teamcity added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 21:48
nakihito created D5329: Enforce maximum name length for parse_name() and add unit tests.
Feb 25 2020, 21:48
teamcity added a comment to D5328: Label length unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 21:35
teamcity added a comment to D5328: Label length unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 21:25
nakihito created D5328: Label length unit tests for parse_name().
Feb 25 2020, 21:25
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 21:21
nakihito requested review of D4418: Add simple unit tests for parse_name().
Feb 25 2020, 21:21
nakihito retitled D4418: Add simple unit tests for parse_name() from Add unit tests for parse_name() to Add simple unit tests for parse_name().
Feb 25 2020, 21:13
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 21:12
nakihito planned changes to D4418: Add simple unit tests for parse_name().
Feb 25 2020, 21:11
nakihito updated the diff for D4418: Add simple unit tests for parse_name().

Cutting this diff into smaller pieces. Also split the second for loop in CheckParseName() into two separate loops to remove branching logic.

Feb 25 2020, 21:11
Fabien requested changes to D5248: Add update-seeds to automated-commits.
Feb 25 2020, 20:27
teamcity added a comment to D5248: Add update-seeds to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 25 2020, 20:04
teamcity added a comment to D5248: Add update-seeds to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 25 2020, 19:54
jasonbcox updated the diff for D5248: Add update-seeds to automated-commits.
  • Rebase
  • Decouple dependencies from CI
Feb 25 2020, 19:54
jasonbcox committed rABC9069cd7940fc: Make all automated commits run smoke tests prior to pushing (authored by jasonbcox).
Make all automated commits run smoke tests prior to pushing
Feb 25 2020, 19:07
jasonbcox closed D5270: Make all automated commits run smoke tests prior to pushing.
Feb 25 2020, 19:07
First
Prev
Next