Page MenuHomePhabricator
Feed All Stories

Fri, Dec 13

roqqit requested review of D17350: [seeder] Reword outdated note in readme.
Fri, Dec 13, 20:43
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

remove the small intermediate macros that only have one callsite. They just make the logic harder to follow.

Fri, Dec 13, 20:28
roqqit requested review of D17348: [seeder] Return an error when thread creation fails.
Fri, Dec 13, 20:27
roqqit requested review of D17349: [seeder] Bump thread stacksize.
Fri, Dec 13, 20:27
roqqit updated the test plan for D17349: [seeder] Bump thread stacksize.
Fri, Dec 13, 20:26
roqqit planned changes to D17348: [seeder] Return an error when thread creation fails.
Fri, Dec 13, 20:08
roqqit planned changes to D17349: [seeder] Bump thread stacksize.
Fri, Dec 13, 20:08
roqqit requested review of D17349: [seeder] Bump thread stacksize.
Fri, Dec 13, 20:08
roqqit requested review of D17348: [seeder] Return an error when thread creation fails.
Fri, Dec 13, 19:37
PiRK updated the summary of D17347: [chronik] add macros to extract params from a JSONRPC request.
Fri, Dec 13, 19:01
PiRK planned changes to D17347: [chronik] add macros to extract params from a JSONRPC request.

c'est cassé

Fri, Dec 13, 19:00
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Fri, Dec 13, 18:20
teamcity triaged T3704: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Fri, Dec 13, 18:06
Mengerian closed D17346: [e.cash] Open external button links in new tabs.
Fri, Dec 13, 18:00
Mengerian committed rABCaa32579dd498: [e.cash] Open external button links in new tabs (authored by Mengerian).
[e.cash] Open external button links in new tabs
Fri, Dec 13, 18:00
hazzarust updated the summary of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Fri, Dec 13, 17:00
hazzarust updated the summary of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Fri, Dec 13, 16:58
hazzarust updated the diff for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Updated everything in this diff - please see summary for more indepth

Fri, Dec 13, 16:51
teamcity added a comment to D17347: [chronik] add macros to extract params from a JSONRPC request.
Fri, Dec 13, 14:55
PiRK retitled D17347: [chronik] add macros to extract params from a JSONRPC request from [chronik] add templates to extract params from a JSONRPC request to [chronik] add macros to extract params from a JSONRPC request.
Fri, Dec 13, 14:40
PiRK added inline comments to D17347: [chronik] add macros to extract params from a JSONRPC request.
Fri, Dec 13, 14:34
PiRK requested review of D17347: [chronik] add macros to extract params from a JSONRPC request.
Fri, Dec 13, 14:32
PiRK published D17323: [chronik] add electrum method blockchain.transaction.get for review.
Fri, Dec 13, 13:35
PiRK added a task to D16571: [chronik] Add a struct to compute a block merkle tree: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D16756: [test framework] add a python implementation for merkle trees: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D16800: [chronik] better use the merkle tree cache: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D16806: [chronik] pass only required block hashes to merkle tree cache: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D17037: [chronik] index scripts by scripthashes in the mempool: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D16937: [chronik] add scripthash option to the various script endpoints: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D17043: [chronik] implement scripthash type for utxos endpoints: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D17325: [chronik] Bump karyon dependency to 0.1.8: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D17185: [chronik] Create a new optional JSON RPC interface: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK added a task to D17333: [chronik] Add support for TLS to the electrum server: Unknown Object (Maniphest Task).
Fri, Dec 13, 13:34
PiRK updated the summary of D17314: [chronik] add a test for the new JSON RPC interface.
Fri, Dec 13, 13:30
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Fri, Dec 13, 10:26
PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

rebase

Fri, Dec 13, 10:18
Fabien closed D17342: Wait for the disconnected peers to be accounted in the getavalancheinfo test.
Fri, Dec 13, 08:30
Fabien committed rABC1bca2c29c6ae: Wait for the disconnected peers to be accounted in the getavalancheinfo test (authored by Fabien).
Wait for the disconnected peers to be accounted in the getavalancheinfo test
Fri, Dec 13, 08:30
Fabien added a comment to D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.

waiting for len(getavalanchepeerinfo) == QUORUM_NODE_COUNT should be enough here

Fri, Dec 13, 08:28
Fabien requested changes to D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Fri, Dec 13, 08:22
PiRK accepted D17342: Wait for the disconnected peers to be accounted in the getavalancheinfo test.
Fri, Dec 13, 07:58
bytesofman accepted D17346: [e.cash] Open external button links in new tabs.
Fri, Dec 13, 06:25

Thu, Dec 12

Mengerian requested review of D17346: [e.cash] Open external button links in new tabs.
Thu, Dec 12, 22:19
Mengerian closed D17344: [e.cash] Add Pay2Stay to Use eCash page.
Thu, Dec 12, 22:08
Mengerian committed rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page (authored by Mengerian).
[e.cash] Add Pay2Stay to Use eCash page
Thu, Dec 12, 22:08
roqqit requested review of D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Thu, Dec 12, 22:08
Mengerian updated the diff for D17344: [e.cash] Add Pay2Stay to Use eCash page.

Open link in new tab
Change order

Thu, Dec 12, 22:03
Fabien added inline comments to D17344: [e.cash] Add Pay2Stay to Use eCash page.
Thu, Dec 12, 21:58
Mengerian updated subscribers of D17344: [e.cash] Add Pay2Stay to Use eCash page.

Any reason for the selected ordering ?

Thu, Dec 12, 21:54
Kronkmeister accepted D17344: [e.cash] Add Pay2Stay to Use eCash page.

tested and approved 💪

Thu, Dec 12, 21:48
Fabien added a comment to D17344: [e.cash] Add Pay2Stay to Use eCash page.

Any reason for the selected ordering ? Poker first then pay2stay then paybutton ?

Thu, Dec 12, 21:47
teamcity added a comment to D17344: [e.cash] Add Pay2Stay to Use eCash page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41084 for the next 60 minutes.

Thu, Dec 12, 21:42
teamcity awarded D17344: [e.cash] Add Pay2Stay to Use eCash page a Haypence token.
Thu, Dec 12, 21:41
Fabien added a comment to D17344: [e.cash] Add Pay2Stay to Use eCash page.

@bot preview-e.cash

Thu, Dec 12, 21:41
teamcity closed T3703: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Thu, Dec 12, 21:33
Mengerian requested review of D17344: [e.cash] Add Pay2Stay to Use eCash page.
Thu, Dec 12, 21:31
teamcity triaged T3703: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Thu, Dec 12, 20:51
Fabien closed D17343: [CI] Fix a type in the build configuration file.
Thu, Dec 12, 20:37
Fabien committed rABC2c16f87cbe8f: [CI] Fix a type in the build configuration file (authored by Fabien).
[CI] Fix a type in the build configuration file
Thu, Dec 12, 20:37
roqqit accepted D17343: [CI] Fix a type in the build configuration file.
Thu, Dec 12, 20:36
teamcity closed T3702: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Thu, Dec 12, 20:32
Fabien requested review of D17343: [CI] Fix a type in the build configuration file.
Thu, Dec 12, 20:30
Fabien requested review of D17342: Wait for the disconnected peers to be accounted in the getavalancheinfo test.
Thu, Dec 12, 20:27
Fabien closed D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:19
Fabien committed rABCde781d9db6de: [CI] Don't run the electrum tests in parallel of the functional tests (authored by Fabien).
[CI] Don't run the electrum tests in parallel of the functional tests
Thu, Dec 12, 20:19
roqqit accepted D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:18
Fabien updated the summary of D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:18
Fabien requested review of D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:16
teamcity closed T3701: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Resolved.
Thu, Dec 12, 17:45
teamcity triaged T3702: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Thu, Dec 12, 17:45
roqqit closed D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Thu, Dec 12, 17:34
roqqit committed rABC44da17657e7c: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup (authored by roqqit).
[avalanche] Restrict scope of cs_stakingRewards lock during cleanup
Thu, Dec 12, 17:34
teamcity triaged T3701: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
Thu, Dec 12, 15:25
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 15:04
bytesofman closed D17339: [mock-chronik-client] remember to bump the version.
Thu, Dec 12, 15:04
bytesofman committed rABC4ef363d2152a: [mock-chronik-client] remember to bump the version (authored by bytesofman).
[mock-chronik-client] remember to bump the version
Thu, Dec 12, 15:04
Fabien accepted D17314: [chronik] add a test for the new JSON RPC interface.
Thu, Dec 12, 14:55
PiRK accepted D17339: [mock-chronik-client] remember to bump the version.
Thu, Dec 12, 13:46
bytesofman published D17339: [mock-chronik-client] remember to bump the version for review.
Thu, Dec 12, 13:23
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

stop storing script and scriptHex as these can always be returned accurately by method

Thu, Dec 12, 13:22
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 13:21
bytesofman closed D17338: [mock-chronik-client] Remember to build before publishing.
Thu, Dec 12, 12:59
bytesofman committed rABC900af67082a6: [mock-chronik-client] Remember to build before publishing (authored by bytesofman).
[mock-chronik-client] Remember to build before publishing
Thu, Dec 12, 12:59
PiRK added inline comments to D17314: [chronik] add a test for the new JSON RPC interface.
Thu, Dec 12, 12:29
PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

raise an error if response data is too large, improve doc for ChronikElectrumClient with code samples, remove unneed id param for MethodNameProxy

Thu, Dec 12, 12:26
Fabien closed D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 12:13
Fabien committed rABC67384414e3f9: [chronik] Add support for TLS to the electrum server (authored by Fabien).
[chronik] Add support for TLS to the electrum server
Thu, Dec 12, 12:13
Sheima78 awarded T476: Write a script to automate the collection of gitian outputs a Yellow Medal token.
Thu, Dec 12, 11:38 · Restricted Project
tobias_ruck accepted D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 11:08
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Improve doc, var names and use .min()

Thu, Dec 12, 11:00
tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 10:37
Fabien accepted D17338: [mock-chronik-client] Remember to build before publishing.
Thu, Dec 12, 10:05
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 10:05
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 10:04
Fabien requested changes to D17337: [avalanche] Set local stake winner in the contender cache.

Questions more than requesting changes

Thu, Dec 12, 09:59
Fabien accepted D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Thu, Dec 12, 09:52
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Rebase

Thu, Dec 12, 09:50
teamcity added a comment to D17333: [chronik] Add support for TLS to the electrum server.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Thu, Dec 12, 09:47
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Feedback

Thu, Dec 12, 09:46