Page MenuHomePhabricator
Feed All Stories

May 25 2020

teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 21:00
Fabien updated the diff for D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Fix spaces/tabs mixup

May 25 2020, 20:59
deadalnix requested changes to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

You need to fix the cmake file, but this looks good.

May 25 2020, 20:14
majcosta committed rABCcbbcffd5072a: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const (authored by majcosta).
[refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const
May 25 2020, 20:10
majcosta closed D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.
May 25 2020, 20:10
majcosta committed rABCf4912034ad46: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#14453] rpc: Fix wallet unload during walletpassphrase timeout
May 25 2020, 20:09
majcosta closed D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.
May 25 2020, 20:09
teamcity added a comment to D6243: [BUILD] Search and include OpenSSL only where required.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 19:36
Fabien accepted D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.
May 25 2020, 19:34
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 19:33
Fabien accepted D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.
May 25 2020, 19:30
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 19:29
teamcity added a comment to D6243: [BUILD] Search and include OpenSSL only where required.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 19:29
teamcity added a comment to D6243: [BUILD] Search and include OpenSSL only where required.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 19:27
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 19:26
teamcity added a comment to D6243: [BUILD] Search and include OpenSSL only where required.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 19:26
teamcity added a comment to D6243: [BUILD] Search and include OpenSSL only where required.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 19:26
teamcity added a comment to D6243: [BUILD] Search and include OpenSSL only where required.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 19:26
Fabien updated the diff for D6243: [BUILD] Search and include OpenSSL only where required.

Rebase on top of D6251.

May 25 2020, 19:25
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 19:24
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 19:23
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 19:23
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 19:23
Fabien updated the diff for D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Fix component

May 25 2020, 19:22
Fabien updated the summary of D6243: [BUILD] Search and include OpenSSL only where required.
May 25 2020, 19:22
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 19:22
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 19:21
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 19:18
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 19:18
teamcity added a comment to D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 19:18
Fabien requested review of D6251: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config.
May 25 2020, 19:18
teamcity added a comment to D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 18:39
teamcity added a comment to D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 18:33
teamcity added a comment to D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 18:30
teamcity added a comment to D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 18:28
teamcity added a comment to D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 18:28
teamcity added a comment to D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 18:28
majcosta requested review of D6250: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.
May 25 2020, 18:28
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 17:43
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 17:36
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 17:33
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 17:33
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 17:30
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 17:30
teamcity added a comment to D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 25 2020, 17:20
teamcity updated the summary of D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.
May 25 2020, 17:20
majcosta requested review of D6249: [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout.
May 25 2020, 17:20
majcosta committed rABC51aed4714a36: [backport#15652] qa: Check unconfirmed balance after loadwallet (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#15652] qa: Check unconfirmed balance after loadwallet
May 25 2020, 17:11
majcosta closed D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.
May 25 2020, 17:11
majcosta committed rABCb1b46a3606a1: [backport#15652] wallet: Update transactions with current mempool after load (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#15652] wallet: Update transactions with current mempool after load
May 25 2020, 17:11
majcosta closed D6247: [backport#15652] wallet: Update transactions with current mempool after load.
May 25 2020, 17:11
deadalnix requested changes to D6243: [BUILD] Search and include OpenSSL only where required.
May 25 2020, 17:09
deadalnix accepted D6247: [backport#15652] wallet: Update transactions with current mempool after load.
May 25 2020, 17:08
deadalnix accepted D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.
May 25 2020, 17:07
deadalnix requested changes to D5987: Start using Logger for seeder logging.
May 25 2020, 17:06
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 16:39
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 16:38
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 16:32
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 16:31
Fabien requested review of D6243: [BUILD] Search and include OpenSSL only where required.
May 25 2020, 16:31
majcosta committed rABCaed5f059b93d: [backport#15652] interfaces: Add Chain::requestMempoolTransactions (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#15652] interfaces: Add Chain::requestMempoolTransactions
May 25 2020, 16:30
majcosta closed D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.
May 25 2020, 16:30
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 16:30
majcosta committed rABCdc54947740c3: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to…
May 25 2020, 16:30
majcosta closed D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.
May 25 2020, 16:30
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 16:29
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 16:29
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 16:29
teamcity added a comment to D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 25 2020, 16:29
teamcity updated the summary of D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.
May 25 2020, 16:29
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 16:28
majcosta requested review of D6248: [backport#15652] qa: Check unconfirmed balance after loadwallet.
May 25 2020, 16:28
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 16:27
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 16:27
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 16:27
teamcity added a comment to D6247: [backport#15652] wallet: Update transactions with current mempool after load.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 25 2020, 16:27
teamcity updated the summary of D6247: [backport#15652] wallet: Update transactions with current mempool after load.
May 25 2020, 16:27
majcosta requested review of D6247: [backport#15652] wallet: Update transactions with current mempool after load.
May 25 2020, 16:27
deadalnix requested changes to D5956: Add -datadir option to allow specification of seeder's data directory.
May 25 2020, 16:23
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 16:16
deadalnix requested changes to D6127: Add options to seeder to determine initial seed list at start up.

While it is stated nowhere, I can imagine what the purpose of -addseed might be. I have no idea what problem does the connect option solves - not even consistency because names have been changed from bitcoind. That is by far the biggest concern I have with this as one can come up with random things to do that solves no problem essentially forever, creating a mountain of useless code in the process, and usually a few bugs in the process.

May 25 2020, 16:15
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 16:11
deadalnix accepted D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.
May 25 2020, 16:08
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 25 2020, 16:07
deadalnix requested changes to D6243: [BUILD] Search and include OpenSSL only where required.
May 25 2020, 16:07
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 16:06
majcosta updated the summary of D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.
May 25 2020, 16:05
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 16:04
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 16:04
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 16:04
teamcity updated the summary of D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.
May 25 2020, 16:04
teamcity added a comment to D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 25 2020, 16:04
majcosta requested review of D6246: [backport#15652] interfaces: Add Chain::requestMempoolTransactions.
May 25 2020, 16:04
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 25 2020, 16:01
deadalnix accepted D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.
May 25 2020, 16:00
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 25 2020, 15:59
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 25 2020, 15:56
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 25 2020, 15:56
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 25 2020, 15:56
teamcity added a comment to D6245: [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 25 2020, 15:56