Page MenuHomePhabricator
Feed All Stories

Jun 12 2021

teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Jun 12 2021, 22:04
teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Jun 12 2021, 22:02
teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Jun 12 2021, 22:02
majcosta requested review of D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Jun 12 2021, 21:54
sophiathomas updated sophiathomas.
Jun 12 2021, 10:50

Jun 11 2021

teamcity closed T1657: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Jun 11 2021, 21:35
Fabien committed rABC6c8fe417321e: Fix p2p_inv_download test (authored by Fabien).
Fix p2p_inv_download test
Jun 11 2021, 20:29
teamcity closed T1656: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Resolved.
Jun 11 2021, 20:05
teamcity closed T1654: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jun 11 2021, 20:03
majcosta committed rABCa5b6b9631c7e: [refactor] CURRENCY_UNIT into Currency class (authored by majcosta).
[refactor] CURRENCY_UNIT into Currency class
Jun 11 2021, 20:00
PiRK planned changes to D9661: [avalanche] add nodes when we have received their proof.

I will investigate the test failure tomorrow. For now I can't reproduce it at home.

Jun 11 2021, 20:00
teamcity closed T1655: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Jun 11 2021, 19:59
teamcity closed T1652: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Resolved.
Jun 11 2021, 19:56
teamcity closed T1650: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Jun 11 2021, 19:55
teamcity closed T1653: Build Bitcoin-ABC / Master / Build without CLI is broken. as Resolved.
Jun 11 2021, 19:55
teamcity closed T1649: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Resolved.
Jun 11 2021, 19:52
teamcity added a comment to D9661: [avalanche] add nodes when we have received their proof.
Jun 11 2021, 19:49
teamcity closed T1651: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Resolved.
Jun 11 2021, 19:47
teamcity closed T1648: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Resolved.
Jun 11 2021, 19:46
PiRK published D9661: [avalanche] add nodes when we have received their proof for review.
Jun 11 2021, 19:43
Fabien committed rABC5a05c5a37dd9: [avalanche] Fix the avalanche_proof_inventory test (authored by Fabien).
[avalanche] Fix the avalanche_proof_inventory test
Jun 11 2021, 19:38
PiRK accepted D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Jun 11 2021, 19:33
teamcity triaged T1657: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Jun 11 2021, 19:30
teamcity triaged T1656: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Unbreak Now! priority.
Jun 11 2021, 19:20
teamcity triaged T1655: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jun 11 2021, 19:20
teamcity triaged T1654: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jun 11 2021, 19:19
teamcity triaged T1653: Build Bitcoin-ABC / Master / Build without CLI is broken. as Unbreak Now! priority.
Jun 11 2021, 19:17
teamcity triaged T1652: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
Jun 11 2021, 19:16
teamcity triaged T1651: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Unbreak Now! priority.
Jun 11 2021, 19:16
teamcity triaged T1650: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Jun 11 2021, 19:15
teamcity triaged T1649: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Unbreak Now! priority.
Jun 11 2021, 19:15
teamcity triaged T1648: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Unbreak Now! priority.
Jun 11 2021, 19:09
Fabien closed D9662: [avalanche] Manage proof reception.
Jun 11 2021, 19:01
Fabien committed rABCe691658b0787: [avalanche] Manage proof reception (authored by Fabien).
[avalanche] Manage proof reception
Jun 11 2021, 19:01
Fabien closed D9660: [avalanche] Don't request orphaned proofs.
Jun 11 2021, 19:00
Fabien committed rABC645e9ffb0fa9: [avalanche] Don't request orphaned proofs (authored by Fabien).
[avalanche] Don't request orphaned proofs
Jun 11 2021, 18:59
Fabien updated the diff for D9668: [avalanche] Check the return value of the delegation addLevel() at startup.

Rebase on top of D9365. The failure case is now unreachable from the tests, but it's still more robust to check the return value.

Jun 11 2021, 14:16
Fabien updated the summary of D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Jun 11 2021, 14:14
Fabien updated the diff for D9365: [avalanche] Add an option to import a delegation.

Rebase. The updated version for this diff and the compagnon D9445 should address all the feedback

Jun 11 2021, 14:06
Fabien updated the summary of D9365: [avalanche] Add an option to import a delegation.
Jun 11 2021, 14:04
Fabien updated the diff for D9445: [avalanche] Check the delegation generated at startup is valid.

Rebase. The updated version for this diff and the compagnon D9365 should address all the feedback

Jun 11 2021, 14:03
Fabien updated the summary of D9445: [avalanche] Check the delegation generated at startup is valid.
Jun 11 2021, 14:00
Fabien closed D9669: [avalanche] Make sure the master key matches the proof master.
Jun 11 2021, 13:58
Fabien committed rABC2eaa95beb12c: [avalanche] Make sure the master key matches the proof master (authored by Fabien).
[avalanche] Make sure the master key matches the proof master
Jun 11 2021, 13:58
PiRK accepted D9669: [avalanche] Make sure the master key matches the proof master.
Jun 11 2021, 13:53
Fabien requested review of D9669: [avalanche] Make sure the master key matches the proof master.
Jun 11 2021, 13:35
teamcity closed T1647: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Jun 11 2021, 13:17
teamcity triaged T1647: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Jun 11 2021, 13:12
Fabien planned changes to D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Jun 11 2021, 13:07
majcosta closed D9666: [refactor] use MAX_MONEY constant instead of magic number.
Jun 11 2021, 12:49
majcosta committed rABCcf92888087fb: [refactor] use MAX_MONEY constant instead of magic number (authored by majcosta).
[refactor] use MAX_MONEY constant instead of magic number
Jun 11 2021, 12:49
Fabien abandoned D9471: [avalanche] Improve proof checking at startup.
Jun 11 2021, 12:47
Fabien closed D9667: [avalanche] Capitalize the init error messages and add a dot.
Jun 11 2021, 12:45
Fabien committed rABCaa0cd148c4a4: [avalanche] Capitalize the init error messages and add a dot (authored by Fabien).
[avalanche] Capitalize the init error messages and add a dot
Jun 11 2021, 12:45
Fabien closed D9664: [avalanche] Add a facility to build a delegation from a hex string.
Jun 11 2021, 12:44
Fabien committed rABC8b57df1785a3: [avalanche] Add a facility to build a delegation from a hex string (authored by Fabien).
[avalanche] Add a facility to build a delegation from a hex string
Jun 11 2021, 12:44
Fabien requested review of D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Jun 11 2021, 12:29
PiRK accepted D9666: [refactor] use MAX_MONEY constant instead of magic number.
Jun 11 2021, 12:16
majcosta accepted D9667: [avalanche] Capitalize the init error messages and add a dot.
Jun 11 2021, 12:09
Fabien requested review of D9667: [avalanche] Capitalize the init error messages and add a dot.
Jun 11 2021, 11:39
majcosta requested review of D9666: [refactor] use MAX_MONEY constant instead of magic number.
Jun 11 2021, 10:38
PiRK accepted D9664: [avalanche] Add a facility to build a delegation from a hex string.
Jun 11 2021, 10:29
PiRK accepted D9662: [avalanche] Manage proof reception.
Jun 11 2021, 10:27
majcosta closed D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 11 2021, 10:15
majcosta committed rABC69794949e90c: [eCash] adapt functional tests to the XEC base unit and test it by default (authored by majcosta).
[eCash] adapt functional tests to the XEC base unit and test it by default
Jun 11 2021, 10:15
Fabien requested review of D9664: [avalanche] Add a facility to build a delegation from a hex string.
Jun 11 2021, 10:06
PiRK accepted D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 11 2021, 10:03
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
  • correct two erroneous amounts in wallet_txn_clone to use XEC
  • changed the repr method for CTxOut from using 8 to 2 decimals
Jun 11 2021, 09:57
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

corrections to wallet_txn_clone.py

Jun 11 2021, 08:44
Fabien added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Jun 11 2021, 08:04
teamcity awarded D9663: [eCash] adapt functional tests to the XEC base unit and test it by default a Haypence token.
Jun 11 2021, 08:01
Fabien added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

@bot build-master

Jun 11 2021, 08:01
PiRK requested changes to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 11 2021, 07:37

Jun 10 2021

deadalnix added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 22:14
PiRK added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

OK up to rpc_txoutproof.py

Jun 10 2021, 20:45
majcosta added inline comments to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 19:36
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

thank you for the corrections.

  • updated mempool_limit.py, mempool_packages.py and mempool_unbroadcast.py
  • I've also ditched zeroes after the decimal where they aren't needed in the new unit.
Jun 10 2021, 19:34
PiRK added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

For now I reviewed up-to and including rpc_estimatefee.py

Jun 10 2021, 18:54
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

a few new tests were added since I worked on the diff. their Amounts have been multiplied by a million as well.

Jun 10 2021, 18:43
majcosta planned changes to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

fixing failure

Jun 10 2021, 17:59
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:57
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:51
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:51
PiRK accepted D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 17:45
majcosta requested review of D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:38
majcosta committed rABC6668fc39897a: [eCash] add the XEC base unit and test it by default (authored by majcosta).
[eCash] add the XEC base unit and test it by default
Jun 10 2021, 17:17
Fabien added a comment to D9662: [avalanche] Manage proof reception.

Unrelated failure

Jun 10 2021, 15:46
teamcity added a comment to D9662: [avalanche] Manage proof reception.
Jun 10 2021, 15:41
Fabien requested review of D9662: [avalanche] Manage proof reception.
Jun 10 2021, 15:33
Fabien updated the diff for D9660: [avalanche] Don't request orphaned proofs.

Introduce wait_for_proof to deal with RPC exception when a proof is not found

Jun 10 2021, 14:57
Fabien planned changes to D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 14:42
teamcity closed T1646: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Jun 10 2021, 13:30
Fabien updated the summary of D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 13:29
Fabien updated the diff for D9660: [avalanche] Don't request orphaned proofs.

Rebase

Jun 10 2021, 13:23
Fabien updated the summary of D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 13:22
Fabien abandoned D9493: [avalanche] Prevent sending proof invs multiple times to the same peer.
Jun 10 2021, 13:18
Fabien closed D9659: [avalanche] Add a getrawproof RPC.
Jun 10 2021, 13:18
Fabien abandoned D9489: [avalanche] Annouce our proofs to our peers.
Jun 10 2021, 13:18
Fabien committed rABC5f50f33f0910: [avalanche] Add a getrawproof RPC (authored by Fabien).
[avalanche] Add a getrawproof RPC
Jun 10 2021, 13:18
Fabien closed D9658: [avalanche] Improve proof verification test coverage.
Jun 10 2021, 13:17