Page MenuHomePhabricator
Feed All Stories

Thu, Dec 12

Fabien added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 09:45
tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 09:05
bytesofman published D17338: [mock-chronik-client] Remember to build before publishing for review.
Thu, Dec 12, 06:06
bytesofman closed D17332: [mock-chronik-client] implement ts.
Thu, Dec 12, 04:02
bytesofman committed rABC31d2229d41aa: [mock-chronik-client] implement ts (authored by bytesofman).
[mock-chronik-client] implement ts
Thu, Dec 12, 04:02
emack accepted D17332: [mock-chronik-client] implement ts.
Thu, Dec 12, 02:01
hazzarust added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

This is Tobias' client, the one we use for the explorer. @hazzarust is putting it into the monorepo then will add the failover proxy to it.

ok nice

in that case, not really a big deal about adding stuff like test comments, having this as a starting point is helpful

Thu, Dec 12, 01:19

Wed, Dec 11

roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
Wed, Dec 11, 23:43
bytesofman added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

This is Tobias' client, the one we use for the explorer. @hazzarust is putting it into the monorepo then will add the failover proxy to it.

Wed, Dec 11, 20:21
Fabien added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

Wed, Dec 11, 20:14
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Wed, Dec 11, 20:14
bytesofman requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

Wed, Dec 11, 19:17
roqqit requested review of D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Wed, Dec 11, 17:48
hazzarust updated the summary of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Wed, Dec 11, 16:02
hazzarust updated the test plan for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Wed, Dec 11, 15:59
hazzarust requested review of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Wed, Dec 11, 15:59
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Wed, Dec 11, 13:28
bytesofman updated the diff for D17332: [mock-chronik-client] implement ts.

improve cashtab test mock prep implementation

Wed, Dec 11, 13:10
bytesofman added inline comments to D17332: [mock-chronik-client] implement ts.
Wed, Dec 11, 13:08
hazzarust closed D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Wed, Dec 11, 12:31
hazzarust committed rABC5dbda19390ac: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer. (authored by hazzarust).
[BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.
Wed, Dec 11, 12:31
tobias_ruck accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Wed, Dec 11, 12:05
PiRK added inline comments to D17314: [chronik] add a test for the new JSON RPC interface.
Wed, Dec 11, 11:56
Fabien accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Wed, Dec 11, 11:55
teamcity awarded D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile` a Doubloon token.
Wed, Dec 11, 10:43
Fabien added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Wed, Dec 11, 10:43
Fabien requested changes to D17314: [chronik] add a test for the new JSON RPC interface.

The API is now very good imo

Wed, Dec 11, 10:37
hazzarust updated the diff for D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

fixed indentation issue (timeout was indented in script, removed indentation)

Wed, Dec 11, 10:33
emack requested changes to D17332: [mock-chronik-client] implement ts.
Wed, Dec 11, 10:27
PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

rework the API, use a client object similar to ChronikClient, set a timeout for the socket so that we get an error if the server never replies (or never sends the final \n)

Wed, Dec 11, 09:18
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Wed, Dec 11, 09:14
Fabien requested changes to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

Make sure to run the test plan yourself

Wed, Dec 11, 08:42
johnkuney closed D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Wed, Dec 11, 05:19
johnkuney committed rABC931c83b45e5a: [e.cash] Add openInNewTab prop to /use-ecash buttons (authored by johnkuney).
[e.cash] Add openInNewTab prop to /use-ecash buttons
Wed, Dec 11, 05:19
bytesofman accepted D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Wed, Dec 11, 05:02
bytesofman added inline comments to D17332: [mock-chronik-client] implement ts.
Wed, Dec 11, 05:01
bytesofman updated the diff for D17332: [mock-chronik-client] implement ts.

Better comments on classes in mock-chronik-client

Wed, Dec 11, 04:59
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

improve organization of address.test.ts

Wed, Dec 11, 04:42
johnkuney requested review of D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Wed, Dec 11, 04:35
bytesofman closed D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Wed, Dec 11, 02:31
bytesofman committed rABC567d1dff4119: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode (authored by bytesofman).
[chronik-client] Add support for validate-tx endpoint to ChronikClientNode
Wed, Dec 11, 02:31
bytesofman added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

ok after leaving this for a day or two then looking at it again, understand the constructor overloading comment. cleaned it up, updated tests.

Wed, Dec 11, 02:25
bytesofman published D17332: [mock-chronik-client] implement ts for review.
Wed, Dec 11, 02:24
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

make constructor private, stop supporting so many input types, no overloaded constructor, better test organization

Wed, Dec 11, 02:13
emack accepted D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Wed, Dec 11, 01:52
bytesofman updated the summary of D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Wed, Dec 11, 01:35

Tue, Dec 10

teamcity added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Tue, Dec 10, 21:12
teamcity awarded D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile` a Piece of Eight token.
Tue, Dec 10, 21:08
tobias_ruck added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Tue, Dec 10, 21:07
teamcity closed T3700: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Tue, Dec 10, 20:59
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Fix a typo

Tue, Dec 10, 20:21
Fabien updated the test plan for D17333: [chronik] Add support for TLS to the electrum server.
Tue, Dec 10, 20:19
roqqit closed D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 19:57
roqqit committed rABCe9d7a6220c01: Add symlink to most recent functional test failure directory (authored by roqqit).
Add symlink to most recent functional test failure directory
Tue, Dec 10, 19:57
PiRK accepted D17333: [chronik] Add support for TLS to the electrum server.
Tue, Dec 10, 19:48
Fabien accepted D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 19:31
hazzarust set Slack Username to Harry on hazzarust.
Tue, Dec 10, 19:06
teamcity triaged T3700: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Tue, Dec 10, 19:04
roqqit closed D17330: Run more functional tests in parallel by default.
Tue, Dec 10, 18:08
roqqit committed rABC8917a6f8af6c: Run more functional tests in parallel by default (authored by roqqit).
Run more functional tests in parallel by default
Tue, Dec 10, 18:08
roqqit updated the test plan for D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 17:36
roqqit updated the diff for D17331: Add symlink to most recent functional test failure directory.
  • move lastfailure to top of build_dir
  • ignore OSError exceptions on windows (didn't use contextlib.suppress because I don't think we should ignore it on Linux)
Tue, Dec 10, 17:36
Fabien added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Tue, Dec 10, 17:19
PiRK added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Tue, Dec 10, 17:08
roqqit planned changes to D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 16:51
roqqit closed D17329: Remove incorrect note in functional tests doc.
Tue, Dec 10, 16:48
roqqit committed rABCaeee696108b5: Remove incorrect note in functional tests doc (authored by roqqit).
Remove incorrect note in functional tests doc
Tue, Dec 10, 16:48
roqqit added a comment to D17330: Run more functional tests in parallel by default.
In D17330#393720, @PiRK wrote:

Benchmark on my machine:

DEFAULT_JOBS =  (multiprocessing.cpu_count() // 3) + 1
ALL                                        | ✓ Passed  | 1603 s (accumulated)
Runtime: 179 s


DEFAULT_JOBS = multiprocessing.cpu_count()
ALL                                        | ✓ Passed  | 2187 s (accumulated)
Runtime: 95 s

DEFAULT_JOBS = 2 * multiprocessing.cpu_count()
ALL                                        | ✖ Failed  | 2583 s (accumulated)
Runtime: 68 s

With one port issue in the 2 * cpu_count attempt.

RuntimeError: Could not find available PortName.P2P port after 5 attempts.
Tue, Dec 10, 16:47
Fabien requested review of D17333: [chronik] Add support for TLS to the electrum server.
Tue, Dec 10, 14:54
bytesofman closed D17326: [Cashtab] Convert airdrop screen and deps to ts.
Tue, Dec 10, 14:26
bytesofman committed rABCc5f7246e7aeb: [Cashtab] Convert airdrop screen and deps to ts (authored by bytesofman).
[Cashtab] Convert airdrop screen and deps to ts
Tue, Dec 10, 14:26
bytesofman added inline comments to D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Tue, Dec 10, 14:18
bytesofman updated the diff for D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.

Add input type validation, add test to confirm uint8array input is also supported

Tue, Dec 10, 14:16
bytesofman closed D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Tue, Dec 10, 13:50
bytesofman committed rABC2c10d5fb3e97: [Cashtab] Convert Tx screen and its deps to typescript (authored by bytesofman).
[Cashtab] Convert Tx screen and its deps to typescript
Tue, Dec 10, 13:50
teamcity closed T3696: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Linux is broken. as Resolved.
Tue, Dec 10, 12:41
teamcity closed T3695: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Windows is broken. as Resolved.
Tue, Dec 10, 12:21
teamcity closed T3694: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX MacOS is broken. as Resolved.
Tue, Dec 10, 12:17
Fabien requested changes to D17314: [chronik] add a test for the new JSON RPC interface.
Tue, Dec 10, 09:06
PiRK added a comment to D17330: Run more functional tests in parallel by default.

Benchmark on my machine:

Tue, Dec 10, 08:45
PiRK added inline comments to D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 08:31
PiRK accepted D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 08:25
emack accepted D17326: [Cashtab] Convert airdrop screen and deps to ts.
Tue, Dec 10, 08:13
Fabien requested changes to D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 08:11
Fabien accepted D17330: Run more functional tests in parallel by default.
Tue, Dec 10, 08:08
emack requested changes to D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Tue, Dec 10, 08:07
emack accepted D17328: [token-server] Bump free xec from 42 to 88.
Tue, Dec 10, 08:02
emack accepted D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Tue, Dec 10, 07:57
bytesofman published D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode for review.
Tue, Dec 10, 06:21
bytesofman accepted D17329: Remove incorrect note in functional tests doc.
Tue, Dec 10, 04:59
roqqit requested review of D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 00:51

Mon, Dec 9

roqqit requested review of D17330: Run more functional tests in parallel by default.
Mon, Dec 9, 22:47
roqqit requested review of D17329: Remove incorrect note in functional tests doc.
Mon, Dec 9, 21:54
roqqit closed D17327: Use os.cpu_count in test_runner instead of multiprocessing.
Mon, Dec 9, 21:12
roqqit committed rABCe0198d8be5cd: Use os.cpu_count in test_runner instead of multiprocessing (authored by roqqit).
Use os.cpu_count in test_runner instead of multiprocessing
Mon, Dec 9, 21:12
bytesofman published D17328: [token-server] Bump free xec from 42 to 88 for review.
Mon, Dec 9, 21:05
PiRK accepted D17327: Use os.cpu_count in test_runner instead of multiprocessing.
Mon, Dec 9, 20:46
roqqit requested review of D17327: Use os.cpu_count in test_runner instead of multiprocessing.
Mon, Dec 9, 19:43
bytesofman published D17326: [Cashtab] Convert airdrop screen and deps to ts for review.
Mon, Dec 9, 19:34
Fabien closed D17325: [chronik] Bump karyon dependency to 0.1.8.
Mon, Dec 9, 18:49